From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91624C432C0 for ; Mon, 25 Nov 2019 07:17:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 70C432071A for ; Mon, 25 Nov 2019 07:17:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725763AbfKYHR6 (ORCPT ); Mon, 25 Nov 2019 02:17:58 -0500 Received: from mailbackend.panix.com ([166.84.1.89]:60300 "EHLO mailbackend.panix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725747AbfKYHR6 (ORCPT ); Mon, 25 Nov 2019 02:17:58 -0500 Received: from hp-x360n (c-73-241-154-233.hsd1.ca.comcast.net [73.241.154.233]) by mailbackend.panix.com (Postfix) with ESMTPSA id 47Lyzl6wRBz1KC3; Mon, 25 Nov 2019 02:17:55 -0500 (EST) Date: Sun, 24 Nov 2019 23:17:54 -0800 (PST) From: "Kenneth R. Crudup" Reply-To: "Kenneth R. Crudup" To: "Rafael J. Wysocki" cc: Rafael Wysocki , Linux PM Subject: Re: Help me fix a regression caused by 56b9918490 (PM: sleep: Simplify suspend-to-idle control flow) In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Sun, 24 Nov 2019, Kenneth R. Crudup wrote: > Huh- so this is encouraging- I've removed these lines, and while I haven't > been able to kill it yet (give me time :)) what DOES happen now is I get > wakeups from sleep on POWER events- charger connect (and disconnect)- and > now I wonder if this is somehow related to the issue of the suspend not > resuming if the machine is charging? Also, the system will not suspend if the charger is attached; it's kind of like the "sleep_no_lps0=1" behavior (BTW, neither "sleep_no_lps0" nor "ec_no_wakeup" have been modified from the defaults of "0" while those lines have been deleted). I've done 14 suspend cycles according to /sys/power/suspend_stats/success so far, and while none of them have been for more than an hour or so, the laptop is cold when I do resume it. I can't tell what the power draw is any more 'cause it won't sleep while an external charger is connected- which I can live with if it means the laptop doesn't get stuck in that intermediate suspend state where it draws > 3x more current than the lowest idle state. -Kenny -- Kenneth R. Crudup Sr. SW Engineer, Scott County Consulting, Silicon Valley