From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F494C432C0 for ; Wed, 27 Nov 2019 02:35:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 319AB20722 for ; Wed, 27 Nov 2019 02:35:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726526AbfK0Cfr (ORCPT ); Tue, 26 Nov 2019 21:35:47 -0500 Received: from mailbackend.panix.com ([166.84.1.89]:64032 "EHLO mailbackend.panix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726346AbfK0Cfr (ORCPT ); Tue, 26 Nov 2019 21:35:47 -0500 Received: from hp-x360n (wsip-72-215-210-42.oc.oc.cox.net [72.215.210.42]) by mailbackend.panix.com (Postfix) with ESMTPSA id 47N4dG39SWz1WSQ; Tue, 26 Nov 2019 21:35:46 -0500 (EST) Date: Tue, 26 Nov 2019 18:35:45 -0800 (PST) From: "Kenneth R. Crudup" Reply-To: "Kenneth R. Crudup" To: "Rafael J. Wysocki" cc: "Rafael J. Wysocki" , Rafael Wysocki , Linux PM Subject: Re: Help me fix a regression caused by 56b9918490 (PM: sleep: Simplify suspend-to-idle control flow) In-Reply-To: Message-ID: References: <12933162.9b7K5rSXZx@kreacher> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Tue, 26 Nov 2019, Kenneth R. Crudup wrote: > So there were some 5 times where my laptop spontaneously (I'll bet it was > that damned accelerometer) woke up, sometimes for minutes at at time, all > the while in my laptop bag. ... > But the great news about this is this maybe explains why I'll try and resume > after being mobile; whatever awakening we used to do wouldn't be handled > (again, guessing :)) and we'd freeze up. So I'd just realized something- when you'd first pushed the series of commits changing the S2idle flow, I'd sent an E-mail about some issues I'd had: ---- Date: Wed, 18 Sep 2019 18:05:53 From: Kenneth R. Crudup To: rafael.j.wysocki@intel.com Cc: linux-pm@vger.kernel.org Message-ID: Subject: Help me help you debug what seems to be an EC resume issue ... >>> Before these commits, I used to set "acpi.ec_no_wakeup=1" because the >>> orientation sensor (at least, and probably other things) would wake up >>> the laptop (then immediately suspend), which I'm sure was using up >>> battery while I'm just walking around. >>> I've turned off "ec_no_wakeup" for testing and the good news is the >>> orientation sensor doesn't cause the laptop to draw more power when shaking it. ---- Whoops- I guess in the face of everything we now know, that was indeed a bug and not a feature, because I'd also posted: >>> Randomly, if left suspended, nothing other than a hard power off will get >>> it back (and I can't be sure, but I think current consumption can be normal >>> when it suspends, but this seems to only happen if I've unplugged the >>> charger after suspending (so no power meter)) So now we know. So, now that apparently (fingers still crossed, but so far, so very good) you've squashed that resume bug, do I have any recourse about this thing waking up for just by staring at it very hard other than "ec_no_wakeup=1"? Personally I don't mind at all having the keyboard being the only thing that'll take the laptop out of suspend, and the only reason I was looking for not having to modify the EC operation was 'cause I thought having that set meant we'd short-circuited some other s2idle optimization, and I'm constantly trying to minimize s2idle power consumption. If all "ec_no_wakeup=1" actually does is silently ignore EC wakeup events, then I'll stick with it. Thanks, -Kenny -- Kenneth R. Crudup Sr. SW Engineer, Scott County Consulting, Silicon Valley