From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Thara Gopinath <thara.gopinath@linaro.org>,
rui.zhang@intel.com, robh+dt@kernel.org
Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/4] dt-bindings:thermal:Add cold trip point type
Date: Mon, 13 Jul 2020 19:03:39 +0200 [thread overview]
Message-ID: <b1ee5a73-863b-c6d2-5d09-1ac231f40fe2@linaro.org> (raw)
In-Reply-To: <2b845792-41f0-7fb1-122e-a77aa70c9a3c@linaro.org>
On 13/07/2020 19:01, Thara Gopinath wrote:
>
>
> On 7/13/20 11:05 AM, Daniel Lezcano wrote:
>> On 10/07/2020 15:51, Thara Gopinath wrote:
>>> Extend thermal trip point type property to include "cold" trip type
>>> indicating point in the temperature domain below which a warming action
>>> must be intiated.
>>>
>>> Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org>
>>> ---
>>> Documentation/devicetree/bindings/thermal/thermal.txt | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt
>>> b/Documentation/devicetree/bindings/thermal/thermal.txt
>>> index f78bec19ca35..1689d9ba1471 100644
>>> --- a/Documentation/devicetree/bindings/thermal/thermal.txt
>>> +++ b/Documentation/devicetree/bindings/thermal/thermal.txt
>>> @@ -87,6 +87,7 @@ Required properties:
>>> "active": A trip point to enable active cooling
>>> "passive": A trip point to enable passive cooling
>>> "hot": A trip point to notify emergency
>>> + "cold": A trip point to enable warming
>>> "critical": Hardware not reliable.
>>> Type: string
>>
>>
>> thermal.txt should have been removed. Perhaps, a patch is missing. The
>> thermal.txt has been converted into 3 yaml schema.
>>
>> The change should be in thermal-zones.yaml.
>
> Hi Daniel..
>
> Thanks for the review. My bad.. I will fix this in the next version.
> I can send a patch removing thermal.txt as well
Yes, sure.
Thanks
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2020-07-13 17:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 13:51 [RFC PATCH 0/4] thermal: Introduce support for monitoring falling temperature Thara Gopinath
2020-07-10 13:51 ` [RFC PATCH 1/4] dt-bindings:thermal:Add cold trip point type Thara Gopinath
2020-07-13 15:05 ` Daniel Lezcano
2020-07-13 17:01 ` Thara Gopinath
2020-07-13 17:03 ` Daniel Lezcano [this message]
2020-07-10 13:51 ` [RFC PATCH 2/4] thermal: Add support for cold trip point Thara Gopinath
2020-07-10 13:51 ` [RFC PATCH 3/4] thermal:core:Add genetlink notifications for monitoring falling temperature Thara Gopinath
2020-07-15 8:46 ` Zhang Rui
2020-07-15 23:15 ` Thara Gopinath
2020-07-10 13:51 ` [RFC PATCH 4/4] thermal: Modify thermal governors to do nothing for "cold" trip points Thara Gopinath
2020-07-15 8:35 ` Zhang Rui
2020-07-15 23:13 ` Thara Gopinath
2020-07-13 15:03 ` [RFC PATCH 0/4] thermal: Introduce support for monitoring falling temperature Daniel Lezcano
2020-07-14 13:49 ` Zhang Rui
2020-07-14 21:39 ` Thara Gopinath
2020-07-15 8:27 ` Zhang Rui
2020-07-15 23:10 ` Thara Gopinath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1ee5a73-863b-c6d2-5d09-1ac231f40fe2@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=thara.gopinath@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).