From: Neil Armstrong <narmstrong@baylibre.com>
To: Guillaume La Roque <glaroque@baylibre.com>,
daniel.lezcano@linaro.org, khilman@baylibre.com
Cc: devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 4/6] arm64: dts: meson: sei510: Add minimal thermal zone
Date: Wed, 31 Jul 2019 14:51:39 +0200 [thread overview]
Message-ID: <c451fd49-bf3d-b7d7-46ba-43ac7bed3b90@baylibre.com> (raw)
In-Reply-To: <20190731121409.17285-5-glaroque@baylibre.com>
On 31/07/2019 14:14, Guillaume La Roque wrote:
> Add minimal thermal zone for DDR and CPU sensor
>
> Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts b/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts
> index c7a87368850b..79ae514e238d 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts
> @@ -33,6 +33,19 @@
> ethernet0 = ðmac;
> };
>
> + thermal-zones {
> + soc_thermal {
> + polling-delay = <1000>;
> + polling-delay-ptripsassive = <100>;
> + thermal-sensors = <&cpu_temp 0>;
Seems the trips & cooling-maps are required as described in thermal.txt
For the soc_thermal zone it's esy to add a cooling map with the CPU
and cooling devices, but for the ddr_thermal, no idea if we can use the
CPUs within 2 cooling maps.
> + };
I would add a blank line between the zones, same for other files.
> + ddr_thermal {
> + polling-delay = <1000>;
> + polling-delay-passive = <100>;
> + thermal-sensors = <&ddr_temp 1>;
> + };
> + };
> +
> mono_dac: audio-codec-0 {
> compatible = "maxim,max98357a";
> #sound-dai-cells = <0>;
>
next prev parent reply other threads:[~2019-07-31 12:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 12:14 [PATCH 0/6] Add support of New Amlogic temperature sensor for G12 SoCs Guillaume La Roque
2019-07-31 12:14 ` [PATCH 1/6] dt-bindings: thermal: Add DT bindings documentation for Amlogic Thermal Guillaume La Roque
2019-07-31 12:44 ` Neil Armstrong
2019-07-31 17:00 ` Rob Herring
2019-07-31 12:14 ` [PATCH 2/6] thermal: amlogic: Add thermal driver to support G12 SoCs Guillaume La Roque
2019-07-31 12:45 ` Neil Armstrong
2019-07-31 12:14 ` [PATCH 3/6] arm64: dts: amlogic: g12: add temperature sensor Guillaume La Roque
2019-07-31 12:14 ` [PATCH 4/6] arm64: dts: meson: sei510: Add minimal thermal zone Guillaume La Roque
2019-07-31 12:51 ` Neil Armstrong [this message]
2019-07-31 12:14 ` [PATCH 5/6] arm64: dts: amlogic: odroid-n2: add " Guillaume La Roque
2019-07-31 12:14 ` [PATCH 6/6] MAINTAINERS: add entry for Amlogic Thermal driver Guillaume La Roque
2019-07-31 12:52 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c451fd49-bf3d-b7d7-46ba-43ac7bed3b90@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=glaroque@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).