From: Matheus Castello <matheus@castello.eng.br>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: sre@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Bartłomiej Żołnierkiewicz" <b.zolnierkie@samsung.com>,
lee.jones@linaro.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] power: supply: max17040: Add IRQ handler for low SOC alert
Date: Fri, 19 Apr 2019 15:12:48 -0300 [thread overview]
Message-ID: <c4bffa4d-36bb-1f6c-cf56-69a990d9b832@castello.eng.br> (raw)
In-Reply-To: <CAJKOXPfXS_L992rPdHqitFyRmw93En9GRLVOjRRnwGgiEwV28Q@mail.gmail.com>
Em 4/15/19 4:10 AM, Krzysztof Kozlowski escreveu:
> On Mon, 15 Apr 2019 at 03:49, Matheus Castello <matheus@castello.eng.br> wrote:
>>
>> According datasheet max17040 has a pin for alert host for low SOC.
>> This pin can be used as external interrupt, so we need to check for
>> interrupts assigned for device and handle it.
>>
>> In hadler we are checking and storing fuel gauge registers values
>> and send an uevent to notificate user space, so user space can decide
>> save work or turn off since the alert demonstrate that the battery may
>> no have the power to keep the system turned on for much longer.
>>
>> Signed-off-by: Matheus Castello <matheus@castello.eng.br>
>> ---
>> drivers/power/supply/max17040_battery.c | 69 +++++++++++++++++++++++--
>> 1 file changed, 64 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/power/supply/max17040_battery.c b/drivers/power/supply/max17040_battery.c
>> index 91cafc7bed30..8d2f8ed3f44c 100644
>> --- a/drivers/power/supply/max17040_battery.c
>> +++ b/drivers/power/supply/max17040_battery.c
>> @@ -13,6 +13,7 @@
>> #include <linux/err.h>
>> #include <linux/i2c.h>
>> #include <linux/delay.h>
>> +#include <linux/interrupt.h>
>> #include <linux/power_supply.h>
>> #include <linux/max17040_battery.h>
>> #include <linux/slab.h>
>> @@ -160,21 +161,40 @@ static void max17040_get_status(struct i2c_client *client)
>> chip->status = POWER_SUPPLY_STATUS_FULL;
>> }
>>
>> +static void max17040_check_changes(struct i2c_client *client)
>> +{
>> + max17040_get_vcell(client);
>> + max17040_get_soc(client);
>> + max17040_get_online(client);
>> + max17040_get_status(client);
>> +}
>> +
>> static void max17040_work(struct work_struct *work)
>> {
>> struct max17040_chip *chip;
>>
>> chip = container_of(work, struct max17040_chip, work.work);
>> -
>> - max17040_get_vcell(chip->client);
>> - max17040_get_soc(chip->client);
>> - max17040_get_online(chip->client);
>> - max17040_get_status(chip->client);
>> + max17040_check_changes(chip->client);
>>
>> queue_delayed_work(system_power_efficient_wq, &chip->work,
>> MAX17040_DELAY);
>> }
>>
>> +static irqreturn_t max17040_thread_handler(int id, void *dev)
>> +{
>> + struct max17040_chip *chip = dev;
>> + struct i2c_client *client = chip->client;
>> +
>> + dev_warn(&client->dev, "IRQ: Alert battery low level");
>> + /* read registers */
>> + max17040_check_changes(chip->client);
>> +
>> + /* send uevent */
>> + power_supply_changed(chip->battery);
>> +
>> + return IRQ_HANDLED;
>> +}
>> +
>> static enum power_supply_property max17040_battery_props[] = {
>> POWER_SUPPLY_PROP_STATUS,
>> POWER_SUPPLY_PROP_ONLINE,
>> @@ -217,6 +237,27 @@ static int max17040_probe(struct i2c_client *client,
>> return PTR_ERR(chip->battery);
>> }
>>
>> + /* check interrupt */
>> + if (client->irq) {
>> + int ret;
>> + unsigned int flags;
>> +
>> + dev_info(&client->dev, "IRQ: enabled\n");
>> + flags = IRQF_TRIGGER_FALLING | IRQF_ONESHOT;
>> +
>> + ret = devm_request_threaded_irq(&client->dev, client->irq, NULL,
>> + max17040_thread_handler, flags,
>> + chip->battery->desc->name,
>> + chip);
>> +
>> + if (ret) {
>> + client->irq = 0;
>> + if (ret != -EBUSY)
>
> Why not on EBUSY?
>
>> + dev_warn(&client->dev,
>> + "Failed to get IRQ err %d\n", ret);
>> + }
>> + }
>> +
>> max17040_reset(client);
>> max17040_get_version(client);
>>
>> @@ -224,6 +265,8 @@ static int max17040_probe(struct i2c_client *client,
>> queue_delayed_work(system_power_efficient_wq, &chip->work,
>> MAX17040_DELAY);
>>
>> + device_init_wakeup(&client->dev, 1);
>
> Either you parse DT for wakeup-source property and use it... or you
> unconditionally enable wakeup. In the second case - there is no point
> to check later for device_may_wakeup(). Instead check the return value
> of device_init_wakeup().
>
>> +
>> return 0;
>> }
>>
>> @@ -244,6 +287,14 @@ static int max17040_suspend(struct device *dev)
>> struct max17040_chip *chip = i2c_get_clientdata(client);
>>
>> cancel_delayed_work(&chip->work);
>> +
>> + if (client->irq) {
>> + if (device_may_wakeup(dev))
>> + enable_irq_wake(client->irq);
>> + else
>> + disable_irq_wake(client->irq);
>
> Did you try the wakeup from suspend? You do not have a disable_irq()
> here which usually was needed for interrupts to work properly on
> suspend. Maybe this was fixed?
>
> Best regards,
> Krzysztof
>
Hi Krzysztof,
I test it using mem state and suspend, resuming seems to have worked
correctly ...
Thanks for the review, I'm working in your suggestions and I expect to
send v3 this weekend.
Best Regards,
Matheus Castello
next prev parent reply other threads:[~2019-04-19 18:12 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 4:08 [PATCH 0/4] power: supply: MAX17040: Add IRQ for low level and alert SOC changes Matheus Castello
2018-07-23 4:08 ` [PATCH 1/4] power: supply: max17040: Add IRQ handler for low SOC alert Matheus Castello
2018-07-25 10:27 ` Krzysztof Kozlowski
2018-07-23 4:08 ` [PATCH 2/4] power: supply: max17040: Config alert SOC low level threshold from FDT Matheus Castello
2018-07-25 10:42 ` Krzysztof Kozlowski
2018-07-23 4:08 ` [PATCH 3/4] dt-bindings: power: supply: Max17040: Add low level SOC alert threshold Matheus Castello
2018-07-25 10:45 ` Krzysztof Kozlowski
2018-07-23 4:08 ` [PATCH 4/4] power: supply: max17040: Send uevent in SOC changes Matheus Castello
2018-07-25 10:52 ` Krzysztof Kozlowski
2018-09-16 11:45 ` [PATCH 0/4] power: supply: MAX17040: Add IRQ for low level and alert " Sebastian Reichel
2018-09-17 11:32 ` Krzysztof Kozlowski
2018-09-18 3:45 ` Matheus Castello
2019-04-15 1:26 ` [PATCH v2 " Matheus Castello
2019-04-15 1:26 ` Matheus Castello
2019-04-15 1:26 ` [PATCH v2 1/4] power: supply: max17040: Add IRQ handler for low SOC alert Matheus Castello
2019-04-15 1:26 ` Matheus Castello
2019-04-15 7:10 ` Krzysztof Kozlowski
2019-04-15 7:10 ` Krzysztof Kozlowski
2019-04-19 18:12 ` Matheus Castello [this message]
2019-04-19 18:12 ` Matheus Castello
2019-04-15 1:26 ` [PATCH v2 2/4] dt-bindings: power: supply: Max17040: Add low level SOC alert threshold Matheus Castello
2019-04-15 1:26 ` Matheus Castello
2019-04-15 7:13 ` Krzysztof Kozlowski
2019-04-15 7:13 ` Krzysztof Kozlowski
2019-04-29 22:13 ` Rob Herring
2019-04-29 22:13 ` Rob Herring
2019-05-26 23:13 ` Matheus Castello
2019-04-15 1:26 ` [PATCH v2 3/4] power: supply: max17040: Config alert SOC low level threshold from FDT Matheus Castello
2019-04-15 1:26 ` Matheus Castello
2019-04-15 7:27 ` Krzysztof Kozlowski
2019-04-15 7:27 ` Krzysztof Kozlowski
2019-04-15 1:26 ` [PATCH v2 4/4] power: supply: max17040: Send uevent in SOC changes Matheus Castello
2019-04-15 1:26 ` Matheus Castello
2019-04-15 7:30 ` Krzysztof Kozlowski
2019-04-15 7:30 ` Krzysztof Kozlowski
2019-05-27 2:22 ` [PATCH v3 0/5] power: supply: MAX17040: Add IRQ for low level and alert " Matheus Castello
2019-05-27 2:22 ` [PATCH v3 1/5] power: supply: max17040: Add IRQ handler for low SOC alert Matheus Castello
2019-05-29 14:26 ` Krzysztof Kozlowski
2019-05-27 2:22 ` [PATCH v3 2/5] dt-bindings: power: supply: Max17040: Add low level SOC alert threshold Matheus Castello
2019-05-29 14:40 ` Krzysztof Kozlowski
2019-05-29 14:57 ` Krzysztof Kozlowski
2019-06-02 21:38 ` Matheus Castello
2019-06-05 12:04 ` Krzysztof Kozlowski
2019-05-27 2:22 ` [PATCH v3 3/5] power: supply: max17040: Config alert SOC low level threshold from FDT Matheus Castello
2019-05-29 14:46 ` Krzysztof Kozlowski
2019-06-02 22:26 ` Matheus Castello
2019-06-05 12:05 ` Krzysztof Kozlowski
2019-05-27 2:22 ` [PATCH v3 4/5] power: supply: max17040: Clear ALRT bit when the SOC are above threshold Matheus Castello
2019-05-29 14:54 ` Krzysztof Kozlowski
2019-05-27 2:22 ` [PATCH v3 5/5] power: supply: max17040: Send uevent in SOC and status change Matheus Castello
2019-05-29 15:00 ` Krzysztof Kozlowski
2019-10-31 18:41 ` [PATCH v4 0/4] power: supply: MAX17040: Add IRQ for low level and alert SOC changes Matheus Castello
2019-10-31 18:41 ` [PATCH v4 1/4] power: supply: max17040: Add IRQ handler for low SOC alert Matheus Castello
2019-11-01 15:08 ` Krzysztof Kozlowski
2019-10-31 18:41 ` [PATCH v4 2/4] dt-bindings: power: supply: Max17040: Add low level SOC alert threshold Matheus Castello
2019-11-01 15:10 ` Krzysztof Kozlowski
2019-11-05 1:58 ` Rob Herring
2019-11-05 5:42 ` [PATCH v5 0/5] power: supply: MAX17040: Add IRQ for low level and alert SOC changes Matheus Castello
2019-11-05 5:42 ` [PATCH v5 1/5] power: supply: max17040: Add IRQ handler for low SOC alert Matheus Castello
2019-11-05 5:42 ` [PATCH v5 2/5] dt-bindings: power: supply: Max17040: Add DT bindings for max17040 fuel gauge Matheus Castello
2019-11-05 5:42 ` [PATCH v5 3/5] devicetree: mfd: max14577: Add reference to max14040_battery.txt descriptions Matheus Castello
2019-11-05 5:42 ` [PATCH v5 4/5] power: supply: max17040: Config alert SOC low level threshold from FDT Matheus Castello
2019-11-05 9:59 ` Krzysztof Kozlowski
2019-11-07 3:17 ` [PATCH v6 0/5] power: supply: MAX17040: Add IRQ for low level and alert SOC changes Matheus Castello
2019-11-07 3:17 ` [PATCH v6 1/5] power: supply: max17040: Add IRQ handler for low SOC alert Matheus Castello
2019-11-07 3:17 ` [PATCH v6 2/5] dt-bindings: power: supply: Max17040: Add DT bindings for max17040 fuel gauge Matheus Castello
2019-11-14 0:53 ` Rob Herring
2019-11-07 3:17 ` [PATCH v6 3/5] devicetree: mfd: max14577: Add reference to max14040_battery.txt descriptions Matheus Castello
2019-11-11 10:09 ` Lee Jones
2019-11-14 0:54 ` Rob Herring
2019-11-07 3:17 ` [PATCH v6 4/5] power: supply: max17040: Config alert SOC low level threshold from FDT Matheus Castello
2019-11-07 3:17 ` [PATCH v6 5/5] power: supply: max17040: Send uevent in SOC and status change Matheus Castello
2019-11-11 9:59 ` [PATCH v6 0/5] power: supply: MAX17040: Add IRQ for low level and alert SOC changes Lee Jones
2019-11-05 5:42 ` [PATCH v5 5/5] power: supply: max17040: Send uevent in SOC and status change Matheus Castello
2019-10-31 18:41 ` [PATCH v4 3/4] power: supply: max17040: Config alert SOC low level threshold from FDT Matheus Castello
2019-11-01 15:27 ` Krzysztof Kozlowski
2019-11-01 16:52 ` Matheus Castello
2019-11-02 18:12 ` Matheus Castello
2019-11-04 11:04 ` Krzysztof Kozlowski
2019-11-04 10:59 ` Krzysztof Kozlowski
2019-10-31 18:41 ` [PATCH v4 4/4] power: supply: max17040: Send uevent in SOC and status change Matheus Castello
2019-11-01 15:30 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4bffa4d-36bb-1f6c-cf56-69a990d9b832@castello.eng.br \
--to=matheus@castello.eng.br \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).