From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82929C43462 for ; Wed, 12 May 2021 04:47:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 556546187E for ; Wed, 12 May 2021 04:47:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230075AbhELEs4 (ORCPT ); Wed, 12 May 2021 00:48:56 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:40180 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230018AbhELEsy (ORCPT ); Wed, 12 May 2021 00:48:54 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1620794867; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=IWt2toohdxLCE2CFRRMmRw4/HdGmAbB02mam/jKAH7k=; b=HzzcoXco4iIesdQKssSW9gNy4s+fGmjQn9QZzP/fEYCbjOC8xbQIWJOkHZNfp7VYPr0JdDoC mQJCRltW6shsyrDfDz9kx5BEUppt4wh9d6NFtfMugztj1Kus34eAL1afpH/NwkFPdDSXtpEh s8dhUhl/kskb2s26eP8YcUU/a9I= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI5ZDFmMiIsICJsaW51eC1wbUB2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 609b5df04ab9954eb8c8f4e2 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 12 May 2021 04:47:44 GMT Sender: skakit=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 72312C4323A; Wed, 12 May 2021 04:47:44 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: skakit) by smtp.codeaurora.org (Postfix) with ESMTPSA id AB931C433D3; Wed, 12 May 2021 04:47:43 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 12 May 2021 10:17:43 +0530 From: skakit@codeaurora.org To: Rob Herring Cc: Bjorn Andersson , kgunda@codeaurora.org, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, Courtney Cavin , Vinod Koul , Sebastian Reichel , Dmitry Torokhov , David Collins , Andy Yan , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, devicetree@vger.kernel.org, Andy Gross Subject: Re: [PATCH V3 4/5] dt-bindings: input: pm8941-pwrkey: Convert pm8941 power key binding to yaml In-Reply-To: <20210510162445.GA230005@robh.at.kernel.org> References: <1620630064-16354-1-git-send-email-skakit@codeaurora.org> <1620630064-16354-5-git-send-email-skakit@codeaurora.org> <1620655299.793818.41438.nullmailer@robh.at.kernel.org> <20210510162445.GA230005@robh.at.kernel.org> Message-ID: X-Sender: skakit@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 2021-05-10 21:54, Rob Herring wrote: > On Mon, May 10, 2021 at 09:01:39AM -0500, Rob Herring wrote: >> On Mon, 10 May 2021 12:31:03 +0530, satya priya wrote: >> > Convert qcom pm8941 power key binding from .txt to .yaml format. >> > >> > Signed-off-by: satya priya >> > --- >> > Changes in V2: >> > - Fixed bot errors, took reference from input.yaml for "linux,code" >> > - Added one complete example for powerkey and resin, and referenced it >> > in main PON binding. >> > - Moved this patch to the end of the series. >> > >> > Changes in V3: >> > - Moved this patch before PON binding patch. >> > - As per Rob's comments, added allOf at the beginning of binding. >> > Added maxItems for interrupts. >> > - Added 'unevaluatedProperties' instead of 'additionalProperties' as >> > we are using allOf. >> > >> > .../bindings/input/qcom,pm8941-pwrkey.txt | 55 -------------- >> > .../bindings/input/qcom,pm8941-pwrkey.yaml | 87 ++++++++++++++++++++++ >> > 2 files changed, 87 insertions(+), 55 deletions(-) >> > delete mode 100644 Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.txt >> > create mode 100644 Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.yaml >> > >> >> My bot found errors running 'make DT_CHECKER_FLAGS=-m >> dt_binding_check' >> on your patch (DT_CHECKER_FLAGS is new in v5.13): >> >> yamllint warnings/errors: >> >> dtschema/dtc warnings/errors: >> Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.example.dt.yaml:0:0: >> /example-0/spmi@c440000/pmic@0/pon_hlos@1300: failed to match any >> schema with compatible: ['qcom,pm8998-pon'] > > You have the same example in patch 5, so drop the example here. That > will fix this circular dependency. Earlier I have dropped example from qcom-pon.yaml. Now, I will add the example there and drop here.