Linux-PM Archive on
 help / color / Atom feed
From: Daniel Lezcano <>
To: "Niklas Söderlund" <>,
	Geert Uytterhoeven <>
Subject: Re: [PATCH v2] thermal: rcar_thermal: Clean up rcar_thermal_update_temp()
Date: Fri, 22 May 2020 21:10:29 +0200
Message-ID: <> (raw)
In-Reply-To: <>

On 14/05/2020 17:25, Niklas Söderlund wrote:
> Moving the ctemp variable out of the private data structure made it
> possible to clean up rcar_thermal_update_temp(). Initialize the local
> ctemp to the error code to return if the reading fails and just return
> it at the end of the function.
> It's OK to change the datatype of old, new and ctemp to int as all
> values are ANDed with CTEMP (0x3f) before being stored. While at it
> change the datatype of the loop variable 'i' to to unsigned int.
> Suggested-by: Geert Uytterhoeven <>
> Signed-off-by: Niklas Söderlund <>
> Reviewed-by: Geert Uytterhoeven <>
> ---

Applied, thanks

<> │ Open source software for ARM SoCs

Follow Linaro:  <> Facebook |
<!/linaroorg> Twitter |
<> Blog

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-14 15:25 Niklas Söderlund
2020-05-22 19:10 ` Daniel Lezcano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-PM Archive on

Archives are clonable:
	git clone --mirror linux-pm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-pm linux-pm/ \
	public-inbox-index linux-pm

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone