From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ED84C43613 for ; Thu, 20 Jun 2019 14:42:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0C1EE2083B for ; Thu, 20 Jun 2019 14:42:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726551AbfFTOmL (ORCPT ); Thu, 20 Jun 2019 10:42:11 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:49894 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726428AbfFTOmL (ORCPT ); Thu, 20 Jun 2019 10:42:11 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: ezequiel) with ESMTPSA id 8B01A260676 Message-ID: Subject: Re: [PATCH 2/2] PM / devfreq: Sanitize prints From: Ezequiel Garcia To: Chanwoo Choi , Kyungmin Park , MyungJoo Ham Cc: kernel@collabora.com, linux-pm@vger.kernel.org, Enric Balletbo i Serra Date: Thu, 20 Jun 2019 11:41:58 -0300 In-Reply-To: References: <20190605190053.19177-1-ezequiel@collabora.com> <20190605190053.19177-2-ezequiel@collabora.com> Organization: Collabora Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Thu, 2019-06-20 at 16:23 +0900, Chanwoo Choi wrote: > Hi, > > Frankly, I don't like the existing 'DEVFREQ: ' prefix > because it is not used on all error log and it is not necessary. > > Instead of this patch, I just prefer to delete the 'DEVFREQ: ' prefix > Hm, I have to disagree. Having naked pr_{} with just the __func__ reducess logging consistency. Thanks, Ezequiel