[PATCH 1/4] thermal: core: Add helpers to browse the cdev, tz and governor list

[PATCH 1/4] thermal: core: Add helpers to browse the cdev, tz and governor list

[Daniel Lezcano]

The cdev, tz and governor list, as well as their respective locks are
statically defined in the thermal_core.c file.

In order to give a sane access to these list, like browsing all the
thermal zones or all the cooling devices, let's define a set of
helpers where we pass a callback as a parameter to be called for each
thermal entity.

We keep the self-encapsulation and ensure the locks are correctly
taken when looking at the list.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/thermal/thermal_core.c | 51 ++++++++++++++++++++++++++++++++++
 drivers/thermal/thermal_core.h |  9 ++++++
 2 files changed, 60 insertions(+)

diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index a6b8c0240656..54208b6deb42 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -638,6 +638,57 @@ void thermal_zone_device_rebind_exception(struct thermal_zone_device *tz,
 	mutex_unlock(&thermal_list_lock);
 }
 
+int for_each_thermal_governor(int (*cb)(struct thermal_governor *, void *),
+			      void *data)
+{
+	struct thermal_governor *gov;
+	int ret = 0;
+
+	mutex_lock(&thermal_governor_lock);
+	list_for_each_entry(gov, &thermal_governor_list, governor_list) {
+		ret = cb(gov, data);
+		if (ret)
+			break;
+	}
+	mutex_unlock(&thermal_governor_lock);
+
+	return ret;
+}
+
+int for_each_thermal_cooling_device(int (*cb)(struct thermal_cooling_device *,
+					      void *), void *data)
+{
+	struct thermal_cooling_device *cdev;
+	int ret = 0;
+
+	mutex_lock(&thermal_list_lock);
+	list_for_each_entry(cdev, &thermal_cdev_list, node) {
+		ret = cb(cdev, data);
+		if (ret)
+			break;
+	}
+	mutex_unlock(&thermal_list_lock);
+
+	return ret;
+}
+
+int for_each_thermal_zone(int (*cb)(struct thermal_zone_device *, void *),
+			  void *data)
+{
+	struct thermal_zone_device *tz;
+	int ret = 0;
+
+	mutex_lock(&thermal_list_lock);
+	list_for_each_entry(tz, &thermal_tz_list, node) {
+		ret = cb(tz, data);
+		if (ret)
+			break;
+	}
+	mutex_unlock(&thermal_list_lock);
+
+	return ret;
+}
+
 void thermal_zone_device_unbind_exception(struct thermal_zone_device *tz,
 					  const char *cdev_type, size_t size)
 {
diff --git a/drivers/thermal/thermal_core.h b/drivers/thermal/thermal_core.h
index 4e271016b7a9..bb8f8aee79eb 100644
--- a/drivers/thermal/thermal_core.h
+++ b/drivers/thermal/thermal_core.h
@@ -41,6 +41,15 @@ extern struct thermal_governor *__governor_thermal_table_end[];
 	     __governor < __governor_thermal_table_end;	\
 	     __governor++)
 
+int for_each_thermal_zone(int (*cb)(struct thermal_zone_device *, void *),
+			  void *);
+
+int for_each_thermal_cooling_device(int (*cb)(struct thermal_cooling_device *,
+					      void *), void *);
+
+int for_each_thermal_governor(int (*cb)(struct thermal_governor *, void *),
+			      void *thermal_governor);
+
 struct thermal_attr {
 	struct device_attribute attr;
 	char name[THERMAL_NAME_LENGTH];
-- 
2.17.1

[PATCH 2/4] thermal: core: Get thermal zone by id

[Daniel Lezcano]

The next patch will introduce the generic netlink protocol to handle
events, sampling and command from the thermal framework. In order to
deal with the thermal zone, it uses its unique identifier to
characterize it in the message. Passing an integer is more efficient
than passing an entire string.

This change provides a function returning back a thermal zone pointer
corresponding to the identifier passed as parameter.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/thermal/thermal_core.c | 14 ++++++++++++++
 drivers/thermal/thermal_core.h |  2 ++
 2 files changed, 16 insertions(+)

diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index 54208b6deb42..6f7a1a7ffd2a 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -689,6 +689,20 @@ int for_each_thermal_zone(int (*cb)(struct thermal_zone_device *, void *),
 	return ret;
 }
 
+struct thermal_zone_device *thermal_zone_get_by_id(int id)
+{
+	struct thermal_zone_device *tz = NULL;
+
+	mutex_lock(&thermal_list_lock);
+	list_for_each_entry(tz, &thermal_tz_list, node) {
+		if (tz->id == id)
+			break;
+	}
+	mutex_unlock(&thermal_list_lock);
+
+	return tz;
+}
+
 void thermal_zone_device_unbind_exception(struct thermal_zone_device *tz,
 					  const char *cdev_type, size_t size)
 {
diff --git a/drivers/thermal/thermal_core.h b/drivers/thermal/thermal_core.h
index bb8f8aee79eb..7e8f45db6bbf 100644
--- a/drivers/thermal/thermal_core.h
+++ b/drivers/thermal/thermal_core.h
@@ -50,6 +50,8 @@ int for_each_thermal_cooling_device(int (*cb)(struct thermal_cooling_device *,
 int for_each_thermal_governor(int (*cb)(struct thermal_governor *, void *),
 			      void *thermal_governor);
 
+struct thermal_zone_device *thermal_zone_get_by_id(int id);
+
 struct thermal_attr {
 	struct device_attribute attr;
 	char name[THERMAL_NAME_LENGTH];
-- 
2.17.1

[PATCH 3/4] thermal: core: Remove old uapi generic netlink

[Daniel Lezcano]

In order to set the scene for the new generic netlink thermal
management and notifications, let remove the old dead code remaining
in the uapi headers.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 include/linux/thermal.h      |  5 -----
 include/uapi/linux/thermal.h | 12 +-----------
 2 files changed, 1 insertion(+), 16 deletions(-)

diff --git a/include/linux/thermal.h b/include/linux/thermal.h
index faf7ad031e42..fc93a6348082 100644
--- a/include/linux/thermal.h
+++ b/include/linux/thermal.h
@@ -302,11 +302,6 @@ struct thermal_zone_params {
 	int offset;
 };
 
-struct thermal_genl_event {
-	u32 orig;
-	enum events event;
-};
-
 /**
  * struct thermal_zone_of_device_ops - scallbacks for handling DT based zones
  *
diff --git a/include/uapi/linux/thermal.h b/include/uapi/linux/thermal.h
index 96218378dda8..22df67ed9e9c 100644
--- a/include/uapi/linux/thermal.h
+++ b/include/uapi/linux/thermal.h
@@ -6,21 +6,12 @@
 
 /* Adding event notification support elements */
 #define THERMAL_GENL_FAMILY_NAME                "thermal_event"
-#define THERMAL_GENL_VERSION                    0x01
+#define THERMAL_GENL_VERSION                    0x02
 #define THERMAL_GENL_MCAST_GROUP_NAME           "thermal_mc_grp"
 
-/* Events supported by Thermal Netlink */
-enum events {
-	THERMAL_AUX0,
-	THERMAL_AUX1,
-	THERMAL_CRITICAL,
-	THERMAL_DEV_FAULT,
-};
-
 /* attributes of thermal_genl_family */
 enum {
 	THERMAL_GENL_ATTR_UNSPEC,
-	THERMAL_GENL_ATTR_EVENT,
 	__THERMAL_GENL_ATTR_MAX,
 };
 #define THERMAL_GENL_ATTR_MAX (__THERMAL_GENL_ATTR_MAX - 1)
@@ -28,7 +19,6 @@ enum {
 /* commands supported by the thermal_genl_family */
 enum {
 	THERMAL_GENL_CMD_UNSPEC,
-	THERMAL_GENL_CMD_EVENT,
 	__THERMAL_GENL_CMD_MAX,
 };
 #define THERMAL_GENL_CMD_MAX (__THERMAL_GENL_CMD_MAX - 1)
-- 
2.17.1

[PATCH 4/4] thermal: core: genetlink support for events/cmd/sampling

[Daniel Lezcano]

Initially the thermal framework had a very simple notification
mechanism to send generic netlink messages to the userspace.

The notification function was never called from anywhere and the
corresponding dead code was removed. It was probably a first attempt
to introduce the netlink notification.

At LPC2018, the presentation "Linux thermal: User kernel interface",
proposed to create the notifications to the userspace via a kfifo.

The advantage of the kfifo is the performance. It is usually used from
a 1:1 communication channel where a driver captures data and send them
as fast as possible to an userspace process.

The inconvenient is the process uses the notification channel
exclusively, thus no other process is allowed to use the channel to
get temperature or notifications.

The purpose of this series is to provide a fully netlink featured
thermal management.

This patch is defining a generic netlink API to discover the current
thermal setup, get events and temperature sampling. As any genetlink
protocol, it can evolve and the versionning allows to keep the backward
compatibility.

In order to not flood the user with a single channel data, there are
two multicast channels, one for the temperature sampling when the
thermal zone is updated and another one for the events, so the user
can get the events only without the thermal zone temperature
sampling. All these events are from the ones presented at the LPC2018.

Also, a list of commands to discover the thermal setup is given and
can be extended on purpose.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/thermal/Makefile          |   2 +-
 drivers/thermal/thermal_core.h    |  13 +
 drivers/thermal/thermal_netlink.c | 612 ++++++++++++++++++++++++++++++
 include/linux/thermal.h           |  12 -
 include/uapi/linux/thermal.h      |  80 +++-
 5 files changed, 699 insertions(+), 20 deletions(-)
 create mode 100644 drivers/thermal/thermal_netlink.c

diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile
index 8c8ed7b79915..80fddb02cb32 100644
--- a/drivers/thermal/Makefile
+++ b/drivers/thermal/Makefile
@@ -5,7 +5,7 @@
 
 obj-$(CONFIG_THERMAL)		+= thermal_sys.o
 thermal_sys-y			+= thermal_core.o thermal_sysfs.o \
-					thermal_helpers.o
+					thermal_helpers.o thermal_netlink.o
 
 # interface to/from other layers providing sensors
 thermal_sys-$(CONFIG_THERMAL_HWMON)		+= thermal_hwmon.o
diff --git a/drivers/thermal/thermal_core.h b/drivers/thermal/thermal_core.h
index 7e8f45db6bbf..4c98d398c301 100644
--- a/drivers/thermal/thermal_core.h
+++ b/drivers/thermal/thermal_core.h
@@ -52,6 +52,19 @@ int for_each_thermal_governor(int (*cb)(struct thermal_governor *, void *),
 
 struct thermal_zone_device *thermal_zone_get_by_id(int id);
 
+/* Netlink notification function */
+int thermal_notify_tz_create(int tz_id, const char *name);
+int thermal_notify_tz_delete(int tz_id);
+int thermal_notify_tz_enable(int tz_id);
+int thermal_notify_tz_disable(int tz_id);
+int thermal_notify_tz_trip_low(int tz_id, int id);
+int thermal_notify_tz_trip_high(int tz_id, int id);
+int thermal_notify_tz_trip_delete(int tz_id, int id);
+int thermal_notify_tz_trip_add(int tz_id, int id, int type,
+			       int temp, int hyst);
+int thermal_notify_tz_trip_change(int tz_id, int id, int type,
+				  int temp, int hyst);
+
 struct thermal_attr {
 	struct device_attribute attr;
 	char name[THERMAL_NAME_LENGTH];
diff --git a/drivers/thermal/thermal_netlink.c b/drivers/thermal/thermal_netlink.c
new file mode 100644
index 000000000000..a2bce846771e
--- /dev/null
+++ b/drivers/thermal/thermal_netlink.c
@@ -0,0 +1,612 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright 2020 Linaro Limited
+ *
+ * Author: Daniel Lezcano <daniel.lezcano@linaro.org>
+ *
+ * Generic netlink for thermal management framework
+ */
+#include <linux/module.h>
+#include <linux/kernel.h>
+#include <net/genetlink.h>
+#include <uapi/linux/thermal.h>
+
+#include "thermal_core.h"
+
+static const struct genl_multicast_group thermal_genl_mcgrps[] = {
+	{ .name = THERMAL_GENL_SAMPLING_GROUP_NAME, },
+	{ .name = THERMAL_GENL_EVENT_GROUP_NAME,  },
+};
+
+static const struct nla_policy thermal_genl_policy[THERMAL_GENL_ATTR_MAX + 1] = {
+	/* Thermal zone */
+	[THERMAL_GENL_ATTR_TZ]			= { .type = NLA_NESTED },
+	[THERMAL_GENL_ATTR_TZ_ID]		= { .type = NLA_U32 },
+	[THERMAL_GENL_ATTR_TZ_TEMP]		= { .type = NLA_U32 },
+	[THERMAL_GENL_ATTR_TZ_TRIP]		= { .type = NLA_NESTED },
+	[THERMAL_GENL_ATTR_TZ_TRIP_ID]		= { .type = NLA_U32 },
+	[THERMAL_GENL_ATTR_TZ_TRIP_TEMP]	= { .type = NLA_U32 },
+	[THERMAL_GENL_ATTR_TZ_TRIP_TYPE]	= { .type = NLA_U32 },
+	[THERMAL_GENL_ATTR_TZ_TRIP_HYST]	= { .type = NLA_U32 },
+	[THERMAL_GENL_ATTR_TZ_MODE]		= { .type = NLA_U32 },
+	[THERMAL_GENL_ATTR_TZ_CDEV_WEIGHT]	= { .type = NLA_U32 },
+	[THERMAL_GENL_ATTR_TZ_NAME]		= { .type = NLA_STRING,
+						    .len = THERMAL_NAME_LENGTH },
+	/* Governor(s) */
+	[THERMAL_GENL_ATTR_TZ_GOV]		= { .type = NLA_NESTED },
+	[THERMAL_GENL_ATTR_TZ_GOV_NAME]		= { .type = NLA_STRING,
+						    .len = THERMAL_NAME_LENGTH },
+	/* Cooling devices */
+	[THERMAL_GENL_ATTR_CDEV]		= { .type = NLA_NESTED },
+	[THERMAL_GENL_ATTR_CDEV_ID]		= { .type = NLA_U32 },
+	[THERMAL_GENL_ATTR_CDEV_CUR_STATE]	= { .type = NLA_U32 },
+	[THERMAL_GENL_ATTR_CDEV_MAX_STATE]	= { .type = NLA_U32 },
+	[THERMAL_GENL_ATTR_CDEV_MIN_STATE]	= { .type = NLA_U32 },
+	[THERMAL_GENL_ATTR_CDEV_NAME]		= { .type = NLA_STRING,
+						    .len = THERMAL_NAME_LENGTH },
+};
+
+struct param {
+	struct nlattr ** attrs;
+	struct sk_buff *msg;
+	const char *name;
+	int tz_id;
+	int id;
+	int temp;
+	int type;
+	int hyst;
+	int state;
+	int min_state;
+	int max_state;
+};
+
+typedef int (*cb_t)(struct param *);
+
+static struct genl_family thermal_gnl_family;
+
+/************************** Sampling encoding *******************************/
+
+int thermal_genl_sampling_temp(int id, int temp)
+{
+	struct sk_buff *skb;
+	void *hdr;
+
+	skb = genlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL);
+	if (!skb)
+		return -ENOMEM;
+
+	hdr = genlmsg_put(skb, 0, 0, &thermal_gnl_family, 0,
+			  THERMAL_GENL_SAMPLING_TEMP);
+	if (!hdr)
+		return -EMSGSIZE;
+
+	if (nla_put_u32(skb, THERMAL_GENL_ATTR_TZ_ID, id))
+		goto out_cancel;
+
+	if (nla_put_u32(skb, THERMAL_GENL_ATTR_TZ_TEMP, temp))
+		goto out_cancel;
+
+	genlmsg_end(skb, hdr);
+
+	genlmsg_multicast(&thermal_gnl_family, skb, 0, 0, GFP_KERNEL);
+
+	return 0;
+out_cancel:
+	genlmsg_cancel(skb, hdr);
+	nlmsg_free(skb);
+
+	return -EMSGSIZE;
+}
+
+/**************************** Event encoding *********************************/
+
+static int thermal_genl_event_tz_create(struct param *p)
+{
+	if (nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_ID, p->tz_id) ||
+	    nla_put_string(p->msg, THERMAL_GENL_ATTR_TZ_NAME, p->name))
+		return -EMSGSIZE;
+
+	return 0;
+}
+
+static int thermal_genl_event_tz(struct param *p)
+{
+	if (nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_ID, p->tz_id))
+		return -EMSGSIZE;
+
+	return 0;
+}
+
+static int thermal_genl_event_tz_trip_high(struct param *p)
+{
+	if (nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_ID, p->tz_id) ||
+	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_TRIP_ID, p->id))
+		return -EMSGSIZE;
+
+	return 0;
+}
+
+static int thermal_genl_event_tz_trip_add(struct param *p)
+{
+	if (nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_ID, p->tz_id) ||
+	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_TRIP_ID, p->id) ||
+	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_TRIP_TYPE, p->type) ||
+	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_TRIP_TEMP, p->temp) ||
+	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_TRIP_HYST, p->hyst))
+		return -EMSGSIZE;
+
+	return 0;
+}
+
+static int thermal_genl_event_tz_trip_delete(struct param *p)
+{
+	if (nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_ID, p->tz_id) ||
+	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_TRIP_ID, p->id))
+		return -EMSGSIZE;
+
+	return 0;
+}
+
+static int thermal_genl_event_cdev_add(struct param *p)
+{
+	if (nla_put_string(p->msg, THERMAL_GENL_ATTR_CDEV_NAME,
+			   p->name) ||
+	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_CDEV_ID,
+			p->id) ||
+	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_CDEV_MIN_STATE,
+			p->min_state) ||
+	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_CDEV_MAX_STATE,
+			p->max_state))
+		return -EMSGSIZE;
+
+	return 0;
+}
+
+static int thermal_genl_event_cdev_delete(struct param *p)
+{
+	if (nla_put_u32(p->msg, THERMAL_GENL_ATTR_CDEV_ID, p->id))
+		return -EMSGSIZE;
+
+	return 0;
+}
+
+static int thermal_genl_event_cdev_update(struct param *p)
+{
+	if (nla_put_u32(p->msg, THERMAL_GENL_ATTR_CDEV_ID, p->id) ||
+	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_CDEV_CUR_STATE, p->state))
+		return -EMSGSIZE;
+
+	return 0;
+}
+
+static int thermal_genl_event_gov_change(struct param *p)
+{
+	if (nla_put_u32(p->msg, THERMAL_GENL_ATTR_CDEV_ID, p->id) ||
+	    nla_put_string(p->msg, THERMAL_GENL_ATTR_GOV_NAME, p->name))
+		return -EMSGSIZE;
+
+	return 0;
+}
+
+int thermal_genl_event_tz_delete(struct param *p)
+	__attribute__((alias("thermal_genl_event_tz")));
+
+int thermal_genl_event_tz_enable(struct param *p)
+	__attribute__((alias("thermal_genl_event_tz")));
+
+int thermal_genl_event_tz_disable(struct param *p)
+	__attribute__((alias("thermal_genl_event_tz")));
+
+int thermal_genl_event_tz_trip_low(struct param *p)
+	__attribute__((alias("thermal_genl_event_tz_trip_high")));
+
+int thermal_genl_event_tz_trip_change(struct param *)
+	__attribute__((alias("thermal_genl_event_tz_trip_add")));
+
+static cb_t event_cb[] = {
+	[THERMAL_GENL_EVENT_TZ_CREATE]		= thermal_genl_event_tz_create,
+	[THERMAL_GENL_EVENT_TZ_DELETE]		= thermal_genl_event_tz_delete,
+	[THERMAL_GENL_EVENT_TZ_ENABLE]		= thermal_genl_event_tz_enable,
+	[THERMAL_GENL_EVENT_TZ_DISABLE]		= thermal_genl_event_tz_disable,
+	[THERMAL_GENL_EVENT_TZ_TRIP_HIGH]	= thermal_genl_event_tz_trip_high,
+	[THERMAL_GENL_EVENT_TZ_TRIP_LOW]	= thermal_genl_event_tz_trip_low,
+	[THERMAL_GENL_EVENT_TZ_TRIP_CHANGE]	= thermal_genl_event_tz_trip_change,
+	[THERMAL_GENL_EVENT_TZ_TRIP_ADD]	= thermal_genl_event_tz_trip_add,
+	[THERMAL_GENL_EVENT_TZ_TRIP_DELETE]	= thermal_genl_event_tz_trip_delete,
+	[THERMAL_GENL_EVENT_TZ_CDEV_ADD]	= thermal_genl_event_cdev_add,
+	[THERMAL_GENL_EVENT_TZ_CDEV_DELETE]	= thermal_genl_event_cdev_delete,
+	[THERMAL_GENL_EVENT_TZ_CDEV_UPDATE]	= thermal_genl_event_cdev_update,
+	[THERMAL_GENL_EVENT_TZ_GOV_CHANGE]	= thermal_genl_event_gov_change,
+};
+
+/*
+ * Generic netlink event encoding
+ */
+static int thermal_genl_send_event(enum thermal_genl_event event,
+				   struct param *p)
+{
+	struct sk_buff *msg;
+	int ret = -EMSGSIZE;
+	void *hdr;
+
+        msg = genlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL);
+	if (!msg)
+		return -ENOMEM;
+	p->msg = msg;
+
+	hdr = genlmsg_put(msg, 0, 0, &thermal_gnl_family, 0, event);
+	if (!hdr)
+		goto out_free_msg;
+
+	ret = event_cb[event](p);
+	if (ret)
+		goto out_cancel_msg;
+
+	genlmsg_end(msg, hdr);
+
+	genlmsg_multicast(&thermal_gnl_family, msg, 0, 1, GFP_KERNEL);
+
+	return 0;
+
+out_cancel_msg:
+	genlmsg_cancel(msg, hdr);
+out_free_msg:
+	nlmsg_free(msg);
+
+	return ret;
+}
+
+int thermal_notify_tz_create(int tz_id, const char *name)
+{
+	struct param p = { .tz_id = tz_id, .name = name };
+
+	return 	thermal_genl_send_event(THERMAL_GENL_EVENT_TZ_CREATE, &p);
+}
+
+int thermal_notify_tz_delete(int tz_id)
+{
+	struct param p = { .tz_id = tz_id };
+
+	return 	thermal_genl_send_event(THERMAL_GENL_EVENT_TZ_DELETE, &p);
+}
+
+int thermal_notify_tz_enable(int tz_id)
+{
+	struct param p = { .tz_id = tz_id };
+
+	return 	thermal_genl_send_event(THERMAL_GENL_EVENT_TZ_ENABLE, &p);
+}
+
+int thermal_notify_tz_disable(int tz_id)
+{
+	struct param p = { .tz_id = tz_id };
+
+	return 	thermal_genl_send_event(THERMAL_GENL_EVENT_TZ_DISABLE, &p);
+}
+
+int thermal_notify_tz_trip_low(int tz_id, int id)
+{
+	struct param p = { .tz_id = tz_id, .id = id };
+
+	return 	thermal_genl_send_event(THERMAL_GENL_EVENT_TZ_TRIP_LOW, &p);
+}
+
+int thermal_notify_tz_trip_high(int tz_id, int id)
+{
+	struct param p = { .tz_id = tz_id, .id = id };
+
+	return 	thermal_genl_send_event(THERMAL_GENL_EVENT_TZ_TRIP_HIGH, &p);
+}
+
+int thermal_notify_tz_trip_add(int tz_id, int id, int type, int temp, int hyst)
+{
+	struct param p = { .tz_id = tz_id, .id = id, .type = type,
+			   .temp = temp, .hyst = hyst };
+
+	return 	thermal_genl_send_event(THERMAL_GENL_EVENT_TZ_TRIP_ADD, &p);
+}
+
+int thermal_notify_tz_trip_delete(int tz_id, int id)
+{
+	struct param p = { .tz_id = tz_id, .id = id };
+
+	return 	thermal_genl_send_event(THERMAL_GENL_EVENT_TZ_TRIP_DELETE, &p);
+}
+
+int thermal_notify_tz_trip_change(int tz_id, int id, int type, int temp, int hyst)
+{
+	struct param p = { .tz_id = tz_id, .id = id, .type = type,
+			   .temp = temp, .hyst = hyst };
+
+	return 	thermal_genl_send_event(THERMAL_GENL_EVENT_TZ_TRIP_CHANGE, &p);
+}
+
+/*************************** Command encoding ********************************/
+
+static int __thermal_genl_cmd_tz_get(struct thermal_zone_device *tz, void *data)
+{
+	struct sk_buff *msg = data;
+
+	if (nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_ID, tz->id) ||
+	    nla_put_string(msg, THERMAL_GENL_ATTR_TZ_NAME, tz->type))
+		return -EMSGSIZE;
+
+	return 0;
+}
+
+static int thermal_genl_cmd_tz_get(struct param *p)
+{
+	struct sk_buff *msg = p->msg;
+	struct nlattr *start_tz;
+	int ret;
+
+	start_tz = nla_nest_start(msg, THERMAL_GENL_ATTR_TZ);
+	if (!start_tz)
+		return -EMSGSIZE;
+
+	ret = for_each_thermal_zone(__thermal_genl_cmd_tz_get, msg);
+	if (ret)
+		goto out_cancel_nest;
+
+	nla_nest_end(msg, start_tz);
+
+	return 0;
+
+out_cancel_nest:
+	nla_nest_cancel(msg, start_tz);
+
+	return ret;
+}
+
+static int thermal_genl_cmd_tz_get_trip(struct param *p)
+{
+	struct sk_buff *msg = p->msg;
+	struct thermal_zone_device *tz;
+	struct nlattr *start_trip;
+	int i, id;
+
+	if (!p->attrs[THERMAL_GENL_ATTR_TZ_ID])
+		return -EINVAL;
+
+	id = nla_get_u32(p->attrs[THERMAL_GENL_ATTR_TZ_ID]);
+
+	tz = thermal_zone_get_by_id(id);
+	if (!tz)
+		return -EINVAL;
+
+	start_trip = nla_nest_start(msg, THERMAL_GENL_ATTR_TZ_TRIP);
+	if (!start_trip)
+		return -EMSGSIZE;
+
+	mutex_lock(&tz->lock);
+
+	for (i = 0; i < tz->trips; i++) {
+
+		enum thermal_trip_type type;
+		int temp, hyst;
+
+		tz->ops->get_trip_type(tz, i, &type);
+		tz->ops->get_trip_temp(tz, i, &temp);
+		tz->ops->get_trip_hyst(tz, i, &hyst);
+
+		if (nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_TRIP_ID, i) ||
+		    nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_TRIP_TYPE, type) ||
+		    nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_TRIP_TEMP, temp) ||
+		    nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_TRIP_HYST, hyst))
+			goto out_cancel_nest;
+	}
+
+	mutex_unlock(&tz->lock);
+
+	nla_nest_end(msg, start_trip);
+
+	return 0;
+
+out_cancel_nest:
+	mutex_unlock(&tz->lock);
+
+	return -EMSGSIZE;
+}
+
+static int thermal_genl_cmd_tz_get_temp(struct param *p)
+{
+	struct sk_buff *msg = p->msg;
+	struct thermal_zone_device *tz;
+	int temp, ret, id;
+
+	if (!p->attrs[THERMAL_GENL_ATTR_TZ_ID])
+		return -EINVAL;
+
+	id = nla_get_u32(p->attrs[THERMAL_GENL_ATTR_TZ_ID]);
+
+	tz = thermal_zone_get_by_id(id);
+	if (!tz)
+		return -EINVAL;
+
+	ret = thermal_zone_get_temp(tz, &temp);
+	if (ret)
+		return ret;
+
+	if (nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_ID, id) ||
+	    nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_TEMP, temp))
+		return -EMSGSIZE;
+
+	return 0;
+}
+
+static int thermal_genl_cmd_tz_get_gov(struct param *p)
+{
+	struct sk_buff *msg = p->msg;
+	struct thermal_zone_device *tz;
+	int id, ret = 0;
+
+	if (!p->attrs[THERMAL_GENL_ATTR_TZ_ID])
+		return -EINVAL;
+
+	id = nla_get_u32(p->attrs[THERMAL_GENL_ATTR_TZ_ID]);
+
+	tz = thermal_zone_get_by_id(id);
+	if (!tz)
+		return -EINVAL;
+
+	mutex_lock(&tz->lock);
+
+	if (nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_ID, id) ||
+	    nla_put_string(msg, THERMAL_GENL_ATTR_TZ_GOV_NAME,
+			   tz->governor->name))
+		ret = -EMSGSIZE;
+
+	mutex_unlock(&tz->lock);
+
+	return ret;
+}
+
+static int __thermal_genl_cmd_cdev_get(struct thermal_cooling_device *cdev,
+				       void *data)
+{
+	struct sk_buff *msg = data;
+
+	if (nla_put_u32(msg, THERMAL_GENL_ATTR_CDEV_ID, cdev->id))
+		return -EMSGSIZE;
+
+	if (nla_put_string(msg, THERMAL_GENL_ATTR_CDEV_NAME, cdev->type))
+		return -EMSGSIZE;
+
+	return 0;
+}
+
+static int thermal_genl_cmd_cdev_get(struct param *p)
+{
+	struct sk_buff *msg = p->msg;
+	struct nlattr *start_cdev;
+	int ret;
+
+	start_cdev = nla_nest_start(msg, THERMAL_GENL_ATTR_CDEV);
+	if (!start_cdev)
+		return -EMSGSIZE;
+
+	ret = for_each_thermal_cooling_device(__thermal_genl_cmd_cdev_get, msg);
+	if (ret)
+		goto out_cancel_nest;
+
+	nla_nest_end(msg, start_cdev);
+
+	return 0;
+out_cancel_nest:
+	nla_nest_cancel(msg, start_cdev);
+
+	return ret;
+}
+
+static cb_t cmd_cb[] = {
+	[THERMAL_GENL_CMD_TZ_GET]	= thermal_genl_cmd_tz_get,
+	[THERMAL_GENL_CMD_TZ_GET_TRIP]	= thermal_genl_cmd_tz_get_trip,
+	[THERMAL_GENL_CMD_TZ_GET_TEMP]	= thermal_genl_cmd_tz_get_temp,
+	[THERMAL_GENL_CMD_TZ_GET_GOV]	= thermal_genl_cmd_tz_get_gov,
+	[THERMAL_GENL_CMD_CDEV_GET]	= thermal_genl_cmd_cdev_get,
+};
+
+int thermal_genl_cmd_dumpit(struct sk_buff *skb, struct netlink_callback *cb)
+{
+	struct param p = { .msg = skb };
+	const struct genl_dumpit_info *info = genl_dumpit_info(cb);
+	int cmd = info->ops->cmd;
+	int ret = -EMSGSIZE;
+	void *hdr;
+
+	hdr = genlmsg_put(skb, 0, 0, &thermal_gnl_family, 0, cmd);
+	if (!hdr)
+		return -EMSGSIZE;
+
+	ret = cmd_cb[cmd](&p);
+	if (ret)
+		goto out_cancel_msg;
+
+	genlmsg_end(skb, hdr);
+
+	return 0;
+
+out_cancel_msg:
+	genlmsg_cancel(skb, hdr);
+
+	return ret;
+}
+
+int thermal_genl_cmd_doit(struct sk_buff *skb, struct genl_info *info)
+{
+	struct param p = { .attrs = info->attrs };
+	struct sk_buff *msg;
+	void *hdr;
+	int cmd = info->genlhdr->cmd;
+	int ret = -EMSGSIZE;
+
+        msg = genlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL);
+	if (!msg)
+		return -ENOMEM;
+	p.msg = msg;
+
+        hdr = genlmsg_put_reply(msg, info, &thermal_gnl_family, 0, cmd);
+	if (!hdr)
+		goto out_free_msg;
+
+	ret = cmd_cb[cmd](&p);
+	if (ret)
+		goto out_cancel_msg;
+
+	genlmsg_end(msg, hdr);
+
+	return genlmsg_reply(msg, info);
+
+out_cancel_msg:
+	genlmsg_cancel(msg, hdr);
+out_free_msg:
+	nlmsg_free(msg);
+
+	return ret;
+}
+
+static const struct genl_ops thermal_genl_ops[] = {
+	{
+		.cmd = THERMAL_GENL_CMD_TZ_GET,
+		.validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,
+		.dumpit = thermal_genl_cmd_dumpit,
+	},
+	{
+		.cmd = THERMAL_GENL_CMD_TZ_GET_TRIP,
+		.validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,
+		.doit = thermal_genl_cmd_doit,
+	},
+	{
+		.cmd = THERMAL_GENL_CMD_TZ_GET_TEMP,
+		.validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,
+		.doit = thermal_genl_cmd_doit,
+	},
+	{
+		.cmd = THERMAL_GENL_CMD_TZ_GET_GOV,
+		.validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,
+		.doit = thermal_genl_cmd_doit,
+	},
+	{
+		.cmd = THERMAL_GENL_CMD_CDEV_GET,
+		.validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,
+		.dumpit = thermal_genl_cmd_dumpit,
+	},
+};
+
+static struct genl_family thermal_gnl_family __ro_after_init = {
+	.hdrsize	= 0,
+	.name		= THERMAL_GENL_FAMILY_NAME,
+	.version	= THERMAL_GENL_VERSION,
+	.maxattr	= THERMAL_GENL_ATTR_MAX,
+	.policy		= thermal_genl_policy,
+	.ops		= thermal_genl_ops,
+	.n_ops 		= ARRAY_SIZE(thermal_genl_ops),
+	.mcgrps		= thermal_genl_mcgrps,
+	.n_mcgrps	= ARRAY_SIZE(thermal_genl_mcgrps),
+};
+
+static int __init thermal_netlink_init(void)
+{
+	return genl_register_family(&thermal_gnl_family);
+}
+core_initcall(thermal_netlink_init);
diff --git a/include/linux/thermal.h b/include/linux/thermal.h
index fc93a6348082..d92643e310e2 100644
--- a/include/linux/thermal.h
+++ b/include/linux/thermal.h
@@ -37,18 +37,6 @@ struct thermal_cooling_device;
 struct thermal_instance;
 struct thermal_attr;
 
-enum thermal_device_mode {
-	THERMAL_DEVICE_DISABLED = 0,
-	THERMAL_DEVICE_ENABLED,
-};
-
-enum thermal_trip_type {
-	THERMAL_TRIP_ACTIVE = 0,
-	THERMAL_TRIP_PASSIVE,
-	THERMAL_TRIP_HOT,
-	THERMAL_TRIP_CRITICAL,
-};
-
 enum thermal_trend {
 	THERMAL_TREND_STABLE, /* temperature is stable */
 	THERMAL_TREND_RAISING, /* temperature is raising */
diff --git a/include/uapi/linux/thermal.h b/include/uapi/linux/thermal.h
index 22df67ed9e9c..3ee7515c7aea 100644
--- a/include/uapi/linux/thermal.h
+++ b/include/uapi/linux/thermal.h
@@ -4,21 +4,87 @@
 
 #define THERMAL_NAME_LENGTH	20
 
+enum thermal_device_mode {
+	THERMAL_DEVICE_DISABLED = 0,
+	THERMAL_DEVICE_ENABLED,
+};
+
+enum thermal_trip_type {
+	THERMAL_TRIP_ACTIVE = 0,
+	THERMAL_TRIP_PASSIVE,
+	THERMAL_TRIP_HOT,
+	THERMAL_TRIP_CRITICAL,
+};
+
 /* Adding event notification support elements */
-#define THERMAL_GENL_FAMILY_NAME                "thermal_event"
-#define THERMAL_GENL_VERSION                    0x02
-#define THERMAL_GENL_MCAST_GROUP_NAME           "thermal_mc_grp"
+#define THERMAL_GENL_FAMILY_NAME		"thermal"
+#define THERMAL_GENL_VERSION			0x01
+#define THERMAL_GENL_SAMPLING_GROUP_NAME	"sampling"
+#define THERMAL_GENL_EVENT_GROUP_NAME		"event"
 
-/* attributes of thermal_genl_family */
-enum {
+/* Attributes of thermal_genl_family */
+enum thermal_genl_attr {
 	THERMAL_GENL_ATTR_UNSPEC,
+	THERMAL_GENL_ATTR_TZ,
+	THERMAL_GENL_ATTR_TZ_ID,
+	THERMAL_GENL_ATTR_TZ_TEMP,
+	THERMAL_GENL_ATTR_TZ_TRIP,
+	THERMAL_GENL_ATTR_TZ_TRIP_ID,
+	THERMAL_GENL_ATTR_TZ_TRIP_TYPE,
+	THERMAL_GENL_ATTR_TZ_TRIP_TEMP,
+	THERMAL_GENL_ATTR_TZ_TRIP_HYST,
+	THERMAL_GENL_ATTR_TZ_MODE,
+	THERMAL_GENL_ATTR_TZ_NAME,
+	THERMAL_GENL_ATTR_TZ_CDEV_WEIGHT,
+	THERMAL_GENL_ATTR_TZ_GOV,
+	THERMAL_GENL_ATTR_TZ_GOV_NAME,
+	THERMAL_GENL_ATTR_CDEV,
+	THERMAL_GENL_ATTR_CDEV_ID,
+	THERMAL_GENL_ATTR_CDEV_CUR_STATE,
+	THERMAL_GENL_ATTR_CDEV_MAX_STATE,
+	THERMAL_GENL_ATTR_CDEV_MIN_STATE,
+	THERMAL_GENL_ATTR_CDEV_NAME,
+	THERMAL_GENL_ATTR_GOV_NAME,
+
 	__THERMAL_GENL_ATTR_MAX,
 };
 #define THERMAL_GENL_ATTR_MAX (__THERMAL_GENL_ATTR_MAX - 1)
 
-/* commands supported by the thermal_genl_family */
-enum {
+enum thermal_genl_sampling {
+	THERMAL_GENL_SAMPLING_TEMP,
+	__THERMAL_GENL_SAMPLING_MAX,
+};
+#define THERMAL_GENL_SAMPLING_MAX (__THERMAL_GENL_SAMPLING_MAX - 1)
+
+/* Events of thermal_genl_family */
+enum thermal_genl_event {
+	THERMAL_GENL_EVENT_UNSPEC,
+	THERMAL_GENL_EVENT_TZ_CREATE,		/* Thermal zone creation */
+	THERMAL_GENL_EVENT_TZ_DELETE,		/* Thermal zone deletion */
+	THERMAL_GENL_EVENT_TZ_DISABLE,		/* Thermal zone disabed */
+	THERMAL_GENL_EVENT_TZ_ENABLE,		/* Thermal zone enabled */
+	THERMAL_GENL_EVENT_TZ_TRIP_HIGH,	/* Trip point crossed the way up */
+	THERMAL_GENL_EVENT_TZ_TRIP_LOW,		/* Trip point crossed the way down */
+	THERMAL_GENL_EVENT_TZ_TRIP_CHANGE,	/* Trip point changed */
+	THERMAL_GENL_EVENT_TZ_TRIP_ADD,		/* Trip point added */
+	THERMAL_GENL_EVENT_TZ_TRIP_DELETE,	/* Trip point deleted */
+	THERMAL_GENL_EVENT_TZ_CDEV_ADD,		/* Cdev bound to the thermal zone */
+	THERMAL_GENL_EVENT_TZ_CDEV_DELETE,	/* Cdev unbound */
+	THERMAL_GENL_EVENT_TZ_CDEV_UPDATE,	/* Cdev state updated */
+	THERMAL_GENL_EVENT_TZ_GOV_CHANGE,	/* Governor policy changed  */
+	__THERMAL_GENL_EVENT_MAX,
+};
+#define THERMAL_GENL_EVENT_MAX (__THERMAL_GENL_EVENT_MAX - 1)
+
+/* Commands supported by the thermal_genl_family */
+enum thermal_genl_cmd {
 	THERMAL_GENL_CMD_UNSPEC,
+	THERMAL_GENL_CMD_TZ_GET,	/* List thermal zones id */
+	THERMAL_GENL_CMD_TZ_GET_TRIP,	/* List of thermal trips */
+	THERMAL_GENL_CMD_TZ_GET_TEMP,	/* Get the thermal zone temperature */
+	THERMAL_GENL_CMD_TZ_GET_GOV,	/* Get the thermal zone governor */
+	THERMAL_GENL_CMD_TZ_GET_MODE,	/* Get the thermal zone mode */
+	THERMAL_GENL_CMD_CDEV_GET,	/* List of cdev id */
 	__THERMAL_GENL_CMD_MAX,
 };
 #define THERMAL_GENL_CMD_MAX (__THERMAL_GENL_CMD_MAX - 1)
-- 
2.17.1

Re: [PATCH 4/4] thermal: core: genetlink support for events/cmd/sampling

[Srinivas Pandruvada]

On Fri, 2020-05-15 at 16:10 +0200, Daniel Lezcano wrote:
> Initially the thermal framework had a very simple notification
> mechanism to send generic netlink messages to the userspace.
> 
> The notification function was never called from anywhere and the
> corresponding dead code was removed. It was probably a first attempt
> to introduce the netlink notification.
> 
> At LPC2018, the presentation "Linux thermal: User kernel interface",
> proposed to create the notifications to the userspace via a kfifo.
> 
> The advantage of the kfifo is the performance. It is usually used
> from
> a 1:1 communication channel where a driver captures data and send
> them
> as fast as possible to an userspace process.
Shall I submit my RFC using KFifo on top of this series? Any
objections?

Thanks,
Srinivas

> The inconvenient is the process uses the notification channel
> exclusively, thus no other process is allowed to use the channel to
> get temperature or notifications.
> 
> The purpose of this series is to provide a fully netlink featured
> thermal management.
> 
> This patch is defining a generic netlink API to discover the current
> thermal setup, get events and temperature sampling. As any genetlink
> protocol, it can evolve and the versionning allows to keep the
> backward
> compatibility.
> 
> In order to not flood the user with a single channel data, there are
> two multicast channels, one for the temperature sampling when the
> thermal zone is updated and another one for the events, so the user
> can get the events only without the thermal zone temperature
> sampling. All these events are from the ones presented at the
> LPC2018.
> 
> Also, a list of commands to discover the thermal setup is given and
> can be extended on purpose.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
>  drivers/thermal/Makefile          |   2 +-
>  drivers/thermal/thermal_core.h    |  13 +
>  drivers/thermal/thermal_netlink.c | 612
> ++++++++++++++++++++++++++++++
>  include/linux/thermal.h           |  12 -
>  include/uapi/linux/thermal.h      |  80 +++-
>  5 files changed, 699 insertions(+), 20 deletions(-)
>  create mode 100644 drivers/thermal/thermal_netlink.c
> 
> diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile
> index 8c8ed7b79915..80fddb02cb32 100644
> --- a/drivers/thermal/Makefile
> +++ b/drivers/thermal/Makefile
> @@ -5,7 +5,7 @@
>  
>  obj-$(CONFIG_THERMAL)		+= thermal_sys.o
>  thermal_sys-y			+= thermal_core.o
> thermal_sysfs.o \
> -					thermal_helpers.o
> +					thermal_helpers.o
> thermal_netlink.o
>  
>  # interface to/from other layers providing sensors
>  thermal_sys-$(CONFIG_THERMAL_HWMON)		+= thermal_hwmon.o
> diff --git a/drivers/thermal/thermal_core.h
> b/drivers/thermal/thermal_core.h
> index 7e8f45db6bbf..4c98d398c301 100644
> --- a/drivers/thermal/thermal_core.h
> +++ b/drivers/thermal/thermal_core.h
> @@ -52,6 +52,19 @@ int for_each_thermal_governor(int (*cb)(struct
> thermal_governor *, void *),
>  
>  struct thermal_zone_device *thermal_zone_get_by_id(int id);
>  
> +/* Netlink notification function */
> +int thermal_notify_tz_create(int tz_id, const char *name);
> +int thermal_notify_tz_delete(int tz_id);
> +int thermal_notify_tz_enable(int tz_id);
> +int thermal_notify_tz_disable(int tz_id);
> +int thermal_notify_tz_trip_low(int tz_id, int id);
> +int thermal_notify_tz_trip_high(int tz_id, int id);
> +int thermal_notify_tz_trip_delete(int tz_id, int id);
> +int thermal_notify_tz_trip_add(int tz_id, int id, int type,
> +			       int temp, int hyst);
> +int thermal_notify_tz_trip_change(int tz_id, int id, int type,
> +				  int temp, int hyst);
> +
>  struct thermal_attr {
>  	struct device_attribute attr;
>  	char name[THERMAL_NAME_LENGTH];
> diff --git a/drivers/thermal/thermal_netlink.c
> b/drivers/thermal/thermal_netlink.c
> new file mode 100644
> index 000000000000..a2bce846771e
> --- /dev/null
> +++ b/drivers/thermal/thermal_netlink.c
> @@ -0,0 +1,612 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright 2020 Linaro Limited
> + *
> + * Author: Daniel Lezcano <daniel.lezcano@linaro.org>
> + *
> + * Generic netlink for thermal management framework
> + */
> +#include <linux/module.h>
> +#include <linux/kernel.h>
> +#include <net/genetlink.h>
> +#include <uapi/linux/thermal.h>
> +
> +#include "thermal_core.h"
> +
> +static const struct genl_multicast_group thermal_genl_mcgrps[] = {
> +	{ .name = THERMAL_GENL_SAMPLING_GROUP_NAME, },
> +	{ .name = THERMAL_GENL_EVENT_GROUP_NAME,  },
> +};
> +
> +static const struct nla_policy
> thermal_genl_policy[THERMAL_GENL_ATTR_MAX + 1] = {
> +	/* Thermal zone */
> +	[THERMAL_GENL_ATTR_TZ]			= { .type =
> NLA_NESTED },
> +	[THERMAL_GENL_ATTR_TZ_ID]		= { .type = NLA_U32 },
> +	[THERMAL_GENL_ATTR_TZ_TEMP]		= { .type = NLA_U32
> },
> +	[THERMAL_GENL_ATTR_TZ_TRIP]		= { .type =
> NLA_NESTED },
> +	[THERMAL_GENL_ATTR_TZ_TRIP_ID]		= { .type = NLA_U32
> },
> +	[THERMAL_GENL_ATTR_TZ_TRIP_TEMP]	= { .type = NLA_U32 },
> +	[THERMAL_GENL_ATTR_TZ_TRIP_TYPE]	= { .type = NLA_U32 },
> +	[THERMAL_GENL_ATTR_TZ_TRIP_HYST]	= { .type = NLA_U32 },
> +	[THERMAL_GENL_ATTR_TZ_MODE]		= { .type = NLA_U32
> },
> +	[THERMAL_GENL_ATTR_TZ_CDEV_WEIGHT]	= { .type = NLA_U32
> },
> +	[THERMAL_GENL_ATTR_TZ_NAME]		= { .type =
> NLA_STRING,
> +						    .len =
> THERMAL_NAME_LENGTH },
> +	/* Governor(s) */
> +	[THERMAL_GENL_ATTR_TZ_GOV]		= { .type =
> NLA_NESTED },
> +	[THERMAL_GENL_ATTR_TZ_GOV_NAME]		= { .type =
> NLA_STRING,
> +						    .len =
> THERMAL_NAME_LENGTH },
> +	/* Cooling devices */
> +	[THERMAL_GENL_ATTR_CDEV]		= { .type = NLA_NESTED },
> +	[THERMAL_GENL_ATTR_CDEV_ID]		= { .type = NLA_U32
> },
> +	[THERMAL_GENL_ATTR_CDEV_CUR_STATE]	= { .type = NLA_U32
> },
> +	[THERMAL_GENL_ATTR_CDEV_MAX_STATE]	= { .type = NLA_U32
> },
> +	[THERMAL_GENL_ATTR_CDEV_MIN_STATE]	= { .type = NLA_U32
> },
> +	[THERMAL_GENL_ATTR_CDEV_NAME]		= { .type =
> NLA_STRING,
> +						    .len =
> THERMAL_NAME_LENGTH },
> +};
> +
> +struct param {
> +	struct nlattr ** attrs;
> +	struct sk_buff *msg;
> +	const char *name;
> +	int tz_id;
> +	int id;
> +	int temp;
> +	int type;
> +	int hyst;
> +	int state;
> +	int min_state;
> +	int max_state;
> +};
> +
> +typedef int (*cb_t)(struct param *);
> +
> +static struct genl_family thermal_gnl_family;
> +
> +/************************** Sampling encoding
> *******************************/
> +
> +int thermal_genl_sampling_temp(int id, int temp)
> +{
> +	struct sk_buff *skb;
> +	void *hdr;
> +
> +	skb = genlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL);
> +	if (!skb)
> +		return -ENOMEM;
> +
> +	hdr = genlmsg_put(skb, 0, 0, &thermal_gnl_family, 0,
> +			  THERMAL_GENL_SAMPLING_TEMP);
> +	if (!hdr)
> +		return -EMSGSIZE;
> +
> +	if (nla_put_u32(skb, THERMAL_GENL_ATTR_TZ_ID, id))
> +		goto out_cancel;
> +
> +	if (nla_put_u32(skb, THERMAL_GENL_ATTR_TZ_TEMP, temp))
> +		goto out_cancel;
> +
> +	genlmsg_end(skb, hdr);
> +
> +	genlmsg_multicast(&thermal_gnl_family, skb, 0, 0, GFP_KERNEL);
> +
> +	return 0;
> +out_cancel:
> +	genlmsg_cancel(skb, hdr);
> +	nlmsg_free(skb);
> +
> +	return -EMSGSIZE;
> +}
> +
> +/**************************** Event encoding
> *********************************/
> +
> +static int thermal_genl_event_tz_create(struct param *p)
> +{
> +	if (nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_ID, p->tz_id) ||
> +	    nla_put_string(p->msg, THERMAL_GENL_ATTR_TZ_NAME, p->name))
> +		return -EMSGSIZE;
> +
> +	return 0;
> +}
> +
> +static int thermal_genl_event_tz(struct param *p)
> +{
> +	if (nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_ID, p->tz_id))
> +		return -EMSGSIZE;
> +
> +	return 0;
> +}
> +
> +static int thermal_genl_event_tz_trip_high(struct param *p)
> +{
> +	if (nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_ID, p->tz_id) ||
> +	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_TRIP_ID, p->id))
> +		return -EMSGSIZE;
> +
> +	return 0;
> +}
> +
> +static int thermal_genl_event_tz_trip_add(struct param *p)
> +{
> +	if (nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_ID, p->tz_id) ||
> +	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_TRIP_ID, p->id) ||
> +	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_TRIP_TYPE, p-
> > type) ||
> +	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_TRIP_TEMP, p-
> > temp) ||
> +	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_TRIP_HYST, p-
> > hyst))
> +		return -EMSGSIZE;
> +
> +	return 0;
> +}
> +
> +static int thermal_genl_event_tz_trip_delete(struct param *p)
> +{
> +	if (nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_ID, p->tz_id) ||
> +	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_TRIP_ID, p->id))
> +		return -EMSGSIZE;
> +
> +	return 0;
> +}
> +
> +static int thermal_genl_event_cdev_add(struct param *p)
> +{
> +	if (nla_put_string(p->msg, THERMAL_GENL_ATTR_CDEV_NAME,
> +			   p->name) ||
> +	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_CDEV_ID,
> +			p->id) ||
> +	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_CDEV_MIN_STATE,
> +			p->min_state) ||
> +	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_CDEV_MAX_STATE,
> +			p->max_state))
> +		return -EMSGSIZE;
> +
> +	return 0;
> +}
> +
> +static int thermal_genl_event_cdev_delete(struct param *p)
> +{
> +	if (nla_put_u32(p->msg, THERMAL_GENL_ATTR_CDEV_ID, p->id))
> +		return -EMSGSIZE;
> +
> +	return 0;
> +}
> +
> +static int thermal_genl_event_cdev_update(struct param *p)
> +{
> +	if (nla_put_u32(p->msg, THERMAL_GENL_ATTR_CDEV_ID, p->id) ||
> +	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_CDEV_CUR_STATE, p-
> > state))
> +		return -EMSGSIZE;
> +
> +	return 0;
> +}
> +
> +static int thermal_genl_event_gov_change(struct param *p)
> +{
> +	if (nla_put_u32(p->msg, THERMAL_GENL_ATTR_CDEV_ID, p->id) ||
> +	    nla_put_string(p->msg, THERMAL_GENL_ATTR_GOV_NAME, p-
> > name))
> +		return -EMSGSIZE;
> +
> +	return 0;
> +}
> +
> +int thermal_genl_event_tz_delete(struct param *p)
> +	__attribute__((alias("thermal_genl_event_tz")));
> +
> +int thermal_genl_event_tz_enable(struct param *p)
> +	__attribute__((alias("thermal_genl_event_tz")));
> +
> +int thermal_genl_event_tz_disable(struct param *p)
> +	__attribute__((alias("thermal_genl_event_tz")));
> +
> +int thermal_genl_event_tz_trip_low(struct param *p)
> +	__attribute__((alias("thermal_genl_event_tz_trip_high")));
> +
> +int thermal_genl_event_tz_trip_change(struct param *)
> +	__attribute__((alias("thermal_genl_event_tz_trip_add")));
> +
> +static cb_t event_cb[] = {
> +	[THERMAL_GENL_EVENT_TZ_CREATE]		=
> thermal_genl_event_tz_create,
> +	[THERMAL_GENL_EVENT_TZ_DELETE]		=
> thermal_genl_event_tz_delete,
> +	[THERMAL_GENL_EVENT_TZ_ENABLE]		=
> thermal_genl_event_tz_enable,
> +	[THERMAL_GENL_EVENT_TZ_DISABLE]		=
> thermal_genl_event_tz_disable,
> +	[THERMAL_GENL_EVENT_TZ_TRIP_HIGH]	=
> thermal_genl_event_tz_trip_high,
> +	[THERMAL_GENL_EVENT_TZ_TRIP_LOW]	=
> thermal_genl_event_tz_trip_low,
> +	[THERMAL_GENL_EVENT_TZ_TRIP_CHANGE]	=
> thermal_genl_event_tz_trip_change,
> +	[THERMAL_GENL_EVENT_TZ_TRIP_ADD]	=
> thermal_genl_event_tz_trip_add,
> +	[THERMAL_GENL_EVENT_TZ_TRIP_DELETE]	=
> thermal_genl_event_tz_trip_delete,
> +	[THERMAL_GENL_EVENT_TZ_CDEV_ADD]	=
> thermal_genl_event_cdev_add,
> +	[THERMAL_GENL_EVENT_TZ_CDEV_DELETE]	=
> thermal_genl_event_cdev_delete,
> +	[THERMAL_GENL_EVENT_TZ_CDEV_UPDATE]	=
> thermal_genl_event_cdev_update,
> +	[THERMAL_GENL_EVENT_TZ_GOV_CHANGE]	=
> thermal_genl_event_gov_change,
> +};
> +
> +/*
> + * Generic netlink event encoding
> + */
> +static int thermal_genl_send_event(enum thermal_genl_event event,
> +				   struct param *p)
> +{
> +	struct sk_buff *msg;
> +	int ret = -EMSGSIZE;
> +	void *hdr;
> +
> +        msg = genlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL);
> +	if (!msg)
> +		return -ENOMEM;
> +	p->msg = msg;
> +
> +	hdr = genlmsg_put(msg, 0, 0, &thermal_gnl_family, 0, event);
> +	if (!hdr)
> +		goto out_free_msg;
> +
> +	ret = event_cb[event](p);
> +	if (ret)
> +		goto out_cancel_msg;
> +
> +	genlmsg_end(msg, hdr);
> +
> +	genlmsg_multicast(&thermal_gnl_family, msg, 0, 1, GFP_KERNEL);
> +
> +	return 0;
> +
> +out_cancel_msg:
> +	genlmsg_cancel(msg, hdr);
> +out_free_msg:
> +	nlmsg_free(msg);
> +
> +	return ret;
> +}
> +
> +int thermal_notify_tz_create(int tz_id, const char *name)
> +{
> +	struct param p = { .tz_id = tz_id, .name = name };
> +
> +	return 	thermal_genl_send_event(THERMAL_GENL_EVENT_TZ_CREATE,
> &p);
> +}
> +
> +int thermal_notify_tz_delete(int tz_id)
> +{
> +	struct param p = { .tz_id = tz_id };
> +
> +	return 	thermal_genl_send_event(THERMAL_GENL_EVENT_TZ_DELETE,
> &p);
> +}
> +
> +int thermal_notify_tz_enable(int tz_id)
> +{
> +	struct param p = { .tz_id = tz_id };
> +
> +	return 	thermal_genl_send_event(THERMAL_GENL_EVENT_TZ_ENABLE,
> &p);
> +}
> +
> +int thermal_notify_tz_disable(int tz_id)
> +{
> +	struct param p = { .tz_id = tz_id };
> +
> +	return 	thermal_genl_send_event(THERMAL_GENL_EVENT_TZ_DISABLE
> , &p);
> +}
> +
> +int thermal_notify_tz_trip_low(int tz_id, int id)
> +{
> +	struct param p = { .tz_id = tz_id, .id = id };
> +
> +	return 	thermal_genl_send_event(THERMAL_GENL_EVENT_TZ_TRIP_LO
> W, &p);
> +}
> +
> +int thermal_notify_tz_trip_high(int tz_id, int id)
> +{
> +	struct param p = { .tz_id = tz_id, .id = id };
> +
> +	return 	thermal_genl_send_event(THERMAL_GENL_EVENT_TZ_TRIP_HI
> GH, &p);
> +}
> +
> +int thermal_notify_tz_trip_add(int tz_id, int id, int type, int
> temp, int hyst)
> +{
> +	struct param p = { .tz_id = tz_id, .id = id, .type = type,
> +			   .temp = temp, .hyst = hyst };
> +
> +	return 	thermal_genl_send_event(THERMAL_GENL_EVENT_TZ_TRIP_AD
> D, &p);
> +}
> +
> +int thermal_notify_tz_trip_delete(int tz_id, int id)
> +{
> +	struct param p = { .tz_id = tz_id, .id = id };
> +
> +	return 	thermal_genl_send_event(THERMAL_GENL_EVENT_TZ_TRIP_DE
> LETE, &p);
> +}
> +
> +int thermal_notify_tz_trip_change(int tz_id, int id, int type, int
> temp, int hyst)
> +{
> +	struct param p = { .tz_id = tz_id, .id = id, .type = type,
> +			   .temp = temp, .hyst = hyst };
> +
> +	return 	thermal_genl_send_event(THERMAL_GENL_EVENT_TZ_TRIP_CH
> ANGE, &p);
> +}
> +
> +/*************************** Command encoding
> ********************************/
> +
> +static int __thermal_genl_cmd_tz_get(struct thermal_zone_device *tz,
> void *data)
> +{
> +	struct sk_buff *msg = data;
> +
> +	if (nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_ID, tz->id) ||
> +	    nla_put_string(msg, THERMAL_GENL_ATTR_TZ_NAME, tz->type))
> +		return -EMSGSIZE;
> +
> +	return 0;
> +}
> +
> +static int thermal_genl_cmd_tz_get(struct param *p)
> +{
> +	struct sk_buff *msg = p->msg;
> +	struct nlattr *start_tz;
> +	int ret;
> +
> +	start_tz = nla_nest_start(msg, THERMAL_GENL_ATTR_TZ);
> +	if (!start_tz)
> +		return -EMSGSIZE;
> +
> +	ret = for_each_thermal_zone(__thermal_genl_cmd_tz_get, msg);
> +	if (ret)
> +		goto out_cancel_nest;
> +
> +	nla_nest_end(msg, start_tz);
> +
> +	return 0;
> +
> +out_cancel_nest:
> +	nla_nest_cancel(msg, start_tz);
> +
> +	return ret;
> +}
> +
> +static int thermal_genl_cmd_tz_get_trip(struct param *p)
> +{
> +	struct sk_buff *msg = p->msg;
> +	struct thermal_zone_device *tz;
> +	struct nlattr *start_trip;
> +	int i, id;
> +
> +	if (!p->attrs[THERMAL_GENL_ATTR_TZ_ID])
> +		return -EINVAL;
> +
> +	id = nla_get_u32(p->attrs[THERMAL_GENL_ATTR_TZ_ID]);
> +
> +	tz = thermal_zone_get_by_id(id);
> +	if (!tz)
> +		return -EINVAL;
> +
> +	start_trip = nla_nest_start(msg, THERMAL_GENL_ATTR_TZ_TRIP);
> +	if (!start_trip)
> +		return -EMSGSIZE;
> +
> +	mutex_lock(&tz->lock);
> +
> +	for (i = 0; i < tz->trips; i++) {
> +
> +		enum thermal_trip_type type;
> +		int temp, hyst;
> +
> +		tz->ops->get_trip_type(tz, i, &type);
> +		tz->ops->get_trip_temp(tz, i, &temp);
> +		tz->ops->get_trip_hyst(tz, i, &hyst);
> +
> +		if (nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_TRIP_ID, i)
> +		    nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_TRIP_TYPE,
> type) ||
> +		    nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_TRIP_TEMP,
> temp) ||
> +		    nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_TRIP_HYST,
> hyst))
> +			goto out_cancel_nest;
> +	}
> +
> +	mutex_unlock(&tz->lock);
> +
> +	nla_nest_end(msg, start_trip);
> +
> +	return 0;
> +
> +out_cancel_nest:
> +	mutex_unlock(&tz->lock);
> +
> +	return -EMSGSIZE;
> +}
> +
> +static int thermal_genl_cmd_tz_get_temp(struct param *p)
> +{
> +	struct sk_buff *msg = p->msg;
> +	struct thermal_zone_device *tz;
> +	int temp, ret, id;
> +
> +	if (!p->attrs[THERMAL_GENL_ATTR_TZ_ID])
> +		return -EINVAL;
> +
> +	id = nla_get_u32(p->attrs[THERMAL_GENL_ATTR_TZ_ID]);
> +
> +	tz = thermal_zone_get_by_id(id);
> +	if (!tz)
> +		return -EINVAL;
> +
> +	ret = thermal_zone_get_temp(tz, &temp);
> +	if (ret)
> +		return ret;
> +
> +	if (nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_ID, id) ||
> +	    nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_TEMP, temp))
> +		return -EMSGSIZE;
> +
> +	return 0;
> +}
> +
> +static int thermal_genl_cmd_tz_get_gov(struct param *p)
> +{
> +	struct sk_buff *msg = p->msg;
> +	struct thermal_zone_device *tz;
> +	int id, ret = 0;
> +
> +	if (!p->attrs[THERMAL_GENL_ATTR_TZ_ID])
> +		return -EINVAL;
> +
> +	id = nla_get_u32(p->attrs[THERMAL_GENL_ATTR_TZ_ID]);
> +
> +	tz = thermal_zone_get_by_id(id);
> +	if (!tz)
> +		return -EINVAL;
> +
> +	mutex_lock(&tz->lock);
> +
> +	if (nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_ID, id) ||
> +	    nla_put_string(msg, THERMAL_GENL_ATTR_TZ_GOV_NAME,
> +			   tz->governor->name))
> +		ret = -EMSGSIZE;
> +
> +	mutex_unlock(&tz->lock);
> +
> +	return ret;
> +}
> +
> +static int __thermal_genl_cmd_cdev_get(struct thermal_cooling_device
> *cdev,
> +				       void *data)
> +{
> +	struct sk_buff *msg = data;
> +
> +	if (nla_put_u32(msg, THERMAL_GENL_ATTR_CDEV_ID, cdev->id))
> +		return -EMSGSIZE;
> +
> +	if (nla_put_string(msg, THERMAL_GENL_ATTR_CDEV_NAME, cdev-
> > type))
> +		return -EMSGSIZE;
> +
> +	return 0;
> +}
> +
> +static int thermal_genl_cmd_cdev_get(struct param *p)
> +{
> +	struct sk_buff *msg = p->msg;
> +	struct nlattr *start_cdev;
> +	int ret;
> +
> +	start_cdev = nla_nest_start(msg, THERMAL_GENL_ATTR_CDEV);
> +	if (!start_cdev)
> +		return -EMSGSIZE;
> +
> +	ret =
> for_each_thermal_cooling_device(__thermal_genl_cmd_cdev_get, msg);
> +	if (ret)
> +		goto out_cancel_nest;
> +
> +	nla_nest_end(msg, start_cdev);
> +
> +	return 0;
> +out_cancel_nest:
> +	nla_nest_cancel(msg, start_cdev);
> +
> +	return ret;
> +}
> +
> +static cb_t cmd_cb[] = {
> +	[THERMAL_GENL_CMD_TZ_GET]	= thermal_genl_cmd_tz_get,
> +	[THERMAL_GENL_CMD_TZ_GET_TRIP]	=
> thermal_genl_cmd_tz_get_trip,
> +	[THERMAL_GENL_CMD_TZ_GET_TEMP]	=
> thermal_genl_cmd_tz_get_temp,
> +	[THERMAL_GENL_CMD_TZ_GET_GOV]	=
> thermal_genl_cmd_tz_get_gov,
> +	[THERMAL_GENL_CMD_CDEV_GET]	= thermal_genl_cmd_cdev_get,
> +};
> +
> +int thermal_genl_cmd_dumpit(struct sk_buff *skb, struct
> netlink_callback *cb)
> +{
> +	struct param p = { .msg = skb };
> +	const struct genl_dumpit_info *info = genl_dumpit_info(cb);
> +	int cmd = info->ops->cmd;
> +	int ret = -EMSGSIZE;
> +	void *hdr;
> +
> +	hdr = genlmsg_put(skb, 0, 0, &thermal_gnl_family, 0, cmd);
> +	if (!hdr)
> +		return -EMSGSIZE;
> +
> +	ret = cmd_cb[cmd](&p);
> +	if (ret)
> +		goto out_cancel_msg;
> +
> +	genlmsg_end(skb, hdr);
> +
> +	return 0;
> +
> +out_cancel_msg:
> +	genlmsg_cancel(skb, hdr);
> +
> +	return ret;
> +}
> +
> +int thermal_genl_cmd_doit(struct sk_buff *skb, struct genl_info
> *info)
> +{
> +	struct param p = { .attrs = info->attrs };
> +	struct sk_buff *msg;
> +	void *hdr;
> +	int cmd = info->genlhdr->cmd;
> +	int ret = -EMSGSIZE;
> +
> +        msg = genlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL);
> +	if (!msg)
> +		return -ENOMEM;
> +	p.msg = msg;
> +
> +        hdr = genlmsg_put_reply(msg, info, &thermal_gnl_family, 0,
> cmd);
> +	if (!hdr)
> +		goto out_free_msg;
> +
> +	ret = cmd_cb[cmd](&p);
> +	if (ret)
> +		goto out_cancel_msg;
> +
> +	genlmsg_end(msg, hdr);
> +
> +	return genlmsg_reply(msg, info);
> +
> +out_cancel_msg:
> +	genlmsg_cancel(msg, hdr);
> +out_free_msg:
> +	nlmsg_free(msg);
> +
> +	return ret;
> +}
> +
> +static const struct genl_ops thermal_genl_ops[] = {
> +	{
> +		.cmd = THERMAL_GENL_CMD_TZ_GET,
> +		.validate = GENL_DONT_VALIDATE_STRICT |
> GENL_DONT_VALIDATE_DUMP,
> +		.dumpit = thermal_genl_cmd_dumpit,
> +	},
> +	{
> +		.cmd = THERMAL_GENL_CMD_TZ_GET_TRIP,
> +		.validate = GENL_DONT_VALIDATE_STRICT |
> GENL_DONT_VALIDATE_DUMP,
> +		.doit = thermal_genl_cmd_doit,
> +	},
> +	{
> +		.cmd = THERMAL_GENL_CMD_TZ_GET_TEMP,
> +		.validate = GENL_DONT_VALIDATE_STRICT |
> GENL_DONT_VALIDATE_DUMP,
> +		.doit = thermal_genl_cmd_doit,
> +	},
> +	{
> +		.cmd = THERMAL_GENL_CMD_TZ_GET_GOV,
> +		.validate = GENL_DONT_VALIDATE_STRICT |
> GENL_DONT_VALIDATE_DUMP,
> +		.doit = thermal_genl_cmd_doit,
> +	},
> +	{
> +		.cmd = THERMAL_GENL_CMD_CDEV_GET,
> +		.validate = GENL_DONT_VALIDATE_STRICT |
> GENL_DONT_VALIDATE_DUMP,
> +		.dumpit = thermal_genl_cmd_dumpit,
> +	},
> +};
> +
> +static struct genl_family thermal_gnl_family __ro_after_init = {
> +	.hdrsize	= 0,
> +	.name		= THERMAL_GENL_FAMILY_NAME,
> +	.version	= THERMAL_GENL_VERSION,
> +	.maxattr	= THERMAL_GENL_ATTR_MAX,
> +	.policy		= thermal_genl_policy,
> +	.ops		= thermal_genl_ops,
> +	.n_ops 		= ARRAY_SIZE(thermal_genl_ops),
> +	.mcgrps		= thermal_genl_mcgrps,
> +	.n_mcgrps	= ARRAY_SIZE(thermal_genl_mcgrps),
> +};
> +
> +static int __init thermal_netlink_init(void)
> +{
> +	return genl_register_family(&thermal_gnl_family);
> +}
> +core_initcall(thermal_netlink_init);
> diff --git a/include/linux/thermal.h b/include/linux/thermal.h
> index fc93a6348082..d92643e310e2 100644
> --- a/include/linux/thermal.h
> +++ b/include/linux/thermal.h
> @@ -37,18 +37,6 @@ struct thermal_cooling_device;
>  struct thermal_instance;
>  struct thermal_attr;
>  
> -enum thermal_device_mode {
> -	THERMAL_DEVICE_DISABLED = 0,
> -	THERMAL_DEVICE_ENABLED,
> -};
> -
> -enum thermal_trip_type {
> -	THERMAL_TRIP_ACTIVE = 0,
> -	THERMAL_TRIP_PASSIVE,
> -	THERMAL_TRIP_HOT,
> -	THERMAL_TRIP_CRITICAL,
> -};
> -
>  enum thermal_trend {
>  	THERMAL_TREND_STABLE, /* temperature is stable */
>  	THERMAL_TREND_RAISING, /* temperature is raising */
> diff --git a/include/uapi/linux/thermal.h
> b/include/uapi/linux/thermal.h
> index 22df67ed9e9c..3ee7515c7aea 100644
> --- a/include/uapi/linux/thermal.h
> +++ b/include/uapi/linux/thermal.h
> @@ -4,21 +4,87 @@
>  
>  #define THERMAL_NAME_LENGTH	20
>  
> +enum thermal_device_mode {
> +	THERMAL_DEVICE_DISABLED = 0,
> +	THERMAL_DEVICE_ENABLED,
> +};
> +
> +enum thermal_trip_type {
> +	THERMAL_TRIP_ACTIVE = 0,
> +	THERMAL_TRIP_PASSIVE,
> +	THERMAL_TRIP_HOT,
> +	THERMAL_TRIP_CRITICAL,
> +};
> +
>  /* Adding event notification support elements */
> -#define THERMAL_GENL_FAMILY_NAME                "thermal_event"
> -#define THERMAL_GENL_VERSION                    0x02
> -#define THERMAL_GENL_MCAST_GROUP_NAME           "thermal_mc_grp"
> +#define THERMAL_GENL_FAMILY_NAME		"thermal"
> +#define THERMAL_GENL_VERSION			0x01
> +#define THERMAL_GENL_SAMPLING_GROUP_NAME	"sampling"
> +#define THERMAL_GENL_EVENT_GROUP_NAME		"event"
>  
> -/* attributes of thermal_genl_family */
> -enum {
> +/* Attributes of thermal_genl_family */
> +enum thermal_genl_attr {
>  	THERMAL_GENL_ATTR_UNSPEC,
> +	THERMAL_GENL_ATTR_TZ,
> +	THERMAL_GENL_ATTR_TZ_ID,
> +	THERMAL_GENL_ATTR_TZ_TEMP,
> +	THERMAL_GENL_ATTR_TZ_TRIP,
> +	THERMAL_GENL_ATTR_TZ_TRIP_ID,
> +	THERMAL_GENL_ATTR_TZ_TRIP_TYPE,
> +	THERMAL_GENL_ATTR_TZ_TRIP_TEMP,
> +	THERMAL_GENL_ATTR_TZ_TRIP_HYST,
> +	THERMAL_GENL_ATTR_TZ_MODE,
> +	THERMAL_GENL_ATTR_TZ_NAME,
> +	THERMAL_GENL_ATTR_TZ_CDEV_WEIGHT,
> +	THERMAL_GENL_ATTR_TZ_GOV,
> +	THERMAL_GENL_ATTR_TZ_GOV_NAME,
> +	THERMAL_GENL_ATTR_CDEV,
> +	THERMAL_GENL_ATTR_CDEV_ID,
> +	THERMAL_GENL_ATTR_CDEV_CUR_STATE,
> +	THERMAL_GENL_ATTR_CDEV_MAX_STATE,
> +	THERMAL_GENL_ATTR_CDEV_MIN_STATE,
> +	THERMAL_GENL_ATTR_CDEV_NAME,
> +	THERMAL_GENL_ATTR_GOV_NAME,
> +
>  	__THERMAL_GENL_ATTR_MAX,
>  };
>  #define THERMAL_GENL_ATTR_MAX (__THERMAL_GENL_ATTR_MAX - 1)
>  
> -/* commands supported by the thermal_genl_family */
> -enum {
> +enum thermal_genl_sampling {
> +	THERMAL_GENL_SAMPLING_TEMP,
> +	__THERMAL_GENL_SAMPLING_MAX,
> +};
> +#define THERMAL_GENL_SAMPLING_MAX (__THERMAL_GENL_SAMPLING_MAX - 1)
> +
> +/* Events of thermal_genl_family */
> +enum thermal_genl_event {
> +	THERMAL_GENL_EVENT_UNSPEC,
> +	THERMAL_GENL_EVENT_TZ_CREATE,		/* Thermal zone
> creation */
> +	THERMAL_GENL_EVENT_TZ_DELETE,		/* Thermal zone
> deletion */
> +	THERMAL_GENL_EVENT_TZ_DISABLE,		/* Thermal zone
> disabed */
> +	THERMAL_GENL_EVENT_TZ_ENABLE,		/* Thermal zone
> enabled */
> +	THERMAL_GENL_EVENT_TZ_TRIP_HIGH,	/* Trip point crossed the way
> up */
> +	THERMAL_GENL_EVENT_TZ_TRIP_LOW,		/* Trip point crossed
> the way down */
> +	THERMAL_GENL_EVENT_TZ_TRIP_CHANGE,	/* Trip point changed
> */
> +	THERMAL_GENL_EVENT_TZ_TRIP_ADD,		/* Trip point added
> */
> +	THERMAL_GENL_EVENT_TZ_TRIP_DELETE,	/* Trip point deleted
> */
> +	THERMAL_GENL_EVENT_TZ_CDEV_ADD,		/* Cdev bound to the
> thermal zone */
> +	THERMAL_GENL_EVENT_TZ_CDEV_DELETE,	/* Cdev unbound */
> +	THERMAL_GENL_EVENT_TZ_CDEV_UPDATE,	/* Cdev state updated
> */
> +	THERMAL_GENL_EVENT_TZ_GOV_CHANGE,	/* Governor policy
> changed  */
> +	__THERMAL_GENL_EVENT_MAX,
> +};
> +#define THERMAL_GENL_EVENT_MAX (__THERMAL_GENL_EVENT_MAX - 1)
> +
> +/* Commands supported by the thermal_genl_family */
> +enum thermal_genl_cmd {
>  	THERMAL_GENL_CMD_UNSPEC,
> +	THERMAL_GENL_CMD_TZ_GET,	/* List thermal zones id */
> +	THERMAL_GENL_CMD_TZ_GET_TRIP,	/* List of thermal trips */
> +	THERMAL_GENL_CMD_TZ_GET_TEMP,	/* Get the thermal zone
> temperature */
> +	THERMAL_GENL_CMD_TZ_GET_GOV,	/* Get the thermal zone
> governor */
> +	THERMAL_GENL_CMD_TZ_GET_MODE,	/* Get the thermal zone mode
> */
> +	THERMAL_GENL_CMD_CDEV_GET,	/* List of cdev id */
>  	__THERMAL_GENL_CMD_MAX,
>  };
>  #define THERMAL_GENL_CMD_MAX (__THERMAL_GENL_CMD_MAX - 1)

Re: [PATCH 4/4] thermal: core: genetlink support for events/cmd/sampling

[Srinivas Pandruvada]

On Fri, 2020-05-15 at 16:10 +0200, Daniel Lezcano wrote:
> Initially the thermal framework had a very simple notification
> mechanism to send generic netlink messages to the userspace.
> 
> The notification function was never called from anywhere and the
> corresponding dead code was removed. It was probably a first attempt
> to introduce the netlink notification.
> 
> At LPC2018, the presentation "Linux thermal: User kernel interface",
> proposed to create the notifications to the userspace via a kfifo.
> 
> The advantage of the kfifo is the performance. It is usually used
> from
> a 1:1 communication channel where a driver captures data and send
> them
> as fast as possible to an userspace process.
Shall I submit my RFC using KFifo on top of this series? Any
objections?

Thanks,
Srinivas

> The inconvenient is the process uses the notification channel
> exclusively, thus no other process is allowed to use the channel to
> get temperature or notifications.
> 
> The purpose of this series is to provide a fully netlink featured
> thermal management.
> 
> This patch is defining a generic netlink API to discover the current
> thermal setup, get events and temperature sampling. As any genetlink
> protocol, it can evolve and the versionning allows to keep the
> backward
> compatibility.
> 
> In order to not flood the user with a single channel data, there are
> two multicast channels, one for the temperature sampling when the
> thermal zone is updated and another one for the events, so the user
> can get the events only without the thermal zone temperature
> sampling. All these events are from the ones presented at the
> LPC2018.
> 
> Also, a list of commands to discover the thermal setup is given and
> can be extended on purpose.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
>  drivers/thermal/Makefile          |   2 +-
>  drivers/thermal/thermal_core.h    |  13 +
>  drivers/thermal/thermal_netlink.c | 612
> ++++++++++++++++++++++++++++++
>  include/linux/thermal.h           |  12 -
>  include/uapi/linux/thermal.h      |  80 +++-
>  5 files changed, 699 insertions(+), 20 deletions(-)
>  create mode 100644 drivers/thermal/thermal_netlink.c
> 
> diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile
> index 8c8ed7b79915..80fddb02cb32 100644
> --- a/drivers/thermal/Makefile
> +++ b/drivers/thermal/Makefile
> @@ -5,7 +5,7 @@
>  
>  obj-$(CONFIG_THERMAL)		+= thermal_sys.o
>  thermal_sys-y			+= thermal_core.o
> thermal_sysfs.o \
> -					thermal_helpers.o
> +					thermal_helpers.o
> thermal_netlink.o
>  
>  # interface to/from other layers providing sensors
>  thermal_sys-$(CONFIG_THERMAL_HWMON)		+= thermal_hwmon.o
> diff --git a/drivers/thermal/thermal_core.h
> b/drivers/thermal/thermal_core.h
> index 7e8f45db6bbf..4c98d398c301 100644
> --- a/drivers/thermal/thermal_core.h
> +++ b/drivers/thermal/thermal_core.h
> @@ -52,6 +52,19 @@ int for_each_thermal_governor(int (*cb)(struct
> thermal_governor *, void *),
>  
>  struct thermal_zone_device *thermal_zone_get_by_id(int id);
>  
> +/* Netlink notification function */
> +int thermal_notify_tz_create(int tz_id, const char *name);
> +int thermal_notify_tz_delete(int tz_id);
> +int thermal_notify_tz_enable(int tz_id);
> +int thermal_notify_tz_disable(int tz_id);
> +int thermal_notify_tz_trip_low(int tz_id, int id);
> +int thermal_notify_tz_trip_high(int tz_id, int id);
> +int thermal_notify_tz_trip_delete(int tz_id, int id);
> +int thermal_notify_tz_trip_add(int tz_id, int id, int type,
> +			       int temp, int hyst);
> +int thermal_notify_tz_trip_change(int tz_id, int id, int type,
> +				  int temp, int hyst);
> +
>  struct thermal_attr {
>  	struct device_attribute attr;
>  	char name[THERMAL_NAME_LENGTH];
> diff --git a/drivers/thermal/thermal_netlink.c
> b/drivers/thermal/thermal_netlink.c
> new file mode 100644
> index 000000000000..a2bce846771e
> --- /dev/null
> +++ b/drivers/thermal/thermal_netlink.c
> @@ -0,0 +1,612 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright 2020 Linaro Limited
> + *
> + * Author: Daniel Lezcano <daniel.lezcano@linaro.org>
> + *
> + * Generic netlink for thermal management framework
> + */
> +#include <linux/module.h>
> +#include <linux/kernel.h>
> +#include <net/genetlink.h>
> +#include <uapi/linux/thermal.h>
> +
> +#include "thermal_core.h"
> +
> +static const struct genl_multicast_group thermal_genl_mcgrps[] = {
> +	{ .name = THERMAL_GENL_SAMPLING_GROUP_NAME, },
> +	{ .name = THERMAL_GENL_EVENT_GROUP_NAME,  },
> +};
> +
> +static const struct nla_policy
> thermal_genl_policy[THERMAL_GENL_ATTR_MAX + 1] = {
> +	/* Thermal zone */
> +	[THERMAL_GENL_ATTR_TZ]			= { .type =
> NLA_NESTED },
> +	[THERMAL_GENL_ATTR_TZ_ID]		= { .type = NLA_U32 },
> +	[THERMAL_GENL_ATTR_TZ_TEMP]		= { .type = NLA_U32
> },
> +	[THERMAL_GENL_ATTR_TZ_TRIP]		= { .type =
> NLA_NESTED },
> +	[THERMAL_GENL_ATTR_TZ_TRIP_ID]		= { .type = NLA_U32
> },
> +	[THERMAL_GENL_ATTR_TZ_TRIP_TEMP]	= { .type = NLA_U32 },
> +	[THERMAL_GENL_ATTR_TZ_TRIP_TYPE]	= { .type = NLA_U32 },
> +	[THERMAL_GENL_ATTR_TZ_TRIP_HYST]	= { .type = NLA_U32 },
> +	[THERMAL_GENL_ATTR_TZ_MODE]		= { .type = NLA_U32
> },
> +	[THERMAL_GENL_ATTR_TZ_CDEV_WEIGHT]	= { .type = NLA_U32
> },
> +	[THERMAL_GENL_ATTR_TZ_NAME]		= { .type =
> NLA_STRING,
> +						    .len =
> THERMAL_NAME_LENGTH },
> +	/* Governor(s) */
> +	[THERMAL_GENL_ATTR_TZ_GOV]		= { .type =
> NLA_NESTED },
> +	[THERMAL_GENL_ATTR_TZ_GOV_NAME]		= { .type =
> NLA_STRING,
> +						    .len =
> THERMAL_NAME_LENGTH },
> +	/* Cooling devices */
> +	[THERMAL_GENL_ATTR_CDEV]		= { .type = NLA_NESTED },
> +	[THERMAL_GENL_ATTR_CDEV_ID]		= { .type = NLA_U32
> },
> +	[THERMAL_GENL_ATTR_CDEV_CUR_STATE]	= { .type = NLA_U32
> },
> +	[THERMAL_GENL_ATTR_CDEV_MAX_STATE]	= { .type = NLA_U32
> },
> +	[THERMAL_GENL_ATTR_CDEV_MIN_STATE]	= { .type = NLA_U32
> },
> +	[THERMAL_GENL_ATTR_CDEV_NAME]		= { .type =
> NLA_STRING,
> +						    .len =
> THERMAL_NAME_LENGTH },
> +};
> +
> +struct param {
> +	struct nlattr ** attrs;
> +	struct sk_buff *msg;
> +	const char *name;
> +	int tz_id;
> +	int id;
> +	int temp;
> +	int type;
> +	int hyst;
> +	int state;
> +	int min_state;
> +	int max_state;
> +};
> +
> +typedef int (*cb_t)(struct param *);
> +
> +static struct genl_family thermal_gnl_family;
> +
> +/************************** Sampling encoding
> *******************************/
> +
> +int thermal_genl_sampling_temp(int id, int temp)
> +{
> +	struct sk_buff *skb;
> +	void *hdr;
> +
> +	skb = genlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL);
> +	if (!skb)
> +		return -ENOMEM;
> +
> +	hdr = genlmsg_put(skb, 0, 0, &thermal_gnl_family, 0,
> +			  THERMAL_GENL_SAMPLING_TEMP);
> +	if (!hdr)
> +		return -EMSGSIZE;
> +
> +	if (nla_put_u32(skb, THERMAL_GENL_ATTR_TZ_ID, id))
> +		goto out_cancel;
> +
> +	if (nla_put_u32(skb, THERMAL_GENL_ATTR_TZ_TEMP, temp))
> +		goto out_cancel;
> +
> +	genlmsg_end(skb, hdr);
> +
> +	genlmsg_multicast(&thermal_gnl_family, skb, 0, 0, GFP_KERNEL);
> +
> +	return 0;
> +out_cancel:
> +	genlmsg_cancel(skb, hdr);
> +	nlmsg_free(skb);
> +
> +	return -EMSGSIZE;
> +}
> +
> +/**************************** Event encoding
> *********************************/
> +
> +static int thermal_genl_event_tz_create(struct param *p)
> +{
> +	if (nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_ID, p->tz_id) ||
> +	    nla_put_string(p->msg, THERMAL_GENL_ATTR_TZ_NAME, p->name))
> +		return -EMSGSIZE;
> +
> +	return 0;
> +}
> +
> +static int thermal_genl_event_tz(struct param *p)
> +{
> +	if (nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_ID, p->tz_id))
> +		return -EMSGSIZE;
> +
> +	return 0;
> +}
> +
> +static int thermal_genl_event_tz_trip_high(struct param *p)
> +{
> +	if (nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_ID, p->tz_id) ||
> +	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_TRIP_ID, p->id))
> +		return -EMSGSIZE;
> +
> +	return 0;
> +}
> +
> +static int thermal_genl_event_tz_trip_add(struct param *p)
> +{
> +	if (nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_ID, p->tz_id) ||
> +	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_TRIP_ID, p->id) ||
> +	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_TRIP_TYPE, p-
> > type) ||
> +	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_TRIP_TEMP, p-
> > temp) ||
> +	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_TRIP_HYST, p-
> > hyst))
> +		return -EMSGSIZE;
> +
> +	return 0;
> +}
> +
> +static int thermal_genl_event_tz_trip_delete(struct param *p)
> +{
> +	if (nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_ID, p->tz_id) ||
> +	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_TRIP_ID, p->id))
> +		return -EMSGSIZE;
> +
> +	return 0;
> +}
> +
> +static int thermal_genl_event_cdev_add(struct param *p)
> +{
> +	if (nla_put_string(p->msg, THERMAL_GENL_ATTR_CDEV_NAME,
> +			   p->name) ||
> +	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_CDEV_ID,
> +			p->id) ||
> +	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_CDEV_MIN_STATE,
> +			p->min_state) ||
> +	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_CDEV_MAX_STATE,
> +			p->max_state))
> +		return -EMSGSIZE;
> +
> +	return 0;
> +}
> +
> +static int thermal_genl_event_cdev_delete(struct param *p)
> +{
> +	if (nla_put_u32(p->msg, THERMAL_GENL_ATTR_CDEV_ID, p->id))
> +		return -EMSGSIZE;
> +
> +	return 0;
> +}
> +
> +static int thermal_genl_event_cdev_update(struct param *p)
> +{
> +	if (nla_put_u32(p->msg, THERMAL_GENL_ATTR_CDEV_ID, p->id) ||
> +	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_CDEV_CUR_STATE, p-
> > state))
> +		return -EMSGSIZE;
> +
> +	return 0;
> +}
> +
> +static int thermal_genl_event_gov_change(struct param *p)
> +{
> +	if (nla_put_u32(p->msg, THERMAL_GENL_ATTR_CDEV_ID, p->id) ||
> +	    nla_put_string(p->msg, THERMAL_GENL_ATTR_GOV_NAME, p-
> > name))
> +		return -EMSGSIZE;
> +
> +	return 0;
> +}
> +
> +int thermal_genl_event_tz_delete(struct param *p)
> +	__attribute__((alias("thermal_genl_event_tz")));
> +
> +int thermal_genl_event_tz_enable(struct param *p)
> +	__attribute__((alias("thermal_genl_event_tz")));
> +
> +int thermal_genl_event_tz_disable(struct param *p)
> +	__attribute__((alias("thermal_genl_event_tz")));
> +
> +int thermal_genl_event_tz_trip_low(struct param *p)
> +	__attribute__((alias("thermal_genl_event_tz_trip_high")));
> +
> +int thermal_genl_event_tz_trip_change(struct param *)
> +	__attribute__((alias("thermal_genl_event_tz_trip_add")));
> +
> +static cb_t event_cb[] = {
> +	[THERMAL_GENL_EVENT_TZ_CREATE]		=
> thermal_genl_event_tz_create,
> +	[THERMAL_GENL_EVENT_TZ_DELETE]		=
> thermal_genl_event_tz_delete,
> +	[THERMAL_GENL_EVENT_TZ_ENABLE]		=
> thermal_genl_event_tz_enable,
> +	[THERMAL_GENL_EVENT_TZ_DISABLE]		=
> thermal_genl_event_tz_disable,
> +	[THERMAL_GENL_EVENT_TZ_TRIP_HIGH]	=
> thermal_genl_event_tz_trip_high,
> +	[THERMAL_GENL_EVENT_TZ_TRIP_LOW]	=
> thermal_genl_event_tz_trip_low,
> +	[THERMAL_GENL_EVENT_TZ_TRIP_CHANGE]	=
> thermal_genl_event_tz_trip_change,
> +	[THERMAL_GENL_EVENT_TZ_TRIP_ADD]	=
> thermal_genl_event_tz_trip_add,
> +	[THERMAL_GENL_EVENT_TZ_TRIP_DELETE]	=
> thermal_genl_event_tz_trip_delete,
> +	[THERMAL_GENL_EVENT_TZ_CDEV_ADD]	=
> thermal_genl_event_cdev_add,
> +	[THERMAL_GENL_EVENT_TZ_CDEV_DELETE]	=
> thermal_genl_event_cdev_delete,
> +	[THERMAL_GENL_EVENT_TZ_CDEV_UPDATE]	=
> thermal_genl_event_cdev_update,
> +	[THERMAL_GENL_EVENT_TZ_GOV_CHANGE]	=
> thermal_genl_event_gov_change,
> +};
> +
> +/*
> + * Generic netlink event encoding
> + */
> +static int thermal_genl_send_event(enum thermal_genl_event event,
> +				   struct param *p)
> +{
> +	struct sk_buff *msg;
> +	int ret = -EMSGSIZE;
> +	void *hdr;
> +
> +        msg = genlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL);
> +	if (!msg)
> +		return -ENOMEM;
> +	p->msg = msg;
> +
> +	hdr = genlmsg_put(msg, 0, 0, &thermal_gnl_family, 0, event);
> +	if (!hdr)
> +		goto out_free_msg;
> +
> +	ret = event_cb[event](p);
> +	if (ret)
> +		goto out_cancel_msg;
> +
> +	genlmsg_end(msg, hdr);
> +
> +	genlmsg_multicast(&thermal_gnl_family, msg, 0, 1, GFP_KERNEL);
> +
> +	return 0;
> +
> +out_cancel_msg:
> +	genlmsg_cancel(msg, hdr);
> +out_free_msg:
> +	nlmsg_free(msg);
> +
> +	return ret;
> +}
> +
> +int thermal_notify_tz_create(int tz_id, const char *name)
> +{
> +	struct param p = { .tz_id = tz_id, .name = name };
> +
> +	return 	thermal_genl_send_event(THERMAL_GENL_EVENT_TZ_CREATE,
> &p);
> +}
> +
> +int thermal_notify_tz_delete(int tz_id)
> +{
> +	struct param p = { .tz_id = tz_id };
> +
> +	return 	thermal_genl_send_event(THERMAL_GENL_EVENT_TZ_DELETE,
> &p);
> +}
> +
> +int thermal_notify_tz_enable(int tz_id)
> +{
> +	struct param p = { .tz_id = tz_id };
> +
> +	return 	thermal_genl_send_event(THERMAL_GENL_EVENT_TZ_ENABLE,
> &p);
> +}
> +
> +int thermal_notify_tz_disable(int tz_id)
> +{
> +	struct param p = { .tz_id = tz_id };
> +
> +	return 	thermal_genl_send_event(THERMAL_GENL_EVENT_TZ_DISABLE
> , &p);
> +}
> +
> +int thermal_notify_tz_trip_low(int tz_id, int id)
> +{
> +	struct param p = { .tz_id = tz_id, .id = id };
> +
> +	return 	thermal_genl_send_event(THERMAL_GENL_EVENT_TZ_TRIP_LO
> W, &p);
> +}
> +
> +int thermal_notify_tz_trip_high(int tz_id, int id)
> +{
> +	struct param p = { .tz_id = tz_id, .id = id };
> +
> +	return 	thermal_genl_send_event(THERMAL_GENL_EVENT_TZ_TRIP_HI
> GH, &p);
> +}
> +
> +int thermal_notify_tz_trip_add(int tz_id, int id, int type, int
> temp, int hyst)
> +{
> +	struct param p = { .tz_id = tz_id, .id = id, .type = type,
> +			   .temp = temp, .hyst = hyst };
> +
> +	return 	thermal_genl_send_event(THERMAL_GENL_EVENT_TZ_TRIP_AD
> D, &p);
> +}
> +
> +int thermal_notify_tz_trip_delete(int tz_id, int id)
> +{
> +	struct param p = { .tz_id = tz_id, .id = id };
> +
> +	return 	thermal_genl_send_event(THERMAL_GENL_EVENT_TZ_TRIP_DE
> LETE, &p);
> +}
> +
> +int thermal_notify_tz_trip_change(int tz_id, int id, int type, int
> temp, int hyst)
> +{
> +	struct param p = { .tz_id = tz_id, .id = id, .type = type,
> +			   .temp = temp, .hyst = hyst };
> +
> +	return 	thermal_genl_send_event(THERMAL_GENL_EVENT_TZ_TRIP_CH
> ANGE, &p);
> +}
> +
> +/*************************** Command encoding
> ********************************/
> +
> +static int __thermal_genl_cmd_tz_get(struct thermal_zone_device *tz,
> void *data)
> +{
> +	struct sk_buff *msg = data;
> +
> +	if (nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_ID, tz->id) ||
> +	    nla_put_string(msg, THERMAL_GENL_ATTR_TZ_NAME, tz->type))
> +		return -EMSGSIZE;
> +
> +	return 0;
> +}
> +
> +static int thermal_genl_cmd_tz_get(struct param *p)
> +{
> +	struct sk_buff *msg = p->msg;
> +	struct nlattr *start_tz;
> +	int ret;
> +
> +	start_tz = nla_nest_start(msg, THERMAL_GENL_ATTR_TZ);
> +	if (!start_tz)
> +		return -EMSGSIZE;
> +
> +	ret = for_each_thermal_zone(__thermal_genl_cmd_tz_get, msg);
> +	if (ret)
> +		goto out_cancel_nest;
> +
> +	nla_nest_end(msg, start_tz);
> +
> +	return 0;
> +
> +out_cancel_nest:
> +	nla_nest_cancel(msg, start_tz);
> +
> +	return ret;
> +}
> +
> +static int thermal_genl_cmd_tz_get_trip(struct param *p)
> +{
> +	struct sk_buff *msg = p->msg;
> +	struct thermal_zone_device *tz;
> +	struct nlattr *start_trip;
> +	int i, id;
> +
> +	if (!p->attrs[THERMAL_GENL_ATTR_TZ_ID])
> +		return -EINVAL;
> +
> +	id = nla_get_u32(p->attrs[THERMAL_GENL_ATTR_TZ_ID]);
> +
> +	tz = thermal_zone_get_by_id(id);
> +	if (!tz)
> +		return -EINVAL;
> +
> +	start_trip = nla_nest_start(msg, THERMAL_GENL_ATTR_TZ_TRIP);
> +	if (!start_trip)
> +		return -EMSGSIZE;
> +
> +	mutex_lock(&tz->lock);
> +
> +	for (i = 0; i < tz->trips; i++) {
> +
> +		enum thermal_trip_type type;
> +		int temp, hyst;
> +
> +		tz->ops->get_trip_type(tz, i, &type);
> +		tz->ops->get_trip_temp(tz, i, &temp);
> +		tz->ops->get_trip_hyst(tz, i, &hyst);
> +
> +		if (nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_TRIP_ID, i)
> +		    nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_TRIP_TYPE,
> type) ||
> +		    nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_TRIP_TEMP,
> temp) ||
> +		    nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_TRIP_HYST,
> hyst))
> +			goto out_cancel_nest;
> +	}
> +
> +	mutex_unlock(&tz->lock);
> +
> +	nla_nest_end(msg, start_trip);
> +
> +	return 0;
> +
> +out_cancel_nest:
> +	mutex_unlock(&tz->lock);
> +
> +	return -EMSGSIZE;
> +}
> +
> +static int thermal_genl_cmd_tz_get_temp(struct param *p)
> +{
> +	struct sk_buff *msg = p->msg;
> +	struct thermal_zone_device *tz;
> +	int temp, ret, id;
> +
> +	if (!p->attrs[THERMAL_GENL_ATTR_TZ_ID])
> +		return -EINVAL;
> +
> +	id = nla_get_u32(p->attrs[THERMAL_GENL_ATTR_TZ_ID]);
> +
> +	tz = thermal_zone_get_by_id(id);
> +	if (!tz)
> +		return -EINVAL;
> +
> +	ret = thermal_zone_get_temp(tz, &temp);
> +	if (ret)
> +		return ret;
> +
> +	if (nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_ID, id) ||
> +	    nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_TEMP, temp))
> +		return -EMSGSIZE;
> +
> +	return 0;
> +}
> +
> +static int thermal_genl_cmd_tz_get_gov(struct param *p)
> +{
> +	struct sk_buff *msg = p->msg;
> +	struct thermal_zone_device *tz;
> +	int id, ret = 0;
> +
> +	if (!p->attrs[THERMAL_GENL_ATTR_TZ_ID])
> +		return -EINVAL;
> +
> +	id = nla_get_u32(p->attrs[THERMAL_GENL_ATTR_TZ_ID]);
> +
> +	tz = thermal_zone_get_by_id(id);
> +	if (!tz)
> +		return -EINVAL;
> +
> +	mutex_lock(&tz->lock);
> +
> +	if (nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_ID, id) ||
> +	    nla_put_string(msg, THERMAL_GENL_ATTR_TZ_GOV_NAME,
> +			   tz->governor->name))
> +		ret = -EMSGSIZE;
> +
> +	mutex_unlock(&tz->lock);
> +
> +	return ret;
> +}
> +
> +static int __thermal_genl_cmd_cdev_get(struct thermal_cooling_device
> *cdev,
> +				       void *data)
> +{
> +	struct sk_buff *msg = data;
> +
> +	if (nla_put_u32(msg, THERMAL_GENL_ATTR_CDEV_ID, cdev->id))
> +		return -EMSGSIZE;
> +
> +	if (nla_put_string(msg, THERMAL_GENL_ATTR_CDEV_NAME, cdev-
> > type))
> +		return -EMSGSIZE;
> +
> +	return 0;
> +}
> +
> +static int thermal_genl_cmd_cdev_get(struct param *p)
> +{
> +	struct sk_buff *msg = p->msg;
> +	struct nlattr *start_cdev;
> +	int ret;
> +
> +	start_cdev = nla_nest_start(msg, THERMAL_GENL_ATTR_CDEV);
> +	if (!start_cdev)
> +		return -EMSGSIZE;
> +
> +	ret =
> for_each_thermal_cooling_device(__thermal_genl_cmd_cdev_get, msg);
> +	if (ret)
> +		goto out_cancel_nest;
> +
> +	nla_nest_end(msg, start_cdev);
> +
> +	return 0;
> +out_cancel_nest:
> +	nla_nest_cancel(msg, start_cdev);
> +
> +	return ret;
> +}
> +
> +static cb_t cmd_cb[] = {
> +	[THERMAL_GENL_CMD_TZ_GET]	= thermal_genl_cmd_tz_get,
> +	[THERMAL_GENL_CMD_TZ_GET_TRIP]	=
> thermal_genl_cmd_tz_get_trip,
> +	[THERMAL_GENL_CMD_TZ_GET_TEMP]	=
> thermal_genl_cmd_tz_get_temp,
> +	[THERMAL_GENL_CMD_TZ_GET_GOV]	=
> thermal_genl_cmd_tz_get_gov,
> +	[THERMAL_GENL_CMD_CDEV_GET]	= thermal_genl_cmd_cdev_get,
> +};
> +
> +int thermal_genl_cmd_dumpit(struct sk_buff *skb, struct
> netlink_callback *cb)
> +{
> +	struct param p = { .msg = skb };
> +	const struct genl_dumpit_info *info = genl_dumpit_info(cb);
> +	int cmd = info->ops->cmd;
> +	int ret = -EMSGSIZE;
> +	void *hdr;
> +
> +	hdr = genlmsg_put(skb, 0, 0, &thermal_gnl_family, 0, cmd);
> +	if (!hdr)
> +		return -EMSGSIZE;
> +
> +	ret = cmd_cb[cmd](&p);
> +	if (ret)
> +		goto out_cancel_msg;
> +
> +	genlmsg_end(skb, hdr);
> +
> +	return 0;
> +
> +out_cancel_msg:
> +	genlmsg_cancel(skb, hdr);
> +
> +	return ret;
> +}
> +
> +int thermal_genl_cmd_doit(struct sk_buff *skb, struct genl_info
> *info)
> +{
> +	struct param p = { .attrs = info->attrs };
> +	struct sk_buff *msg;
> +	void *hdr;
> +	int cmd = info->genlhdr->cmd;
> +	int ret = -EMSGSIZE;
> +
> +        msg = genlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL);
> +	if (!msg)
> +		return -ENOMEM;
> +	p.msg = msg;
> +
> +        hdr = genlmsg_put_reply(msg, info, &thermal_gnl_family, 0,
> cmd);
> +	if (!hdr)
> +		goto out_free_msg;
> +
> +	ret = cmd_cb[cmd](&p);
> +	if (ret)
> +		goto out_cancel_msg;
> +
> +	genlmsg_end(msg, hdr);
> +
> +	return genlmsg_reply(msg, info);
> +
> +out_cancel_msg:
> +	genlmsg_cancel(msg, hdr);
> +out_free_msg:
> +	nlmsg_free(msg);
> +
> +	return ret;
> +}
> +
> +static const struct genl_ops thermal_genl_ops[] = {
> +	{
> +		.cmd = THERMAL_GENL_CMD_TZ_GET,
> +		.validate = GENL_DONT_VALIDATE_STRICT |
> GENL_DONT_VALIDATE_DUMP,
> +		.dumpit = thermal_genl_cmd_dumpit,
> +	},
> +	{
> +		.cmd = THERMAL_GENL_CMD_TZ_GET_TRIP,
> +		.validate = GENL_DONT_VALIDATE_STRICT |
> GENL_DONT_VALIDATE_DUMP,
> +		.doit = thermal_genl_cmd_doit,
> +	},
> +	{
> +		.cmd = THERMAL_GENL_CMD_TZ_GET_TEMP,
> +		.validate = GENL_DONT_VALIDATE_STRICT |
> GENL_DONT_VALIDATE_DUMP,
> +		.doit = thermal_genl_cmd_doit,
> +	},
> +	{
> +		.cmd = THERMAL_GENL_CMD_TZ_GET_GOV,
> +		.validate = GENL_DONT_VALIDATE_STRICT |
> GENL_DONT_VALIDATE_DUMP,
> +		.doit = thermal_genl_cmd_doit,
> +	},
> +	{
> +		.cmd = THERMAL_GENL_CMD_CDEV_GET,
> +		.validate = GENL_DONT_VALIDATE_STRICT |
> GENL_DONT_VALIDATE_DUMP,
> +		.dumpit = thermal_genl_cmd_dumpit,
> +	},
> +};
> +
> +static struct genl_family thermal_gnl_family __ro_after_init = {
> +	.hdrsize	= 0,
> +	.name		= THERMAL_GENL_FAMILY_NAME,
> +	.version	= THERMAL_GENL_VERSION,
> +	.maxattr	= THERMAL_GENL_ATTR_MAX,
> +	.policy		= thermal_genl_policy,
> +	.ops		= thermal_genl_ops,
> +	.n_ops 		= ARRAY_SIZE(thermal_genl_ops),
> +	.mcgrps		= thermal_genl_mcgrps,
> +	.n_mcgrps	= ARRAY_SIZE(thermal_genl_mcgrps),
> +};
> +
> +static int __init thermal_netlink_init(void)
> +{
> +	return genl_register_family(&thermal_gnl_family);
> +}
> +core_initcall(thermal_netlink_init);
> diff --git a/include/linux/thermal.h b/include/linux/thermal.h
> index fc93a6348082..d92643e310e2 100644
> --- a/include/linux/thermal.h
> +++ b/include/linux/thermal.h
> @@ -37,18 +37,6 @@ struct thermal_cooling_device;
>  struct thermal_instance;
>  struct thermal_attr;
>  
> -enum thermal_device_mode {
> -	THERMAL_DEVICE_DISABLED = 0,
> -	THERMAL_DEVICE_ENABLED,
> -};
> -
> -enum thermal_trip_type {
> -	THERMAL_TRIP_ACTIVE = 0,
> -	THERMAL_TRIP_PASSIVE,
> -	THERMAL_TRIP_HOT,
> -	THERMAL_TRIP_CRITICAL,
> -};
> -
>  enum thermal_trend {
>  	THERMAL_TREND_STABLE, /* temperature is stable */
>  	THERMAL_TREND_RAISING, /* temperature is raising */
> diff --git a/include/uapi/linux/thermal.h
> b/include/uapi/linux/thermal.h
> index 22df67ed9e9c..3ee7515c7aea 100644
> --- a/include/uapi/linux/thermal.h
> +++ b/include/uapi/linux/thermal.h
> @@ -4,21 +4,87 @@
>  
>  #define THERMAL_NAME_LENGTH	20
>  
> +enum thermal_device_mode {
> +	THERMAL_DEVICE_DISABLED = 0,
> +	THERMAL_DEVICE_ENABLED,
> +};
> +
> +enum thermal_trip_type {
> +	THERMAL_TRIP_ACTIVE = 0,
> +	THERMAL_TRIP_PASSIVE,
> +	THERMAL_TRIP_HOT,
> +	THERMAL_TRIP_CRITICAL,
> +};
> +
>  /* Adding event notification support elements */
> -#define THERMAL_GENL_FAMILY_NAME                "thermal_event"
> -#define THERMAL_GENL_VERSION                    0x02
> -#define THERMAL_GENL_MCAST_GROUP_NAME           "thermal_mc_grp"
> +#define THERMAL_GENL_FAMILY_NAME		"thermal"
> +#define THERMAL_GENL_VERSION			0x01
> +#define THERMAL_GENL_SAMPLING_GROUP_NAME	"sampling"
> +#define THERMAL_GENL_EVENT_GROUP_NAME		"event"
>  
> -/* attributes of thermal_genl_family */
> -enum {
> +/* Attributes of thermal_genl_family */
> +enum thermal_genl_attr {
>  	THERMAL_GENL_ATTR_UNSPEC,
> +	THERMAL_GENL_ATTR_TZ,
> +	THERMAL_GENL_ATTR_TZ_ID,
> +	THERMAL_GENL_ATTR_TZ_TEMP,
> +	THERMAL_GENL_ATTR_TZ_TRIP,
> +	THERMAL_GENL_ATTR_TZ_TRIP_ID,
> +	THERMAL_GENL_ATTR_TZ_TRIP_TYPE,
> +	THERMAL_GENL_ATTR_TZ_TRIP_TEMP,
> +	THERMAL_GENL_ATTR_TZ_TRIP_HYST,
> +	THERMAL_GENL_ATTR_TZ_MODE,
> +	THERMAL_GENL_ATTR_TZ_NAME,
> +	THERMAL_GENL_ATTR_TZ_CDEV_WEIGHT,
> +	THERMAL_GENL_ATTR_TZ_GOV,
> +	THERMAL_GENL_ATTR_TZ_GOV_NAME,
> +	THERMAL_GENL_ATTR_CDEV,
> +	THERMAL_GENL_ATTR_CDEV_ID,
> +	THERMAL_GENL_ATTR_CDEV_CUR_STATE,
> +	THERMAL_GENL_ATTR_CDEV_MAX_STATE,
> +	THERMAL_GENL_ATTR_CDEV_MIN_STATE,
> +	THERMAL_GENL_ATTR_CDEV_NAME,
> +	THERMAL_GENL_ATTR_GOV_NAME,
> +
>  	__THERMAL_GENL_ATTR_MAX,
>  };
>  #define THERMAL_GENL_ATTR_MAX (__THERMAL_GENL_ATTR_MAX - 1)
>  
> -/* commands supported by the thermal_genl_family */
> -enum {
> +enum thermal_genl_sampling {
> +	THERMAL_GENL_SAMPLING_TEMP,
> +	__THERMAL_GENL_SAMPLING_MAX,
> +};
> +#define THERMAL_GENL_SAMPLING_MAX (__THERMAL_GENL_SAMPLING_MAX - 1)
> +
> +/* Events of thermal_genl_family */
> +enum thermal_genl_event {
> +	THERMAL_GENL_EVENT_UNSPEC,
> +	THERMAL_GENL_EVENT_TZ_CREATE,		/* Thermal zone
> creation */
> +	THERMAL_GENL_EVENT_TZ_DELETE,		/* Thermal zone
> deletion */
> +	THERMAL_GENL_EVENT_TZ_DISABLE,		/* Thermal zone
> disabed */
> +	THERMAL_GENL_EVENT_TZ_ENABLE,		/* Thermal zone
> enabled */
> +	THERMAL_GENL_EVENT_TZ_TRIP_HIGH,	/* Trip point crossed the way
> up */
> +	THERMAL_GENL_EVENT_TZ_TRIP_LOW,		/* Trip point crossed
> the way down */
> +	THERMAL_GENL_EVENT_TZ_TRIP_CHANGE,	/* Trip point changed
> */
> +	THERMAL_GENL_EVENT_TZ_TRIP_ADD,		/* Trip point added
> */
> +	THERMAL_GENL_EVENT_TZ_TRIP_DELETE,	/* Trip point deleted
> */
> +	THERMAL_GENL_EVENT_TZ_CDEV_ADD,		/* Cdev bound to the
> thermal zone */
> +	THERMAL_GENL_EVENT_TZ_CDEV_DELETE,	/* Cdev unbound */
> +	THERMAL_GENL_EVENT_TZ_CDEV_UPDATE,	/* Cdev state updated
> */
> +	THERMAL_GENL_EVENT_TZ_GOV_CHANGE,	/* Governor policy
> changed  */
> +	__THERMAL_GENL_EVENT_MAX,
> +};
> +#define THERMAL_GENL_EVENT_MAX (__THERMAL_GENL_EVENT_MAX - 1)
> +
> +/* Commands supported by the thermal_genl_family */
> +enum thermal_genl_cmd {
>  	THERMAL_GENL_CMD_UNSPEC,
> +	THERMAL_GENL_CMD_TZ_GET,	/* List thermal zones id */
> +	THERMAL_GENL_CMD_TZ_GET_TRIP,	/* List of thermal trips */
> +	THERMAL_GENL_CMD_TZ_GET_TEMP,	/* Get the thermal zone
> temperature */
> +	THERMAL_GENL_CMD_TZ_GET_GOV,	/* Get the thermal zone
> governor */
> +	THERMAL_GENL_CMD_TZ_GET_MODE,	/* Get the thermal zone mode
> */
> +	THERMAL_GENL_CMD_CDEV_GET,	/* List of cdev id */
>  	__THERMAL_GENL_CMD_MAX,
>  };
>  #define THERMAL_GENL_CMD_MAX (__THERMAL_GENL_CMD_MAX - 1)

Re: [PATCH 4/4] thermal: core: genetlink support for events/cmd/sampling

[Daniel Lezcano]

On 15/05/2020 16:43, Srinivas Pandruvada wrote:
> On Fri, 2020-05-15 at 16:10 +0200, Daniel Lezcano wrote:
>> Initially the thermal framework had a very simple notification
>> mechanism to send generic netlink messages to the userspace.
>>
>> The notification function was never called from anywhere and the
>> corresponding dead code was removed. It was probably a first attempt
>> to introduce the netlink notification.
>>
>> At LPC2018, the presentation "Linux thermal: User kernel interface",
>> proposed to create the notifications to the userspace via a kfifo.
>>
>> The advantage of the kfifo is the performance. It is usually used
>> from
>> a 1:1 communication channel where a driver captures data and send
>> them
>> as fast as possible to an userspace process.
> Shall I submit my RFC using KFifo on top of this series? Any
> objections?

ATM the notification is not plugged with any thermal core code path. It
is separated on purpose in order to let your RFC to get some comments.

If you want to base your RFC on top of it, I'm perfectly fine with that.

I'll review your RFC now, I wanted to do that before but got busy with
another stuff.

If you want to compare kfifo and netlink, the userspace test programs
are at:

https://git.linaro.org/people/daniel.lezcano/thermal-genl.git/

IMO, using the kfifo for the sampling and the notifications/the commands
via netlink would make more sense.


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

[RFC PATCH] thermal: core: thermal_genl_sampling_temp() can be static

[kbuild test robot]

Signed-off-by: kbuild test robot <lkp@intel.com>
---
 thermal_netlink.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/thermal/thermal_netlink.c b/drivers/thermal/thermal_netlink.c
index a2bce846771e4..851db26e66465 100644
--- a/drivers/thermal/thermal_netlink.c
+++ b/drivers/thermal/thermal_netlink.c
@@ -66,7 +66,7 @@ static struct genl_family thermal_gnl_family;
 
 /************************** Sampling encoding *******************************/
 
-int thermal_genl_sampling_temp(int id, int temp)
+static int thermal_genl_sampling_temp(int id, int temp)
 {
 	struct sk_buff *skb;
 	void *hdr;
@@ -506,7 +506,7 @@ static cb_t cmd_cb[] = {
 	[THERMAL_GENL_CMD_CDEV_GET]	= thermal_genl_cmd_cdev_get,
 };
 
-int thermal_genl_cmd_dumpit(struct sk_buff *skb, struct netlink_callback *cb)
+static int thermal_genl_cmd_dumpit(struct sk_buff *skb, struct netlink_callback *cb)
 {
 	struct param p = { .msg = skb };
 	const struct genl_dumpit_info *info = genl_dumpit_info(cb);
@@ -532,7 +532,7 @@ int thermal_genl_cmd_dumpit(struct sk_buff *skb, struct netlink_callback *cb)
 	return ret;
 }
 
-int thermal_genl_cmd_doit(struct sk_buff *skb, struct genl_info *info)
+static int thermal_genl_cmd_doit(struct sk_buff *skb, struct genl_info *info)
 {
 	struct param p = { .attrs = info->attrs };
 	struct sk_buff *msg;

Re: [PATCH 4/4] thermal: core: genetlink support for events/cmd/sampling

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 2666 bytes --]

Hi Daniel,

I love your patch! Perhaps something to improve:

[auto build test WARNING on next-20200514]
[cannot apply to linus/master v5.7-rc5 v5.7-rc4 v5.7-rc3 v5.7-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Daniel-Lezcano/thermal-core-Add-helpers-to-browse-the-cdev-tz-and-governor-list/20200515-221257
base:    c9529331c7a22b8eb7eb03e1e0e221d0f58b43de
config: x86_64-rhel-7.6-kselftests (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

>> drivers/thermal/thermal_netlink.c:69:5: warning: no previous prototype for 'thermal_genl_sampling_temp' [-Wmissing-prototypes]
int thermal_genl_sampling_temp(int id, int temp)
^~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/thermal/thermal_netlink.c:509:5: warning: no previous prototype for 'thermal_genl_cmd_dumpit' [-Wmissing-prototypes]
int thermal_genl_cmd_dumpit(struct sk_buff *skb, struct netlink_callback *cb)
^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/thermal/thermal_netlink.c:535:5: warning: no previous prototype for 'thermal_genl_cmd_doit' [-Wmissing-prototypes]
int thermal_genl_cmd_doit(struct sk_buff *skb, struct genl_info *info)
^~~~~~~~~~~~~~~~~~~~~

vim +/thermal_genl_sampling_temp +69 drivers/thermal/thermal_netlink.c

    68	
  > 69	int thermal_genl_sampling_temp(int id, int temp)
    70	{
    71		struct sk_buff *skb;
    72		void *hdr;
    73	
    74		skb = genlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL);
    75		if (!skb)
    76			return -ENOMEM;
    77	
    78		hdr = genlmsg_put(skb, 0, 0, &thermal_gnl_family, 0,
    79				  THERMAL_GENL_SAMPLING_TEMP);
    80		if (!hdr)
    81			return -EMSGSIZE;
    82	
    83		if (nla_put_u32(skb, THERMAL_GENL_ATTR_TZ_ID, id))
    84			goto out_cancel;
    85	
    86		if (nla_put_u32(skb, THERMAL_GENL_ATTR_TZ_TEMP, temp))
    87			goto out_cancel;
    88	
    89		genlmsg_end(skb, hdr);
    90	
    91		genlmsg_multicast(&thermal_gnl_family, skb, 0, 0, GFP_KERNEL);
    92	
    93		return 0;
    94	out_cancel:
    95		genlmsg_cancel(skb, hdr);
    96		nlmsg_free(skb);
    97	
    98		return -EMSGSIZE;
    99	}
   100	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 49901 bytes --]

Re: [PATCH 4/4] thermal: core: genetlink support for events/cmd/sampling

[Ram Chandrasekar]

On 5/15/2020 8:10 AM, Daniel Lezcano wrote:
> Initially the thermal framework had a very simple notification
> mechanism to send generic netlink messages to the userspace.
> 
> The notification function was never called from anywhere and the
> corresponding dead code was removed. It was probably a first attempt
> to introduce the netlink notification.
> 
> At LPC2018, the presentation "Linux thermal: User kernel interface",
> proposed to create the notifications to the userspace via a kfifo.
> 
> The advantage of the kfifo is the performance. It is usually used from
> a 1:1 communication channel where a driver captures data and send them
> as fast as possible to an userspace process.
>  > The inconvenient is the process uses the notification channel
> exclusively, thus no other process is allowed to use the channel to
> get temperature or notifications.
> 

kfifo being 1 to 1 communication will definitely be a limitation. In 
android subsystem, we have minimum two daemons in the userspace which 
will be interested in knowing these information sent using notification.

One daemon will be interested in getting a trip and temperature 
notification to carry out mitigation action. This is similar to thermald.

Other daemon is mostly for broadcasting Android HAL clients when the 
temperature or the cooling device value changes. This daemon will also 
be interested in knowing when the trip threshold reaches to notify 
clients, but wont mitigate.

Having a netlink, will make these daemons independent of each other and 
just rely on the messages being sent from kernel.

> The purpose of this series is to provide a fully netlink featured
> thermal management.
> 
> This patch is defining a generic netlink API to discover the current
> thermal setup, get events and temperature sampling. As any genetlink
> protocol, it can evolve and the versionning allows to keep the backward
> compatibility.
> 
> In order to not flood the user with a single channel data, there are
> two multicast channels, one for the temperature sampling when the
> thermal zone is updated and another one for the events, so the user
> can get the events only without the thermal zone temperature
> sampling. All these events are from the ones presented at the LPC2018.
> 
> Also, a list of commands to discover the thermal setup is given and
> can be extended on purpose.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
>   drivers/thermal/Makefile          |   2 +-
>   drivers/thermal/thermal_core.h    |  13 +
>   drivers/thermal/thermal_netlink.c | 612 ++++++++++++++++++++++++++++++
>   include/linux/thermal.h           |  12 -
>   include/uapi/linux/thermal.h      |  80 +++-
>   5 files changed, 699 insertions(+), 20 deletions(-)
>   create mode 100644 drivers/thermal/thermal_netlink.c
> 
> diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile
> index 8c8ed7b79915..80fddb02cb32 100644
> --- a/drivers/thermal/Makefile
> +++ b/drivers/thermal/Makefile
> @@ -5,7 +5,7 @@
>   
>   obj-$(CONFIG_THERMAL)		+= thermal_sys.o
>   thermal_sys-y			+= thermal_core.o thermal_sysfs.o \
> -					thermal_helpers.o
> +					thermal_helpers.o thermal_netlink.o
>   
>   # interface to/from other layers providing sensors
>   thermal_sys-$(CONFIG_THERMAL_HWMON)		+= thermal_hwmon.o
> diff --git a/drivers/thermal/thermal_core.h b/drivers/thermal/thermal_core.h
> index 7e8f45db6bbf..4c98d398c301 100644
> --- a/drivers/thermal/thermal_core.h
> +++ b/drivers/thermal/thermal_core.h
> @@ -52,6 +52,19 @@ int for_each_thermal_governor(int (*cb)(struct thermal_governor *, void *),
>   
>   struct thermal_zone_device *thermal_zone_get_by_id(int id);
>   
> +/* Netlink notification function */
> +int thermal_notify_tz_create(int tz_id, const char *name);
> +int thermal_notify_tz_delete(int tz_id);
> +int thermal_notify_tz_enable(int tz_id);
> +int thermal_notify_tz_disable(int tz_id);
> +int thermal_notify_tz_trip_low(int tz_id, int id);
> +int thermal_notify_tz_trip_high(int tz_id, int id);
> +int thermal_notify_tz_trip_delete(int tz_id, int id);
> +int thermal_notify_tz_trip_add(int tz_id, int id, int type,
> +			       int temp, int hyst);
> +int thermal_notify_tz_trip_change(int tz_id, int id, int type,
> +				  int temp, int hyst);
> +
>   struct thermal_attr {
>   	struct device_attribute attr;
>   	char name[THERMAL_NAME_LENGTH];
> diff --git a/drivers/thermal/thermal_netlink.c b/drivers/thermal/thermal_netlink.c
> new file mode 100644
> index 000000000000..a2bce846771e
> --- /dev/null
> +++ b/drivers/thermal/thermal_netlink.c
> @@ -0,0 +1,612 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright 2020 Linaro Limited
> + *
> + * Author: Daniel Lezcano <daniel.lezcano@linaro.org>
> + *
> + * Generic netlink for thermal management framework
> + */
> +#include <linux/module.h>
> +#include <linux/kernel.h>
> +#include <net/genetlink.h>
> +#include <uapi/linux/thermal.h>
> +
> +#include "thermal_core.h"
> +
> +static const struct genl_multicast_group thermal_genl_mcgrps[] = {
> +	{ .name = THERMAL_GENL_SAMPLING_GROUP_NAME, },
> +	{ .name = THERMAL_GENL_EVENT_GROUP_NAME,  },
> +};
> +
> +static const struct nla_policy thermal_genl_policy[THERMAL_GENL_ATTR_MAX + 1] = {
> +	/* Thermal zone */
> +	[THERMAL_GENL_ATTR_TZ]			= { .type = NLA_NESTED },
> +	[THERMAL_GENL_ATTR_TZ_ID]		= { .type = NLA_U32 },
> +	[THERMAL_GENL_ATTR_TZ_TEMP]		= { .type = NLA_U32 },
> +	[THERMAL_GENL_ATTR_TZ_TRIP]		= { .type = NLA_NESTED },
> +	[THERMAL_GENL_ATTR_TZ_TRIP_ID]		= { .type = NLA_U32 },
> +	[THERMAL_GENL_ATTR_TZ_TRIP_TEMP]	= { .type = NLA_U32 },
> +	[THERMAL_GENL_ATTR_TZ_TRIP_TYPE]	= { .type = NLA_U32 },
> +	[THERMAL_GENL_ATTR_TZ_TRIP_HYST]	= { .type = NLA_U32 },
> +	[THERMAL_GENL_ATTR_TZ_MODE]		= { .type = NLA_U32 },
> +	[THERMAL_GENL_ATTR_TZ_CDEV_WEIGHT]	= { .type = NLA_U32 },
> +	[THERMAL_GENL_ATTR_TZ_NAME]		= { .type = NLA_STRING,
> +						    .len = THERMAL_NAME_LENGTH },
> +	/* Governor(s) */
> +	[THERMAL_GENL_ATTR_TZ_GOV]		= { .type = NLA_NESTED },
> +	[THERMAL_GENL_ATTR_TZ_GOV_NAME]		= { .type = NLA_STRING,
> +						    .len = THERMAL_NAME_LENGTH },
> +	/* Cooling devices */
> +	[THERMAL_GENL_ATTR_CDEV]		= { .type = NLA_NESTED },
> +	[THERMAL_GENL_ATTR_CDEV_ID]		= { .type = NLA_U32 },
> +	[THERMAL_GENL_ATTR_CDEV_CUR_STATE]	= { .type = NLA_U32 },
> +	[THERMAL_GENL_ATTR_CDEV_MAX_STATE]	= { .type = NLA_U32 },
> +	[THERMAL_GENL_ATTR_CDEV_MIN_STATE]	= { .type = NLA_U32 },
> +	[THERMAL_GENL_ATTR_CDEV_NAME]		= { .type = NLA_STRING,
> +						    .len = THERMAL_NAME_LENGTH },
> +};
> +
> +struct param {
> +	struct nlattr ** attrs;
> +	struct sk_buff *msg;
> +	const char *name;
> +	int tz_id;
> +	int id;
> +	int temp;
> +	int type;
> +	int hyst;
> +	int state;
> +	int min_state;
> +	int max_state;
> +};
> +
> +typedef int (*cb_t)(struct param *);
> +
> +static struct genl_family thermal_gnl_family;
> +
> +/************************** Sampling encoding *******************************/
> +
> +int thermal_genl_sampling_temp(int id, int temp)
> +{
> +	struct sk_buff *skb;
> +	void *hdr;
> +
> +	skb = genlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL);
> +	if (!skb)
> +		return -ENOMEM;
> +
> +	hdr = genlmsg_put(skb, 0, 0, &thermal_gnl_family, 0,
> +			  THERMAL_GENL_SAMPLING_TEMP);
> +	if (!hdr)
> +		return -EMSGSIZE;
> +
> +	if (nla_put_u32(skb, THERMAL_GENL_ATTR_TZ_ID, id))
> +		goto out_cancel;
> +
> +	if (nla_put_u32(skb, THERMAL_GENL_ATTR_TZ_TEMP, temp))
> +		goto out_cancel;
> +
> +	genlmsg_end(skb, hdr);
> +
> +	genlmsg_multicast(&thermal_gnl_family, skb, 0, 0, GFP_KERNEL);
> +
> +	return 0;
> +out_cancel:
> +	genlmsg_cancel(skb, hdr);
> +	nlmsg_free(skb);
> +
> +	return -EMSGSIZE;
> +}
> +
> +/**************************** Event encoding *********************************/
> +
> +static int thermal_genl_event_tz_create(struct param *p)
> +{
> +	if (nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_ID, p->tz_id) ||
> +	    nla_put_string(p->msg, THERMAL_GENL_ATTR_TZ_NAME, p->name))
> +		return -EMSGSIZE;
> +
> +	return 0;
> +}
> +
> +static int thermal_genl_event_tz(struct param *p)
> +{
> +	if (nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_ID, p->tz_id))
> +		return -EMSGSIZE;
> +
> +	return 0;
> +}
> +
> +static int thermal_genl_event_tz_trip_high(struct param *p)
> +{
> +	if (nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_ID, p->tz_id) ||
> +	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_TRIP_ID, p->id))
> +		return -EMSGSIZE;
> +
> +	return 0;
> +}
> +
> +static int thermal_genl_event_tz_trip_add(struct param *p)
> +{
> +	if (nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_ID, p->tz_id) ||
> +	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_TRIP_ID, p->id) ||
> +	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_TRIP_TYPE, p->type) ||
> +	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_TRIP_TEMP, p->temp) ||
> +	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_TRIP_HYST, p->hyst))
> +		return -EMSGSIZE;
> +
> +	return 0;
> +}
> +
> +static int thermal_genl_event_tz_trip_delete(struct param *p)
> +{
> +	if (nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_ID, p->tz_id) ||
> +	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_TZ_TRIP_ID, p->id))
> +		return -EMSGSIZE;
> +
> +	return 0;
> +}
> +
> +static int thermal_genl_event_cdev_add(struct param *p)
> +{
> +	if (nla_put_string(p->msg, THERMAL_GENL_ATTR_CDEV_NAME,
> +			   p->name) ||
> +	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_CDEV_ID,
> +			p->id) ||
> +	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_CDEV_MIN_STATE,
> +			p->min_state) ||
> +	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_CDEV_MAX_STATE,
> +			p->max_state))
> +		return -EMSGSIZE;
> +
> +	return 0;
> +}
> +
> +static int thermal_genl_event_cdev_delete(struct param *p)
> +{
> +	if (nla_put_u32(p->msg, THERMAL_GENL_ATTR_CDEV_ID, p->id))
> +		return -EMSGSIZE;
> +
> +	return 0;
> +}
> +
> +static int thermal_genl_event_cdev_update(struct param *p)
> +{
> +	if (nla_put_u32(p->msg, THERMAL_GENL_ATTR_CDEV_ID, p->id) ||
> +	    nla_put_u32(p->msg, THERMAL_GENL_ATTR_CDEV_CUR_STATE, p->state))
> +		return -EMSGSIZE;
> +
> +	return 0;
> +}
> +
> +static int thermal_genl_event_gov_change(struct param *p)
> +{
> +	if (nla_put_u32(p->msg, THERMAL_GENL_ATTR_CDEV_ID, p->id) ||
> +	    nla_put_string(p->msg, THERMAL_GENL_ATTR_GOV_NAME, p->name))
> +		return -EMSGSIZE;
> +
> +	return 0;
> +}
> +
> +int thermal_genl_event_tz_delete(struct param *p)
> +	__attribute__((alias("thermal_genl_event_tz")));
> +
> +int thermal_genl_event_tz_enable(struct param *p)
> +	__attribute__((alias("thermal_genl_event_tz")));
> +
> +int thermal_genl_event_tz_disable(struct param *p)
> +	__attribute__((alias("thermal_genl_event_tz")));
> +
> +int thermal_genl_event_tz_trip_low(struct param *p)
> +	__attribute__((alias("thermal_genl_event_tz_trip_high")));
> +
> +int thermal_genl_event_tz_trip_change(struct param *)
> +	__attribute__((alias("thermal_genl_event_tz_trip_add")));
> +
> +static cb_t event_cb[] = {
> +	[THERMAL_GENL_EVENT_TZ_CREATE]		= thermal_genl_event_tz_create,
> +	[THERMAL_GENL_EVENT_TZ_DELETE]		= thermal_genl_event_tz_delete,
> +	[THERMAL_GENL_EVENT_TZ_ENABLE]		= thermal_genl_event_tz_enable,
> +	[THERMAL_GENL_EVENT_TZ_DISABLE]		= thermal_genl_event_tz_disable,
> +	[THERMAL_GENL_EVENT_TZ_TRIP_HIGH]	= thermal_genl_event_tz_trip_high,
> +	[THERMAL_GENL_EVENT_TZ_TRIP_LOW]	= thermal_genl_event_tz_trip_low,
> +	[THERMAL_GENL_EVENT_TZ_TRIP_CHANGE]	= thermal_genl_event_tz_trip_change,
> +	[THERMAL_GENL_EVENT_TZ_TRIP_ADD]	= thermal_genl_event_tz_trip_add,
> +	[THERMAL_GENL_EVENT_TZ_TRIP_DELETE]	= thermal_genl_event_tz_trip_delete,
> +	[THERMAL_GENL_EVENT_TZ_CDEV_ADD]	= thermal_genl_event_cdev_add,
> +	[THERMAL_GENL_EVENT_TZ_CDEV_DELETE]	= thermal_genl_event_cdev_delete,
> +	[THERMAL_GENL_EVENT_TZ_CDEV_UPDATE]	= thermal_genl_event_cdev_update,
> +	[THERMAL_GENL_EVENT_TZ_GOV_CHANGE]	= thermal_genl_event_gov_change,
> +};
> +
> +/*
> + * Generic netlink event encoding
> + */
> +static int thermal_genl_send_event(enum thermal_genl_event event,
> +				   struct param *p)
> +{
> +	struct sk_buff *msg;
> +	int ret = -EMSGSIZE;
> +	void *hdr;
> +
> +        msg = genlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL);
> +	if (!msg)
> +		return -ENOMEM;
> +	p->msg = msg;
> +
> +	hdr = genlmsg_put(msg, 0, 0, &thermal_gnl_family, 0, event);
> +	if (!hdr)
> +		goto out_free_msg;
> +
> +	ret = event_cb[event](p);
> +	if (ret)
> +		goto out_cancel_msg;
> +
> +	genlmsg_end(msg, hdr);
> +
> +	genlmsg_multicast(&thermal_gnl_family, msg, 0, 1, GFP_KERNEL);
> +
> +	return 0;
> +
> +out_cancel_msg:
> +	genlmsg_cancel(msg, hdr);
> +out_free_msg:
> +	nlmsg_free(msg);
> +
> +	return ret;
> +}
> +
> +int thermal_notify_tz_create(int tz_id, const char *name)
> +{
> +	struct param p = { .tz_id = tz_id, .name = name };
> +
> +	return 	thermal_genl_send_event(THERMAL_GENL_EVENT_TZ_CREATE, &p);
> +}
> +
> +int thermal_notify_tz_delete(int tz_id)
> +{
> +	struct param p = { .tz_id = tz_id };
> +
> +	return 	thermal_genl_send_event(THERMAL_GENL_EVENT_TZ_DELETE, &p);
> +}
> +
> +int thermal_notify_tz_enable(int tz_id)
> +{
> +	struct param p = { .tz_id = tz_id };
> +
> +	return 	thermal_genl_send_event(THERMAL_GENL_EVENT_TZ_ENABLE, &p);
> +}
> +
> +int thermal_notify_tz_disable(int tz_id)
> +{
> +	struct param p = { .tz_id = tz_id };
> +
> +	return 	thermal_genl_send_event(THERMAL_GENL_EVENT_TZ_DISABLE, &p);
> +}
> +
> +int thermal_notify_tz_trip_low(int tz_id, int id)
> +{
> +	struct param p = { .tz_id = tz_id, .id = id };
> +
> +	return 	thermal_genl_send_event(THERMAL_GENL_EVENT_TZ_TRIP_LOW, &p);
> +}
> +
> +int thermal_notify_tz_trip_high(int tz_id, int id)
> +{
> +	struct param p = { .tz_id = tz_id, .id = id };
> +
> +	return 	thermal_genl_send_event(THERMAL_GENL_EVENT_TZ_TRIP_HIGH, &p);
> +}
> +
> +int thermal_notify_tz_trip_add(int tz_id, int id, int type, int temp, int hyst)
> +{
> +	struct param p = { .tz_id = tz_id, .id = id, .type = type,
> +			   .temp = temp, .hyst = hyst };
> +
> +	return 	thermal_genl_send_event(THERMAL_GENL_EVENT_TZ_TRIP_ADD, &p);
> +}
> +
> +int thermal_notify_tz_trip_delete(int tz_id, int id)
> +{
> +	struct param p = { .tz_id = tz_id, .id = id };
> +
> +	return 	thermal_genl_send_event(THERMAL_GENL_EVENT_TZ_TRIP_DELETE, &p);
> +}
> +
> +int thermal_notify_tz_trip_change(int tz_id, int id, int type, int temp, int hyst)
> +{
> +	struct param p = { .tz_id = tz_id, .id = id, .type = type,
> +			   .temp = temp, .hyst = hyst };
> +
> +	return 	thermal_genl_send_event(THERMAL_GENL_EVENT_TZ_TRIP_CHANGE, &p);
> +}
> +
> +/*************************** Command encoding ********************************/
> +
> +static int __thermal_genl_cmd_tz_get(struct thermal_zone_device *tz, void *data)
> +{
> +	struct sk_buff *msg = data;
> +
> +	if (nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_ID, tz->id) ||
> +	    nla_put_string(msg, THERMAL_GENL_ATTR_TZ_NAME, tz->type))
> +		return -EMSGSIZE;
> +
> +	return 0;
> +}
> +
> +static int thermal_genl_cmd_tz_get(struct param *p)
> +{
> +	struct sk_buff *msg = p->msg;
> +	struct nlattr *start_tz;
> +	int ret;
> +
> +	start_tz = nla_nest_start(msg, THERMAL_GENL_ATTR_TZ);
> +	if (!start_tz)
> +		return -EMSGSIZE;
> +
> +	ret = for_each_thermal_zone(__thermal_genl_cmd_tz_get, msg);
> +	if (ret)
> +		goto out_cancel_nest;
> +
> +	nla_nest_end(msg, start_tz);
> +
> +	return 0;
> +
> +out_cancel_nest:
> +	nla_nest_cancel(msg, start_tz);
> +
> +	return ret;
> +}
> +
> +static int thermal_genl_cmd_tz_get_trip(struct param *p)
> +{
> +	struct sk_buff *msg = p->msg;
> +	struct thermal_zone_device *tz;
> +	struct nlattr *start_trip;
> +	int i, id;
> +
> +	if (!p->attrs[THERMAL_GENL_ATTR_TZ_ID])
> +		return -EINVAL;
> +
> +	id = nla_get_u32(p->attrs[THERMAL_GENL_ATTR_TZ_ID]);
> +
> +	tz = thermal_zone_get_by_id(id);
> +	if (!tz)
> +		return -EINVAL;
> +
> +	start_trip = nla_nest_start(msg, THERMAL_GENL_ATTR_TZ_TRIP);
> +	if (!start_trip)
> +		return -EMSGSIZE;
> +
> +	mutex_lock(&tz->lock);
> +
> +	for (i = 0; i < tz->trips; i++) {
> +
> +		enum thermal_trip_type type;
> +		int temp, hyst;
> +
> +		tz->ops->get_trip_type(tz, i, &type);
> +		tz->ops->get_trip_temp(tz, i, &temp);
> +		tz->ops->get_trip_hyst(tz, i, &hyst);
> +
> +		if (nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_TRIP_ID, i) ||
> +		    nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_TRIP_TYPE, type) ||
> +		    nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_TRIP_TEMP, temp) ||
> +		    nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_TRIP_HYST, hyst))
> +			goto out_cancel_nest;
> +	}
> +
> +	mutex_unlock(&tz->lock);
> +
> +	nla_nest_end(msg, start_trip);
> +
> +	return 0;
> +
> +out_cancel_nest:
> +	mutex_unlock(&tz->lock);
> +
> +	return -EMSGSIZE;
> +}
> +
> +static int thermal_genl_cmd_tz_get_temp(struct param *p)
> +{
> +	struct sk_buff *msg = p->msg;
> +	struct thermal_zone_device *tz;
> +	int temp, ret, id;
> +
> +	if (!p->attrs[THERMAL_GENL_ATTR_TZ_ID])
> +		return -EINVAL;
> +
> +	id = nla_get_u32(p->attrs[THERMAL_GENL_ATTR_TZ_ID]);
> +
> +	tz = thermal_zone_get_by_id(id);
> +	if (!tz)
> +		return -EINVAL;
> +
> +	ret = thermal_zone_get_temp(tz, &temp);
> +	if (ret)
> +		return ret;
> +
> +	if (nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_ID, id) ||
> +	    nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_TEMP, temp))
> +		return -EMSGSIZE;
> +
> +	return 0;
> +}
> +
> +static int thermal_genl_cmd_tz_get_gov(struct param *p)
> +{
> +	struct sk_buff *msg = p->msg;
> +	struct thermal_zone_device *tz;
> +	int id, ret = 0;
> +
> +	if (!p->attrs[THERMAL_GENL_ATTR_TZ_ID])
> +		return -EINVAL;
> +
> +	id = nla_get_u32(p->attrs[THERMAL_GENL_ATTR_TZ_ID]);
> +
> +	tz = thermal_zone_get_by_id(id);
> +	if (!tz)
> +		return -EINVAL;
> +
> +	mutex_lock(&tz->lock);
> +
> +	if (nla_put_u32(msg, THERMAL_GENL_ATTR_TZ_ID, id) ||
> +	    nla_put_string(msg, THERMAL_GENL_ATTR_TZ_GOV_NAME,
> +			   tz->governor->name))
> +		ret = -EMSGSIZE;
> +
> +	mutex_unlock(&tz->lock);
> +
> +	return ret;
> +}
> +
> +static int __thermal_genl_cmd_cdev_get(struct thermal_cooling_device *cdev,
> +				       void *data)
> +{
> +	struct sk_buff *msg = data;
> +
> +	if (nla_put_u32(msg, THERMAL_GENL_ATTR_CDEV_ID, cdev->id))
> +		return -EMSGSIZE;
> +
> +	if (nla_put_string(msg, THERMAL_GENL_ATTR_CDEV_NAME, cdev->type))
> +		return -EMSGSIZE;
> +
> +	return 0;
> +}
> +
> +static int thermal_genl_cmd_cdev_get(struct param *p)
> +{
> +	struct sk_buff *msg = p->msg;
> +	struct nlattr *start_cdev;
> +	int ret;
> +
> +	start_cdev = nla_nest_start(msg, THERMAL_GENL_ATTR_CDEV);
> +	if (!start_cdev)
> +		return -EMSGSIZE;
> +
> +	ret = for_each_thermal_cooling_device(__thermal_genl_cmd_cdev_get, msg);
> +	if (ret)
> +		goto out_cancel_nest;
> +
> +	nla_nest_end(msg, start_cdev);
> +
> +	return 0;
> +out_cancel_nest:
> +	nla_nest_cancel(msg, start_cdev);
> +
> +	return ret;
> +}
> +
> +static cb_t cmd_cb[] = {
> +	[THERMAL_GENL_CMD_TZ_GET]	= thermal_genl_cmd_tz_get,
> +	[THERMAL_GENL_CMD_TZ_GET_TRIP]	= thermal_genl_cmd_tz_get_trip,
> +	[THERMAL_GENL_CMD_TZ_GET_TEMP]	= thermal_genl_cmd_tz_get_temp,
> +	[THERMAL_GENL_CMD_TZ_GET_GOV]	= thermal_genl_cmd_tz_get_gov,
> +	[THERMAL_GENL_CMD_CDEV_GET]	= thermal_genl_cmd_cdev_get,
> +};
> +
> +int thermal_genl_cmd_dumpit(struct sk_buff *skb, struct netlink_callback *cb)
> +{
> +	struct param p = { .msg = skb };
> +	const struct genl_dumpit_info *info = genl_dumpit_info(cb);
> +	int cmd = info->ops->cmd;
> +	int ret = -EMSGSIZE;
> +	void *hdr;
> +
> +	hdr = genlmsg_put(skb, 0, 0, &thermal_gnl_family, 0, cmd);
> +	if (!hdr)
> +		return -EMSGSIZE;
> +
> +	ret = cmd_cb[cmd](&p);
> +	if (ret)
> +		goto out_cancel_msg;
> +
> +	genlmsg_end(skb, hdr);
> +
> +	return 0;
> +
> +out_cancel_msg:
> +	genlmsg_cancel(skb, hdr);
> +
> +	return ret;
> +}
> +
> +int thermal_genl_cmd_doit(struct sk_buff *skb, struct genl_info *info)
> +{
> +	struct param p = { .attrs = info->attrs };
> +	struct sk_buff *msg;
> +	void *hdr;
> +	int cmd = info->genlhdr->cmd;
> +	int ret = -EMSGSIZE;
> +
> +        msg = genlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL);
> +	if (!msg)
> +		return -ENOMEM;
> +	p.msg = msg;
> +
> +        hdr = genlmsg_put_reply(msg, info, &thermal_gnl_family, 0, cmd);
> +	if (!hdr)
> +		goto out_free_msg;
> +
> +	ret = cmd_cb[cmd](&p);
> +	if (ret)
> +		goto out_cancel_msg;
> +
> +	genlmsg_end(msg, hdr);
> +
> +	return genlmsg_reply(msg, info);
> +
> +out_cancel_msg:
> +	genlmsg_cancel(msg, hdr);
> +out_free_msg:
> +	nlmsg_free(msg);
> +
> +	return ret;
> +}
> +
> +static const struct genl_ops thermal_genl_ops[] = {
> +	{
> +		.cmd = THERMAL_GENL_CMD_TZ_GET,
> +		.validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,
> +		.dumpit = thermal_genl_cmd_dumpit,
> +	},
> +	{
> +		.cmd = THERMAL_GENL_CMD_TZ_GET_TRIP,
> +		.validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,
> +		.doit = thermal_genl_cmd_doit,
> +	},
> +	{
> +		.cmd = THERMAL_GENL_CMD_TZ_GET_TEMP,
> +		.validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,
> +		.doit = thermal_genl_cmd_doit,
> +	},
> +	{
> +		.cmd = THERMAL_GENL_CMD_TZ_GET_GOV,
> +		.validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,
> +		.doit = thermal_genl_cmd_doit,
> +	},
> +	{
> +		.cmd = THERMAL_GENL_CMD_CDEV_GET,
> +		.validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,
> +		.dumpit = thermal_genl_cmd_dumpit,
> +	},
> +};
> +
> +static struct genl_family thermal_gnl_family __ro_after_init = {
> +	.hdrsize	= 0,
> +	.name		= THERMAL_GENL_FAMILY_NAME,
> +	.version	= THERMAL_GENL_VERSION,
> +	.maxattr	= THERMAL_GENL_ATTR_MAX,
> +	.policy		= thermal_genl_policy,
> +	.ops		= thermal_genl_ops,
> +	.n_ops 		= ARRAY_SIZE(thermal_genl_ops),
> +	.mcgrps		= thermal_genl_mcgrps,
> +	.n_mcgrps	= ARRAY_SIZE(thermal_genl_mcgrps),
> +};
> +
> +static int __init thermal_netlink_init(void)
> +{
> +	return genl_register_family(&thermal_gnl_family);
> +}
> +core_initcall(thermal_netlink_init);
> diff --git a/include/linux/thermal.h b/include/linux/thermal.h
> index fc93a6348082..d92643e310e2 100644
> --- a/include/linux/thermal.h
> +++ b/include/linux/thermal.h
> @@ -37,18 +37,6 @@ struct thermal_cooling_device;
>   struct thermal_instance;
>   struct thermal_attr;
>   
> -enum thermal_device_mode {
> -	THERMAL_DEVICE_DISABLED = 0,
> -	THERMAL_DEVICE_ENABLED,
> -};
> -
> -enum thermal_trip_type {
> -	THERMAL_TRIP_ACTIVE = 0,
> -	THERMAL_TRIP_PASSIVE,
> -	THERMAL_TRIP_HOT,
> -	THERMAL_TRIP_CRITICAL,
> -};
> -
>   enum thermal_trend {
>   	THERMAL_TREND_STABLE, /* temperature is stable */
>   	THERMAL_TREND_RAISING, /* temperature is raising */
> diff --git a/include/uapi/linux/thermal.h b/include/uapi/linux/thermal.h
> index 22df67ed9e9c..3ee7515c7aea 100644
> --- a/include/uapi/linux/thermal.h
> +++ b/include/uapi/linux/thermal.h
> @@ -4,21 +4,87 @@
>   
>   #define THERMAL_NAME_LENGTH	20
>   
> +enum thermal_device_mode {
> +	THERMAL_DEVICE_DISABLED = 0,
> +	THERMAL_DEVICE_ENABLED,
> +};
> +
> +enum thermal_trip_type {
> +	THERMAL_TRIP_ACTIVE = 0,
> +	THERMAL_TRIP_PASSIVE,
> +	THERMAL_TRIP_HOT,
> +	THERMAL_TRIP_CRITICAL,
> +};
> +
>   /* Adding event notification support elements */
> -#define THERMAL_GENL_FAMILY_NAME                "thermal_event"
> -#define THERMAL_GENL_VERSION                    0x02
> -#define THERMAL_GENL_MCAST_GROUP_NAME           "thermal_mc_grp"
> +#define THERMAL_GENL_FAMILY_NAME		"thermal"
> +#define THERMAL_GENL_VERSION			0x01
> +#define THERMAL_GENL_SAMPLING_GROUP_NAME	"sampling"
> +#define THERMAL_GENL_EVENT_GROUP_NAME		"event"
>   
> -/* attributes of thermal_genl_family */
> -enum {
> +/* Attributes of thermal_genl_family */
> +enum thermal_genl_attr {
>   	THERMAL_GENL_ATTR_UNSPEC,
> +	THERMAL_GENL_ATTR_TZ,
> +	THERMAL_GENL_ATTR_TZ_ID,
> +	THERMAL_GENL_ATTR_TZ_TEMP,
> +	THERMAL_GENL_ATTR_TZ_TRIP,
> +	THERMAL_GENL_ATTR_TZ_TRIP_ID,
> +	THERMAL_GENL_ATTR_TZ_TRIP_TYPE,
> +	THERMAL_GENL_ATTR_TZ_TRIP_TEMP,
> +	THERMAL_GENL_ATTR_TZ_TRIP_HYST,
> +	THERMAL_GENL_ATTR_TZ_MODE,
> +	THERMAL_GENL_ATTR_TZ_NAME,
> +	THERMAL_GENL_ATTR_TZ_CDEV_WEIGHT,
> +	THERMAL_GENL_ATTR_TZ_GOV,
> +	THERMAL_GENL_ATTR_TZ_GOV_NAME,
> +	THERMAL_GENL_ATTR_CDEV,
> +	THERMAL_GENL_ATTR_CDEV_ID,
> +	THERMAL_GENL_ATTR_CDEV_CUR_STATE,
> +	THERMAL_GENL_ATTR_CDEV_MAX_STATE,
> +	THERMAL_GENL_ATTR_CDEV_MIN_STATE,
> +	THERMAL_GENL_ATTR_CDEV_NAME,
> +	THERMAL_GENL_ATTR_GOV_NAME,
> +
>   	__THERMAL_GENL_ATTR_MAX,
>   };
>   #define THERMAL_GENL_ATTR_MAX (__THERMAL_GENL_ATTR_MAX - 1)
>   
> -/* commands supported by the thermal_genl_family */
> -enum {
> +enum thermal_genl_sampling {
> +	THERMAL_GENL_SAMPLING_TEMP,
> +	__THERMAL_GENL_SAMPLING_MAX,
> +};
> +#define THERMAL_GENL_SAMPLING_MAX (__THERMAL_GENL_SAMPLING_MAX - 1)
> +
> +/* Events of thermal_genl_family */
> +enum thermal_genl_event {
> +	THERMAL_GENL_EVENT_UNSPEC,
> +	THERMAL_GENL_EVENT_TZ_CREATE,		/* Thermal zone creation */
> +	THERMAL_GENL_EVENT_TZ_DELETE,		/* Thermal zone deletion */
> +	THERMAL_GENL_EVENT_TZ_DISABLE,		/* Thermal zone disabed */
> +	THERMAL_GENL_EVENT_TZ_ENABLE,		/* Thermal zone enabled */
> +	THERMAL_GENL_EVENT_TZ_TRIP_HIGH,	/* Trip point crossed the way up */
> +	THERMAL_GENL_EVENT_TZ_TRIP_LOW,		/* Trip point crossed the way down */
> +	THERMAL_GENL_EVENT_TZ_TRIP_CHANGE,	/* Trip point changed */
> +	THERMAL_GENL_EVENT_TZ_TRIP_ADD,		/* Trip point added */
> +	THERMAL_GENL_EVENT_TZ_TRIP_DELETE,	/* Trip point deleted */
> +	THERMAL_GENL_EVENT_TZ_CDEV_ADD,		/* Cdev bound to the thermal zone */
> +	THERMAL_GENL_EVENT_TZ_CDEV_DELETE,	/* Cdev unbound */
> +	THERMAL_GENL_EVENT_TZ_CDEV_UPDATE,	/* Cdev state updated */
> +	THERMAL_GENL_EVENT_TZ_GOV_CHANGE,	/* Governor policy changed  */
> +	__THERMAL_GENL_EVENT_MAX,
> +};
> +#define THERMAL_GENL_EVENT_MAX (__THERMAL_GENL_EVENT_MAX - 1)
> +
> +/* Commands supported by the thermal_genl_family */
> +enum thermal_genl_cmd {
>   	THERMAL_GENL_CMD_UNSPEC,
> +	THERMAL_GENL_CMD_TZ_GET,	/* List thermal zones id */
> +	THERMAL_GENL_CMD_TZ_GET_TRIP,	/* List of thermal trips */
> +	THERMAL_GENL_CMD_TZ_GET_TEMP,	/* Get the thermal zone temperature */
> +	THERMAL_GENL_CMD_TZ_GET_GOV,	/* Get the thermal zone governor */
> +	THERMAL_GENL_CMD_TZ_GET_MODE,	/* Get the thermal zone mode */
> +	THERMAL_GENL_CMD_CDEV_GET,	/* List of cdev id */
>   	__THERMAL_GENL_CMD_MAX,
>   };
>   #define THERMAL_GENL_CMD_MAX (__THERMAL_GENL_CMD_MAX - 1)
>