From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Lukasz Luba <lukasz.luba@arm.com>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Cc: amitk@kernel.org, Dietmar.Eggemann@arm.com
Subject: Re: [PATCH 1/2] thermal: power allocator: change the 'k_i' coefficient estimation
Date: Tue, 13 Oct 2020 12:21:09 +0200 [thread overview]
Message-ID: <cc0e6d85-28ad-3cfc-e5b8-75820552b716@linaro.org> (raw)
In-Reply-To: <20201002122416.13659-2-lukasz.luba@arm.com>
Hi Lukasz,
On 02/10/2020 14:24, Lukasz Luba wrote:
> Intelligent Power Allocation (IPA) is built around the PID controller
> concept. The initialization code tries to setup the environment based on
> the information available in DT or estimate the value based on minimum
> power reported by each of the cooling device. The estimation will have an
> impact on the PID controller behaviour via the related 'k_po', 'k_pu',
> 'k_i' coefficients and also on the power budget calculation.
>
> This change prevents the situation when 'k_i' is relatively big compared
> to 'k_po' and 'k_pu' values. This might happen when the estimation for
> 'sustainable_power' returned small value, thus 'k_po' and 'k_pu' are
> small.
>
> Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
> ---
> drivers/thermal/gov_power_allocator.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/gov_power_allocator.c b/drivers/thermal/gov_power_allocator.c
> index 5cb518d8f156..f69fafe486a5 100644
> --- a/drivers/thermal/gov_power_allocator.c
> +++ b/drivers/thermal/gov_power_allocator.c
> @@ -131,6 +131,7 @@ static void estimate_pid_constants(struct thermal_zone_device *tz,
> int ret;
> int switch_on_temp;
> u32 temperature_threshold;
> + s32 k_i;
>
> ret = tz->ops->get_trip_temp(tz, trip_switch_on, &switch_on_temp);
> if (ret)
> @@ -156,8 +157,11 @@ static void estimate_pid_constants(struct thermal_zone_device *tz,
> tz->tzp->k_pu = int_to_frac(2 * sustainable_power) /
> temperature_threshold;
>
> - if (!tz->tzp->k_i || force)
> - tz->tzp->k_i = int_to_frac(10) / 1000;
> + if (!tz->tzp->k_i || force) {
> + k_i = tz->tzp->k_pu / 10;
> + tz->tzp->k_i = k_i > 0 ? k_i : 1;
> + }
I do not understand the rational behind this change.
Do you have some values to share describing what would be the impact of
this change?
Depending on the thermal behavior of a board, these coefficients could
be very different, no ?
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2020-10-13 10:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 12:24 [PATCH 0/2] Improve the estimations in Intelligent Power Allocation Lukasz Luba
2020-10-02 12:24 ` [PATCH 1/2] thermal: power allocator: change the 'k_i' coefficient estimation Lukasz Luba
2020-10-13 10:21 ` Daniel Lezcano [this message]
2020-10-13 10:59 ` Lukasz Luba
2020-10-13 11:22 ` Daniel Lezcano
2020-10-13 12:04 ` Lukasz Luba
2020-10-13 15:56 ` Daniel Lezcano
2020-10-02 12:24 ` [PATCH 2/2] thermal: power allocator: estimate sustainable power only once Lukasz Luba
2020-10-08 10:14 ` Ionela Voinescu
2020-10-08 12:34 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc0e6d85-28ad-3cfc-e5b8-75820552b716@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=Dietmar.Eggemann@arm.com \
--cc=amitk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).