From: David Lechner <david@lechnology.com>
To: Alex Dewar <alex.dewar90@gmail.com>
Cc: Sebastian Reichel <sre@kernel.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Sekhar Nori <nsekhar@ti.com>,
Bartosz Go??aszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH] power: supply: Add dependency to lego-ev3-battery Kconfig options
Date: Wed, 12 Aug 2020 10:24:30 -0500 [thread overview]
Message-ID: <ce0ae241-10e1-de5c-e694-2c00dc01a2c4@lechnology.com> (raw)
In-Reply-To: <20200812133711.ddwhxypmvr27pxdu@lenovo-laptop>
On 8/12/20 8:37 AM, Alex Dewar wrote:
> On Tue, Aug 11, 2020 at 09:24:10AM -0500, David Lechner wrote:
>> On 8/9/20 1:54 PM, Alex Dewar wrote:
>>> This battery appears only to be used by a single board (DA850), so it
>>> makes sense to add this to the Kconfig file so that users don't build
>>> the module unnecessarily. It currently seems to be built for the x86
>>> Arch Linux kernel where it's probably not doing much good.
>>
>> It would probably also make sense to add "default n" since it only
>> applies to one board in the entire arch.
>
> Ah ok. That makes sense. Would you like me to send a follow-on patch for
> this?
You can just send a v2 patch that includes the change below and the
additional change.
>
> Alex
>
>>
>> BATTERY_LEGO_EV3 is already explicitly set to "m" in the appropriate
>> defconfig file, so I don't think it would break anything.
>>
>>>
>>> Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
>>> ---
>>> drivers/power/supply/Kconfig | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
>>> index faf2830aa1527..9f76e2f47ac6d 100644
>>> --- a/drivers/power/supply/Kconfig
>>> +++ b/drivers/power/supply/Kconfig
>>> @@ -164,7 +164,7 @@ config BATTERY_DS2782
>>> config BATTERY_LEGO_EV3
>>> tristate "LEGO MINDSTORMS EV3 battery"
>>> - depends on OF && IIO && GPIOLIB
>>> + depends on OF && IIO && GPIOLIB && (ARCH_DAVINCI_DA850 || COMPILE_TEST)
>>> help
>>> Say Y here to enable support for the LEGO MINDSTORMS EV3 battery.
>>>
>>
next prev parent reply other threads:[~2020-08-12 15:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-09 18:54 [PATCH] power: supply: Add dependency to lego-ev3-battery Kconfig options Alex Dewar
2020-08-11 14:24 ` David Lechner
2020-08-12 13:37 ` Alex Dewar
2020-08-12 15:24 ` David Lechner [this message]
2020-08-12 19:02 ` Alex Dewar
2020-08-12 19:12 ` David Lechner
2020-08-17 17:43 ` Alex Dewar
2020-08-17 18:25 ` David Lechner
2020-08-25 13:58 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce0ae241-10e1-de5c-e694-2c00dc01a2c4@lechnology.com \
--to=david@lechnology.com \
--cc=alex.dewar90@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).