From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
Sebastian Reichel <sre@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: power: supply: Add Lenovo Yoga C630 EC
Date: Wed, 10 Aug 2022 16:35:39 +0300 [thread overview]
Message-ID: <ceb74aee-6436-f1f6-2408-fd01475cb234@linaro.org> (raw)
In-Reply-To: <20220810030500.2793882-2-bjorn.andersson@linaro.org>
On 10/08/2022 06:04, Bjorn Andersson wrote:
> Add binding for the Embedded Controller found in the Qualcomm
> Snapdragon-based Lenovo Yoga C630.
Thank you for your patch. There is something to discuss/improve.
> +
> +description:
> + The Qualcomm Snapdragon-based Lenovo Yoga C630 has an Embedded Controller
> + (EC) which handles things such as battery and USB Type-C. This binding
> + describes the interface, on an I2C bus, to this EC.
> +
> +properties:
> + compatible:
> + const: lenovo,yoga-c630-ec
> +
> + reg:
> + const: 0x70
> +
> + '#address-cells':
> + const: 1
Just to clarify: the EC have physically two USB connectors?
> +
> + '#size-cells':
> + const: 0
> +
> + interrupts:
> + maxItems: 1
> +
> +patternProperties:
> + '^connector@\d$':
> + $ref: /schemas/connector/usb-connector.yaml#
unevaluatedProperties:false inside connector (on its level)
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> + - |+
> + #include <dt-bindings/interrupt-controller/irq.h>
> + i2c1 {
> + clock-frequency = <400000>;
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + embedded-controller@70 {
> + compatible = "lenovo,yoga-c630-ec";
> + reg = <0x70>;
> +
> + interrupts-extended = <&tlmm 20 IRQ_TYPE_LEVEL_HIGH>;
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + connector@0 {
> + compatible = "usb-c-connector";
> + reg = <0>;
> + power-role = "source";
> + data-role = "host";
> + };
> +
> + connector@1 {
> + compatible = "usb-c-connector";
> + reg = <1>;
> + power-role = "source";
> + data-role = "host";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + port@1 {
> + reg = <1>;
> + lenovo_ec_dp_in: endpoint {
> + remote-endpoint = <&mdss_dp_out>;
You have inconsistent indentation. Use 4-spaces for entire DTS example.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-10 13:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 3:04 [PATCH 0/2] power: supply: Lenovo Yoga C630 EC Bjorn Andersson
2022-08-10 3:04 ` [PATCH 1/2] dt-bindings: power: supply: Add " Bjorn Andersson
2022-08-10 13:35 ` Krzysztof Kozlowski [this message]
2022-08-10 19:33 ` Bjorn Andersson
2022-08-10 15:11 ` Rob Herring
2022-08-10 3:05 ` [PATCH 2/2] power: supply: Add Lenovo Yoga C630 EC driver Bjorn Andersson
2022-09-12 17:00 ` Daniel Thompson
2022-09-13 8:17 ` Daniel Thompson
2022-09-13 10:45 ` Sebastian Reichel
2022-09-15 21:25 ` Bjorn Andersson
2022-09-15 21:53 ` Dmitry Baryshkov
2022-09-21 22:10 ` Bjorn Andersson
2022-08-10 4:04 ` [PATCH 0/2] power: supply: Lenovo Yoga C630 EC Steev Klimaszewski
2022-08-10 19:15 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ceb74aee-6436-f1f6-2408-fd01475cb234@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).