From: Joe Perches <joe@perches.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>, Jinchao Wang <wjc@cdjrlc.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>
Subject: Re: [PATCH] powercap: Replace symbolic permissions with octal permissions
Date: Wed, 30 Jun 2021 11:00:12 -0700 [thread overview]
Message-ID: <d32d67710c87e5fde488ccbf094f4fa649655a58.camel@perches.com> (raw)
In-Reply-To: <CAJZ5v0h9Nx-u0U5O1hp1-BzzKXMVd3UO5BuGH6oc95aXQeu=ag@mail.gmail.com>
On Wed, 2021-06-30 at 19:41 +0200, Rafael J. Wysocki wrote:
> On Thu, Jun 24, 2021 at 10:44 AM Jinchao Wang <wjc@cdjrlc.com> wrote:
> >
> > Resolve following checkpatch issue,
> > Replace symbolic permissions with octal permissions
>
> I don't see much value in this replacement and checkpatch complaining
> about the existing code base is not something to worry about in
> general.
https://lore.kernel.org/lkml/CA+55aFw5v23T-zvDZp-MmD_EYxF8WbafwwB59934FV7g21uMGQ@mail.gmail.com/
I do agree that in general checkpatch should not really be used as
the sole argument in favor of changing existing code.
So removing the "resolve following checkpatch issue" from the
commit message and replacing it with something like "to improve
readability" would be better.
prev parent reply other threads:[~2021-06-30 18:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 8:44 [PATCH] powercap: Replace symbolic permissions with octal permissions Jinchao Wang
2021-06-30 17:41 ` Rafael J. Wysocki
2021-06-30 18:00 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d32d67710c87e5fde488ccbf094f4fa649655a58.camel@perches.com \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=wjc@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).