From: Dan Murphy <dmurphy@ti.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>,
Sandeep Patil <sspatil@android.com>
Cc: <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kernel-team@android.com>
Subject: Re: [PATCH v4 2/4] power_supply: Add additional health properties to the header
Date: Wed, 11 Mar 2020 06:29:48 -0500 [thread overview]
Message-ID: <de919edb-79b3-82ec-f55c-31a127d6c751@ti.com> (raw)
In-Reply-To: <20200310213050.si7gcr2wbmjgr7jf@earth.universe>
Sebastian
On 3/10/20 4:30 PM, Sebastian Reichel wrote:
> Hi Sandeep,
>
> On Fri, Mar 06, 2020 at 03:55:48PM -0800, Sandeep Patil wrote:
>> On Fri, Jan 17, 2020 at 02:06:58AM +0100, Sebastian Reichel wrote:
>>> Hi,
>>>
>>> On Thu, Jan 16, 2020 at 11:50:37AM -0600, Dan Murphy wrote:
>>>> Add HEALTH_WARM, HEALTH_COOL and HEALTH_HOT to the health enum.
>>>>
>>>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>>>> ---
>>> Looks good. But I will not merge it without a user and have comments
>>> for the driver.
>> Android has been looking for these properties for a while now [1].
>> It was added[2] when we saw that the manufacturers were implementing these
>> properties in the driver. I didn't know the properties were absent upstream
>> until yesterday. Somebody pointed out in our ongoing effort to make sure
>> all core kernel changes that android depends on are present upstream.
>>
>> I think those values are also propagated in application facing APIs in
>> Android (but I am not sure yet, let me know if that's something you want
>> to find out).
>>
>> I wanted to chime in and present you a 'user' for this if that helps.
> With user I meant an upstream kernel driver, which exposes the
> values. But thanks for the pointer. This should be mentioned in
> the patch description, also the fact that the status values are
> directly taken from JEITA spec.
I mentioned the JEITA in the cover letter but I guess you would like the
description in the commit message as well
Dan
next prev parent reply other threads:[~2020-03-11 11:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 17:50 [PATCH v4 0/4] BQ25150/155 Driver introduction Dan Murphy
2020-01-16 17:50 ` [PATCH v4 1/4] power: supply: core: Update sysfs-class-power ABI document Dan Murphy
2020-01-17 1:05 ` Sebastian Reichel
2020-01-16 17:50 ` [PATCH v4 2/4] power_supply: Add additional health properties to the header Dan Murphy
2020-01-17 1:06 ` Sebastian Reichel
2020-03-06 23:55 ` Sandeep Patil
2020-03-10 20:09 ` Dan Murphy
2020-04-01 0:22 ` Sandeep Patil
2020-03-10 21:30 ` Sebastian Reichel
2020-03-11 11:29 ` Dan Murphy [this message]
2020-03-11 16:43 ` [EXTERNAL] " Ricardo Rivera-Matos
2020-03-14 4:12 ` Sandeep Patil
2020-03-03 20:33 ` Guru Das Srinagesh
2020-01-16 17:50 ` [PATCH v4 3/4] dt-bindings: power: Add the bq2515x family dt bindings Dan Murphy
2020-01-17 1:05 ` Sebastian Reichel
2020-01-16 17:50 ` [PATCH v4 4/4] power: supply: bq2515x: Introduce the bq2515x family Dan Murphy
2020-01-17 1:01 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de919edb-79b3-82ec-f55c-31a127d6c751@ti.com \
--to=dmurphy@ti.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=sspatil@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).