Linux-PM Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] thermal: bcm2835: no need to check return value of debugfs_create functions
@ 2019-06-13 18:37 Greg Kroah-Hartman
  2019-06-13 20:18 ` Daniel Lezcano
  0 siblings, 1 reply; 4+ messages in thread
From: Greg Kroah-Hartman @ 2019-06-13 18:37 UTC (permalink / raw)
  To: Zhang Rui, Eduardo Valentin, Daniel Lezcano, Florian Fainelli,
	Ray Jui, Scott Branden
  Cc: bcm-kernel-feedback-list, linux-pm

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Eduardo Valentin <edubezval@gmail.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: Ray Jui <rjui@broadcom.com>
Cc: Scott Branden <sbranden@broadcom.com>
Cc: bcm-kernel-feedback-list@broadcom.com
Cc: linux-pm@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/thermal/broadcom/bcm2835_thermal.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/thermal/broadcom/bcm2835_thermal.c b/drivers/thermal/broadcom/bcm2835_thermal.c
index ba39647a690c..3199977f1e73 100644
--- a/drivers/thermal/broadcom/bcm2835_thermal.c
+++ b/drivers/thermal/broadcom/bcm2835_thermal.c
@@ -123,8 +123,6 @@ static void bcm2835_thermal_debugfs(struct platform_device *pdev)
 	struct debugfs_regset32 *regset;
 
 	data->debugfsdir = debugfs_create_dir("bcm2835_thermal", NULL);
-	if (!data->debugfsdir)
-		return;
 
 	regset = devm_kzalloc(&pdev->dev, sizeof(*regset), GFP_KERNEL);
 	if (!regset)
-- 
2.22.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] thermal: bcm2835: no need to check return value of debugfs_create functions
  2019-06-13 18:37 [PATCH] thermal: bcm2835: no need to check return value of debugfs_create functions Greg Kroah-Hartman
@ 2019-06-13 20:18 ` Daniel Lezcano
  2019-06-14  5:05   ` Greg Kroah-Hartman
  0 siblings, 1 reply; 4+ messages in thread
From: Daniel Lezcano @ 2019-06-13 20:18 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Zhang Rui, Eduardo Valentin,
	Florian Fainelli, Ray Jui, Scott Branden
  Cc: bcm-kernel-feedback-list, linux-pm

On 13/06/2019 20:37, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value.  The function can work or not, but the code logic should
> never do something different based on this.

Sorry if I'm missing some context but does it mean we do no longer take
care of roll-backing anything? It is acceptable to have half of the
debugfs set for example? Or a parent failing to create and the children
polluting the root debugfs dir because the parent is NULL?



> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: Eduardo Valentin <edubezval@gmail.com>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Ray Jui <rjui@broadcom.com>
> Cc: Scott Branden <sbranden@broadcom.com>
> Cc: bcm-kernel-feedback-list@broadcom.com
> Cc: linux-pm@vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  drivers/thermal/broadcom/bcm2835_thermal.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/thermal/broadcom/bcm2835_thermal.c b/drivers/thermal/broadcom/bcm2835_thermal.c
> index ba39647a690c..3199977f1e73 100644
> --- a/drivers/thermal/broadcom/bcm2835_thermal.c
> +++ b/drivers/thermal/broadcom/bcm2835_thermal.c
> @@ -123,8 +123,6 @@ static void bcm2835_thermal_debugfs(struct platform_device *pdev)
>  	struct debugfs_regset32 *regset;
>  
>  	data->debugfsdir = debugfs_create_dir("bcm2835_thermal", NULL);
> -	if (!data->debugfsdir)
> -		return;
>  
>  	regset = devm_kzalloc(&pdev->dev, sizeof(*regset), GFP_KERNEL);
>  	if (!regset)
> 


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] thermal: bcm2835: no need to check return value of debugfs_create functions
  2019-06-13 20:18 ` Daniel Lezcano
@ 2019-06-14  5:05   ` Greg Kroah-Hartman
  2019-06-14  6:49     ` Daniel Lezcano
  0 siblings, 1 reply; 4+ messages in thread
From: Greg Kroah-Hartman @ 2019-06-14  5:05 UTC (permalink / raw)
  To: Daniel Lezcano
  Cc: Zhang Rui, Eduardo Valentin, Florian Fainelli, Ray Jui,
	Scott Branden, bcm-kernel-feedback-list, linux-pm

On Thu, Jun 13, 2019 at 10:18:13PM +0200, Daniel Lezcano wrote:
> On 13/06/2019 20:37, Greg Kroah-Hartman wrote:
> > When calling debugfs functions, there is no need to ever check the
> > return value.  The function can work or not, but the code logic should
> > never do something different based on this.
> 
> Sorry if I'm missing some context but does it mean we do no longer take
> care of roll-backing anything?

Yes, but how can that happen here?

> It is acceptable to have half of the debugfs set for example?

Yes, your code should never care about this.

> Or a parent failing to create and the children polluting the root
> debugfs dir because the parent is NULL?

How can the parent be NULL?  Remember, debugfs_create_dir() can never
return NULL, so that should not happen.  And even if it does, that's
fine, who cares :)

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] thermal: bcm2835: no need to check return value of debugfs_create functions
  2019-06-14  5:05   ` Greg Kroah-Hartman
@ 2019-06-14  6:49     ` Daniel Lezcano
  0 siblings, 0 replies; 4+ messages in thread
From: Daniel Lezcano @ 2019-06-14  6:49 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Zhang Rui, Eduardo Valentin, Florian Fainelli, Ray Jui,
	Scott Branden, bcm-kernel-feedback-list, linux-pm

On 14/06/2019 07:05, Greg Kroah-Hartman wrote:
> On Thu, Jun 13, 2019 at 10:18:13PM +0200, Daniel Lezcano wrote:
>> On 13/06/2019 20:37, Greg Kroah-Hartman wrote:
>>> When calling debugfs functions, there is no need to ever check the
>>> return value.  The function can work or not, but the code logic should
>>> never do something different based on this.
>>
>> Sorry if I'm missing some context but does it mean we do no longer take
>> care of roll-backing anything?
> 
> Yes, but how can that happen here?
> 
>> It is acceptable to have half of the debugfs set for example?
> 
> Yes, your code should never care about this.
> 
>> Or a parent failing to create and the children polluting the root
>> debugfs dir because the parent is NULL?
> 
> How can the parent be NULL?  Remember, debugfs_create_dir() can never
> return NULL, so that should not happen.  And even if it does, that's
> fine, who cares :)

Right, debugfs_create_dir() returns an PTR_ERR which can be passed to
debugfs_create_file() as the parent parameter but this is handled in
start_creating().

Ok, thanks for the clarification.

  -- Daniel


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-13 18:37 [PATCH] thermal: bcm2835: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-06-13 20:18 ` Daniel Lezcano
2019-06-14  5:05   ` Greg Kroah-Hartman
2019-06-14  6:49     ` Daniel Lezcano

Linux-PM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-pm/0 linux-pm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-pm linux-pm/ https://lore.kernel.org/linux-pm \
		linux-pm@vger.kernel.org linux-pm@archiver.kernel.org
	public-inbox-index linux-pm


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-pm


AGPL code for this site: git clone https://public-inbox.org/ public-inbox