From: Simo Sorce <simo@redhat.com>
To: Chris von Recklinghausen <crecklin@redhat.com>,
ardb@kernel.org, rafael@kernel.org, decui@microsoft.com,
linux-pm@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/1] use crc32 instead of md5 for hibernation e820 integrity check
Date: Thu, 08 Apr 2021 09:01:51 -0400 [thread overview]
Message-ID: <e22b105449b6970177d5907d9cbb9e7f55bc72bb.camel@redhat.com> (raw)
In-Reply-To: <20210408104629.31357-1-crecklin@redhat.com>
On Thu, 2021-04-08 at 06:46 -0400, Chris von Recklinghausen wrote:
> Suspend fails on a system in fips mode because md5 is used for the e820
> integrity check and is not available. Use crc32 instead.
>
> Prior to this patch, MD5 is used only to create a digest to ensure integrity of
> the region, no actual encryption is done. This patch set changes the integrity
> check to use crc32 instead of md5 since crc32 is available in both FIPS and
> non-FIPS modes.
>
> Note that the digest is only used as an integrity check. No actual encryption
> is done.
>
> Fixes: 62a03defeabd ("PM / hibernate: Verify the consistent of e820 memory map
> by md5 digest")
>
> Tested-by: Dexuan Cui <decui@microsoft.com>
> Reviewed-by: Dexuan Cui <decui@microsoft.com>
> Signed-off-by: Chris von Recklinghausen <crecklin@redhat.com>
Hi Chris,
I would reword it this way:
----------
This patch(set) changes the integrity check algorithm from md5 to
crc32. This integrity check is used only to verify accidental
corruption of the hybernation data and is not intended as a
cryptographic integrity check.
Md5 is overkill in this case and also disabled in FIPS mode because it
is known to be broken for cryptographic purposes.
----------
HTH,
Simo.
--
Simo Sorce
RHEL Crypto Team
Red Hat, Inc
next prev parent reply other threads:[~2021-04-08 13:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 10:46 [PATCH v4 1/1] use crc32 instead of md5 for hibernation e820 integrity check Chris von Recklinghausen
2021-04-08 13:01 ` Simo Sorce [this message]
2021-04-09 16:56 ` David Laight
2021-04-09 19:28 ` Chris von Recklinghausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e22b105449b6970177d5907d9cbb9e7f55bc72bb.camel@redhat.com \
--to=simo@redhat.com \
--cc=ardb@kernel.org \
--cc=crecklin@redhat.com \
--cc=decui@microsoft.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).