From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3550C388F7 for ; Tue, 10 Nov 2020 15:04:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8540F2076E for ; Tue, 10 Nov 2020 15:04:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731011AbgKJPEi (ORCPT ); Tue, 10 Nov 2020 10:04:38 -0500 Received: from foss.arm.com ([217.140.110.172]:57230 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726721AbgKJPEh (ORCPT ); Tue, 10 Nov 2020 10:04:37 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 49EE412FC; Tue, 10 Nov 2020 07:04:37 -0800 (PST) Received: from [10.57.21.178] (unknown [10.57.21.178]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3A1FE3F718; Tue, 10 Nov 2020 07:04:35 -0800 (PST) Subject: Re: [PATCH 3/4] powercap/drivers/dtpm: Add API for dynamic thermal power management To: Daniel Lezcano Cc: rafael@kernel.org, srinivas.pandruvada@linux.intel.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, rui.zhang@intel.com, "Rafael J. Wysocki" , Arnd Bergmann , "open list:GENERIC INCLUDE/ASM HEADER FILES" References: <20201006122024.14539-1-daniel.lezcano@linaro.org> <20201006122024.14539-4-daniel.lezcano@linaro.org> <8fea0109-30d4-7d67-ffeb-8e588a4dadc3@arm.com> <313a92c5-3c45-616f-1fe8-9837721f9889@arm.com> <2495f9b8-327d-bf92-a159-ac3202d30ee0@linaro.org> From: Lukasz Luba Message-ID: Date: Tue, 10 Nov 2020 15:04:33 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <2495f9b8-327d-bf92-a159-ac3202d30ee0@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 11/10/20 2:59 PM, Daniel Lezcano wrote: > On 10/11/2020 12:05, Lukasz Luba wrote: >> >> Actually I've found one issue when I have been trying to clean >> my testing branch with modified scmi-cpufreq.c. > > IMO, those errors are not the dtpm framework fault but the scmi-cpufreq. True, I have added this proposed macro directly into driver, but it's not strictly the framework. > > You should add a component in the drivers/powercap which does the glue > between the scmi-cpufreq and the dtpm. No stub will be needed in this > case as the component will depend on CONFIG_DTPM. > > > > Make sense, the glue stick should take care in this scenario. In this case, please keep the Reviewed-by and Tested-by and ignore the previous email.