Re: [PATCH] hibernation:stop resume screen during hibernation

From: pingshuo <pingshuo@uniontech.com>
To: Pavel Machek <pavel@ucw.cz>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Len Brown <len.brown@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Linux PM <linux-pm@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hibernation:stop resume screen during hibernation
Date: Thu, 24 Jun 2021 10:06:19 +0800	[thread overview]
Message-ID: <f1ac4975-775e-93c4-c3a7-8b3438b6373d@uniontech.com> (raw)
In-Reply-To: <20210622134703.GA12358@duo.ucw.cz>

>> The display will be woken up during hibernation.
>
> That actually depends on its driver.
>
>> if the computer equipment is poor, it will cause the screen to flicker.
>> Skip to resume the display devices in "thaw".

> But this patch looks like a proof of concept rather than a proper solution.

>This needs to be done more carefully.

When entering hibernation, the display screen will be off first, then 
will be on (the image data is written to the disk at this time), and 
finally the display screen will be off again.

> If you want to deal with PCI devices, that needs to happen at the PCI
bus type level in the first place

what is the "PCI bus type level" mean ? Do you mean to modify it in 
dev->bus or dev-> bus -> pm?

  We tested different graphics cards,like amdgpu, radeon,i915,nvidia, 
this issue occurs during entering hibernation.
Based on the above test, several graphics cards will be resumed and the 
screen is on, so we add code here.
Did you have any idea  if these code is added in here ?

Please answer a question for me.

Resuming device is to write the image to the disk. Is it necessary to 
wake up all devices? Why not just wake up the devices related to writing 
image?

Anticipate your response.

thanks,
                                                               pingshuo