From: Zhang Rui <rui.zhang@intel.com>
To: Quentin Perret <qperret@google.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux PM list <linux-pm@vger.kernel.org>,
Eduardo Valentin <edubezval@gmail.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amit.kucheria@verdurent.com>
Subject: Re: linux-next: Tree for Nov 15 (thermal: THERMAL_GOV_POWER_ALLOCATOR)
Date: Thu, 05 Dec 2019 13:50:27 +0800 [thread overview]
Message-ID: <f948e348f4d3a096d42b80f79288cb88903ad800.camel@intel.com> (raw)
In-Reply-To: <20191205043609.GA231782@google.com>
On Thu, 2019-12-05 at 04:36 +0000, Quentin Perret wrote:
> Hi all,
>
> On Thursday 05 Dec 2019 at 12:27:47 (+0800), Zhang Rui wrote:
> > I overlooked the original report probably because I was not CCed.
> >
> > This is introduced by commit a4e893e802e6("thermal: cpu_cooling:
> > Migrate to using the EM framework") which adds the dependency of
> > ENERGY_MODEL for THERMAL_GOV_POWER_ALLOCATOR.
> >
> > To fix this, it's better to make
> > THERMAL_DEFAULT_GOV_POWER_ALLOCATOR
> > depends on THERMAL_GOV_POWER_ALLOCATOR instead.
> >
> > Please confirm the problem is fixed by below patch.
> >
> > thanks,
> > rui
> >
> > From c9429f6e28ea2219686a4294d39f015ba373774b Mon Sep 17 00:00:00
> > 2001
> > From: Zhang Rui <rui.zhang@intel.com>
> > Date: Thu, 5 Dec 2019 12:17:07 +0800
> > Subject: [PATCH] thermal: fix a Kconfig warning
> >
> > Currently, THERMAL_GOV_POWER_ALLOCATOR is selected by
> > THERMAL_DEFAULT_GOV_POWER_ALLOCATOR even if it has some unmet
> > dependencies.
> >
> > This causes the Kconfig warning
> > WARNING: unmet direct dependencies detected for
> > THERMAL_GOV_POWER_ALLOCATOR
> > Depends on [n]: THERMAL [=y] && ENERGY_MODEL [=n]
> > Selected by [y]:
> > - THERMAL_DEFAULT_GOV_POWER_ALLOCATOR [=y] && <choice>
> >
> > Fix the problem by making THERMAL_DEFAULT_GOV_POWER_ALLOCATOR
> > depends on
> > THERMAL_GOV_POWER_ALLOCATOR instead.
> >
> > Fixes: a4e893e802e6("thermal: cpu_cooling: Migrate to using the EM
> > framework")
> > Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> > ---
> > drivers/thermal/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> > index 59b79fc48266..79b27865c6f4 100644
> > --- a/drivers/thermal/Kconfig
> > +++ b/drivers/thermal/Kconfig
> > @@ -108,7 +108,7 @@ config THERMAL_DEFAULT_GOV_USER_SPACE
> >
> > config THERMAL_DEFAULT_GOV_POWER_ALLOCATOR
> > bool "power_allocator"
> > - select THERMAL_GOV_POWER_ALLOCATOR
> > + depends on THERMAL_GOV_POWER_ALLOCATOR
> > help
> > Select this if you want to control temperature based on
> > system and device power allocation. This governor can only
> > --
> > 2.17.1
>
> FWIW, a similar fix has been suggested a couple weeks back:
>
>
> https://lore.kernel.org/lkml/20191113105313.41616-1-yuehaibing@huawei.com/
Right, this patch was just merged by Daniel. It seems that we need a
second PR in this merge window.
thanks,
rui
>
> Thanks,
> Quentin
next prev parent reply other threads:[~2019-12-05 5:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191115190525.77efdf6c@canb.auug.org.au>
2019-11-15 23:44 ` linux-next: Tree for Nov 15 (thermal: THERMAL_GOV_POWER_ALLOCATOR) Randy Dunlap
2019-12-04 16:25 ` Randy Dunlap
2019-12-05 4:27 ` Zhang Rui
2019-12-05 4:36 ` Quentin Perret
2019-12-05 5:50 ` Zhang Rui [this message]
2019-12-05 5:47 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f948e348f4d3a096d42b80f79288cb88903ad800.camel@intel.com \
--to=rui.zhang@intel.com \
--cc=amit.kucheria@verdurent.com \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=qperret@google.com \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).