From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BBF1C433E0 for ; Wed, 29 Jul 2020 13:29:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1C9132083E for ; Wed, 29 Jul 2020 13:29:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727113AbgG2N3q (ORCPT ); Wed, 29 Jul 2020 09:29:46 -0400 Received: from foss.arm.com ([217.140.110.172]:51714 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726365AbgG2N3q (ORCPT ); Wed, 29 Jul 2020 09:29:46 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1A7A61FB; Wed, 29 Jul 2020 06:29:45 -0700 (PDT) Received: from e113632-lin (e113632-lin.cambridge.arm.com [10.1.194.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1C1903F66E; Wed, 29 Jul 2020 06:29:43 -0700 (PDT) References: <20200712165917.9168-1-valentin.schneider@arm.com> <20200712165917.9168-3-valentin.schneider@arm.com> <20200727141825.GA4174@lca.pw> <16f8c1d4-778b-3ab8-f328-bae80f3973b4@arm.com> <20200729130910.GA1075614@google.com> User-agent: mu4e 0.9.17; emacs 26.3 From: Valentin Schneider To: Quentin Perret Cc: Dietmar Eggemann , Qian Cai , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, Russell King , Thara Gopinath , Sudeep Holla , Amit Daniel Kachhap , Daniel Lezcano , Viresh Kumar , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot Subject: Re: [PATCH v2 2/3] sched: Cleanup SCHED_THERMAL_PRESSURE kconfig entry In-reply-to: <20200729130910.GA1075614@google.com> Date: Wed, 29 Jul 2020 14:29:37 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 29/07/20 14:09, Quentin Perret wrote: > On Tuesday 28 Jul 2020 at 17:16:57 (+0100), Valentin Schneider wrote: >> We could change the arch Kconfig into >> >> select SCHED_THERMAL_PRESSURE if CPU_FREQ_THERMAL >> >> but that seems redundant; this dependency is already expressed in >> SCHED_THERMAL_PRESSURE's definition. Is there a proper pattern to select >> some Kconfig option only if all of its dependencies are met? > > How about something like this (totally untested): > > ---8<--- > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 939c4d6bbc2e..2ac74904a3ce 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -46,7 +46,6 @@ config ARM > select EDAC_ATOMIC_SCRUB > select GENERIC_ALLOCATOR > select GENERIC_ARCH_TOPOLOGY if ARM_CPU_TOPOLOGY > - select SCHED_THERMAL_PRESSURE if ARM_CPU_TOPOLOGY > select GENERIC_ATOMIC64 if CPU_V7M || CPU_V6 || !CPU_32v6K || !AEABI > select GENERIC_CLOCKEVENTS_BROADCAST if SMP > select GENERIC_CPU_AUTOPROBE > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index c403e6f5db86..66dc41fd49f2 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -192,7 +192,6 @@ config ARM64 > select PCI_SYSCALL if PCI > select POWER_RESET > select POWER_SUPPLY > - select SCHED_THERMAL_PRESSURE > select SPARSE_IRQ > select SWIOTLB > select SYSCTL_EXCEPTION_TRACE > diff --git a/init/Kconfig b/init/Kconfig > index 0a97d85568b2..c2e1f3ac527e 100644 > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -493,6 +493,7 @@ config HAVE_SCHED_AVG_IRQ > > config SCHED_THERMAL_PRESSURE > bool > + default y if ARM64 || ARM_CPU_TOPOLOGY > depends on SMP > depends on CPU_FREQ_THERMAL > help > --->8--- > That does seem to do just what I was looking for, thanks! > Thanks, > Quentin