* [PATCH] ppp_synctty: remove unneeded NULL check
@ 2015-02-19 21:39 Alan
0 siblings, 0 replies; only message in thread
From: Alan @ 2015-02-19 21:39 UTC (permalink / raw)
To: linux-ppp
Fix a random whine found by coverity. Had it been NULL it would have
showered us with oopses long before.
Signed-off-by: Alan Cox <alan@linux.intel.com>
---
drivers/net/ppp/ppp_synctty.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ppp/ppp_synctty.c b/drivers/net/ppp/ppp_synctty.c
index 925d3e2..b5592b8 100644
--- a/drivers/net/ppp/ppp_synctty.c
+++ b/drivers/net/ppp/ppp_synctty.c
@@ -549,7 +549,7 @@ ppp_sync_txmunge(struct syncppp *ap, struct sk_buff *skb)
ap->last_xmit = jiffies;
- if (skb && ap->flags & SC_LOG_OUTPKT)
+ if (ap->flags & SC_LOG_OUTPKT)
ppp_print_buffer ("send buffer", skb->data, skb->len);
return skb;
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-02-19 21:39 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-19 21:39 [PATCH] ppp_synctty: remove unneeded NULL check Alan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).