linux-ppp.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: simon@farnz.org.uk
Cc: netdev@vger.kernel.org, linux-ppp@vger.kernel.org, mostrows@gmail.com
Subject: Re: [PATCH net-next v2] pppoe: Use workqueue to die properly when a PADT is received
Date: Mon, 02 Mar 2015 05:17:49 +0000	[thread overview]
Message-ID: <20150302.001749.1494675361394874315.davem@davemloft.net> (raw)
In-Reply-To: <1425207279-4822-1-git-send-email-simon@farnz.org.uk>

From: Simon Farnsworth <simon@farnz.org.uk>
Date: Sun,  1 Mar 2015 10:54:39 +0000

> When a PADT frame is received, the socket may not be in a good state to
> close down the PPP interface. The current implementation handles this by
> simply blocking all further PPP traffic, and hoping that the lack of traffic
> will trigger the user to investigate.
> 
> Use schedule_work to get to a process context from which we clear down the
> PPP interface, in a fashion analogous to hangup on a TTY-based PPP
> interface. This causes pppd to disconnect immediately, and allows tools to
> take immediate corrective action.
> 
> Note that pppd's rp_pppoe.so plugin has code in it to disable the session
> when it disconnects; however, as a consequence of this patch, the session is
> already disabled before rp_pppoe.so is asked to disable the session. The
> result is a harmless error message:
> 
> Failed to disconnect PPPoE socket: 114 Operation already in progress
> 
> This message is safe to ignore, as long as the error is 114 Operation
> already in progress; in that specific case, it means that the PPPoE session
> has already been disabled before pppd tried to disable it.
> 
> Signed-off-by: Simon Farnsworth <simon@farnz.org.uk>
> Tested-by: Dan Williams <dcbw@redhat.com>
> Tested-by: Christoph Schulz <develop@kristov.de>

Applied, thanks Simon.

      reply	other threads:[~2015-03-02  5:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-01 10:54 [PATCH net-next v2] pppoe: Use workqueue to die properly when a PADT is received Simon Farnsworth
2015-03-02  5:17 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150302.001749.1494675361394874315.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=linux-ppp@vger.kernel.org \
    --cc=mostrows@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=simon@farnz.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).