From: Guillaume Nault <g.nault@alphalink.fr>
To: Philp Prindeville <philipp@redfish-solutions.com>
Cc: Feng Gao <gfree.wind@gmail.com>,
Gao Feng <fgao@48lvckh6395k16k5.yundunddos.com>,
paulus@samba.org, linux-ppp@vger.kernel.org,
Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [PATCH 1/1] ppp: Fix one deadlock issue of PPP when send frame
Date: Fri, 19 Aug 2016 22:47:54 +0000 [thread overview]
Message-ID: <20160819224754.ddfl2u4edfkctw4f@alphalink.fr> (raw)
In-Reply-To: <96f03d73-73f9-23ac-591f-a855169f8dc9@redfish-solutions.com>
On Thu, Aug 18, 2016 at 08:11:15AM -0600, Philp Prindeville wrote:
>
> It seems unlikely to me that this sort of locking problem hasn't existed
> elsewhere before and that an entirely new mechanism for handling it is
> needed... How are similar re-entrancy issues handled elsewhere?
>
Virtual devices like vxlan and geneve drop packets if the ouput device
(after encapsulation) is the same as the encapsulating device.
It's possible to bypass this check by stacking devices. In this case,
recursion occurs until __dev_queue_xmit() triggers the
XMIT_RECURSION_LIMIT. If the qdisc isn't noqueue so that recursion
isn't stopped by __dev_queue_xmit(), then it's possible to fill the
skb's headroom and the packet gets drop after pskb_expand_head() fails.
In any case only the faulty path is affected and the system remains
stable.
It'd be nice to have PPP working this way, but this is made really
difficult by the number of locks used in the xmit path.
Even checking if the output interface is also the encapsulating one
isn't trivial. The L2TP layer doesn't access the upper interface. It
may not even be a PPP device in case of L2TPv3.
next prev parent reply other threads:[~2016-08-19 22:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 11:05 [PATCH 1/1] ppp: Fix one deadlock issue of PPP when send frame fgao
2016-08-16 11:36 ` Feng Gao
2016-08-18 14:11 ` Philp Prindeville
2016-08-18 15:05 ` Feng Gao
2016-08-18 16:48 ` Philp Prindeville
2016-08-18 22:53 ` Feng Gao
2016-08-19 22:47 ` Guillaume Nault [this message]
2016-08-19 15:16 ` [PATCH 1/1] ppp: Fix one deadlock issue of PPP when reentrant fgao
2016-08-19 21:48 ` Guillaume Nault
2016-08-20 6:40 ` Feng Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160819224754.ddfl2u4edfkctw4f@alphalink.fr \
--to=g.nault@alphalink.fr \
--cc=fgao@48lvckh6395k16k5.yundunddos.com \
--cc=gfree.wind@gmail.com \
--cc=linux-ppp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=philipp@redfish-solutions.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).