linux-ppp.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: gfree.wind@vip.163.com
Cc: paulus@samba.org, g.nault@alphalink.fr,
	linux-ppp@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] ppp: Fix false xmit recursion detect with two ppp devices
Date: Tue, 18 Jul 2017 18:21:45 +0000	[thread overview]
Message-ID: <20170718.112145.599694527854940189.davem@davemloft.net> (raw)
In-Reply-To: <1500287682-18872-1-git-send-email-gfree.wind@vip.163.com>

From: gfree.wind@vip.163.com
Date: Mon, 17 Jul 2017 18:34:42 +0800

> From: Gao Feng <gfree.wind@vip.163.com>
> 
> The global percpu variable ppp_xmit_recursion is used to detect the ppp
> xmit recursion to avoid the deadlock, which is caused by one CPU tries to
> lock the xmit lock twice. But it would report false recursion when one CPU
> wants to send the skb from two different PPP devices, like one L2TP on the
> PPPoE. It is a normal case actually.
> 
> Now use one percpu member of struct ppp instead of the gloable variable to
> detect the xmit recursion of one ppp device.
> 
> Fixes: 55454a565836 ("ppp: avoid dealock on recursive xmit")
> Signed-off-by: Gao Feng <gfree.wind@vip.163.com>
> Signed-off-by: Liu Jianying <jianying.liu@ikuai8.com>

Indeed, for a per-ppp lock recursion check we need a per-ppp counter.

Applied, thanks!

      reply	other threads:[~2017-07-18 18:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-17 10:34 [PATCH] ppp: Fix false xmit recursion detect with two ppp devices gfree.wind
2017-07-18 18:21 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170718.112145.599694527854940189.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=g.nault@alphalink.fr \
    --cc=gfree.wind@vip.163.com \
    --cc=linux-ppp@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).