From: Tom Parkin <tparkin@katalix.com>
To: Matteo Croce <mcroce@redhat.com>
Cc: linux-ppp@vger.kernel.org, netdev <netdev@vger.kernel.org>,
Paul Mackerras <paulus@ozlabs.org>, Jo-Philipp Wich <jo@mein.io>
Subject: Re: [PATCH pppd v4] pppoe: custom host-uniq tag
Date: Tue, 07 May 2019 09:39:33 +0000 [thread overview]
Message-ID: <20190507093932.GB3561@jackdaw> (raw)
In-Reply-To: <CAGnkfhwVvF4qcqoU6wC8tCb6vrvNipP0UG4MxqAd1--5fLmjQg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1115 bytes --]
On Tue, May 07, 2019 at 11:32:27AM +0200, Matteo Croce wrote:
> On Tue, May 7, 2019 at 11:10 AM Tom Parkin <tparkin@katalix.com> wrote:
> >
> > Hi Matteo,
> >
> > On Sat, May 04, 2019 at 06:48:53PM +0200, Matteo Croce wrote:
> > > Add pppoe 'host-uniq' option to set an arbitrary
> > > host-uniq tag instead of the pppd pid.
> > > Some ISPs use such tag to authenticate the CPE,
> > > so it must be set to a proper value to connect.
> > >
> > > Signed-off-by: Matteo Croce <mcroce@redhat.com>
> > > Signed-off-by: Jo-Philipp Wich <jo@mein.io>
> > > ---
> > > pppd/plugins/rp-pppoe/common.c | 14 +++----
> > > pppd/plugins/rp-pppoe/discovery.c | 52 ++++++++++---------------
> > > pppd/plugins/rp-pppoe/plugin.c | 15 ++++++-
> > > pppd/plugins/rp-pppoe/pppoe-discovery.c | 41 ++++++++++++-------
> > > pppd/plugins/rp-pppoe/pppoe.h | 30 +++++++++++++-
> > > 5 files changed, 96 insertions(+), 56 deletions(-)
> > >
>
> Hi Tom,
>
> this was a known bug of the v3 patch, I've fixed it in the v4.
>
> Regards,
Cool, thanks for confirming.
Tom
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2019-05-07 9:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-04 16:48 [PATCH pppd v4] pppoe: custom host-uniq tag Matteo Croce
2019-05-07 9:10 ` Tom Parkin
2019-05-07 9:32 ` Matteo Croce
2019-05-07 9:39 ` Tom Parkin [this message]
2019-05-27 0:35 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190507093932.GB3561@jackdaw \
--to=tparkin@katalix.com \
--cc=jo@mein.io \
--cc=linux-ppp@vger.kernel.org \
--cc=mcroce@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=paulus@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).