* [PATCH] ppp: mppe: Add softdep to arc4
@ 2019-06-19 13:34 Takashi Iwai
2019-06-22 13:44 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Takashi Iwai @ 2019-06-19 13:34 UTC (permalink / raw)
To: Paul Mackerras; +Cc: David S . Miller, linux-ppp, netdev
The arc4 crypto is mandatory at ppp_mppe probe time, so let's put a
softdep line, so that the corresponding module gets prepared
gracefully. Without this, a simple inclusion to initrd via dracut
failed due to the missing dependency, for example.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
drivers/net/ppp/ppp_mppe.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ppp/ppp_mppe.c b/drivers/net/ppp/ppp_mppe.c
index ff61dd8748de..66c8e65f6872 100644
--- a/drivers/net/ppp/ppp_mppe.c
+++ b/drivers/net/ppp/ppp_mppe.c
@@ -63,6 +63,7 @@ MODULE_AUTHOR("Frank Cusack <fcusack@fcusack.com>");
MODULE_DESCRIPTION("Point-to-Point Protocol Microsoft Point-to-Point Encryption support");
MODULE_LICENSE("Dual BSD/GPL");
MODULE_ALIAS("ppp-compress-" __stringify(CI_MPPE));
+MODULE_SOFTDEP("pre: arc4");
MODULE_VERSION("1.0.2");
static unsigned int
--
2.16.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ppp: mppe: Add softdep to arc4
2019-06-19 13:34 [PATCH] ppp: mppe: Add softdep to arc4 Takashi Iwai
@ 2019-06-22 13:44 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-06-22 13:44 UTC (permalink / raw)
To: tiwai; +Cc: paulus, linux-ppp, netdev
From: Takashi Iwai <tiwai@suse.de>
Date: Wed, 19 Jun 2019 15:34:07 +0200
> The arc4 crypto is mandatory at ppp_mppe probe time, so let's put a
> softdep line, so that the corresponding module gets prepared
> gracefully. Without this, a simple inclusion to initrd via dracut
> failed due to the missing dependency, for example.
>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-22 13:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-19 13:34 [PATCH] ppp: mppe: Add softdep to arc4 Takashi Iwai
2019-06-22 13:44 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).