linux-ppp.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] ppp: Remove redundant BUG_ON() check in ppp_pernet
@ 2019-12-25  3:07 Xu Wang
  2019-12-27 12:05 ` Guillaume Nault
  0 siblings, 1 reply; 2+ messages in thread
From: Xu Wang @ 2019-12-25  3:07 UTC (permalink / raw)
  To: paulus; +Cc: davem, linux-ppp, netdev, linux-kernel

Passing NULL to ppp_pernet causes a crash via BUG_ON.
Dereferencing net in net_generic() also has the same effect.
This patch removes the redundant BUG_ON check on the same parameter.

Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
 drivers/net/ppp/ppp_generic.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c
index 3bf8a8b..22cc2cb 100644
--- a/drivers/net/ppp/ppp_generic.c
+++ b/drivers/net/ppp/ppp_generic.c
@@ -296,8 +296,6 @@ static struct class *ppp_class;
 /* per net-namespace data */
 static inline struct ppp_net *ppp_pernet(struct net *net)
 {
-	BUG_ON(!net);
-
 	return net_generic(net, ppp_net_id);
 }
 
-- 
2.7.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] ppp: Remove redundant BUG_ON() check in ppp_pernet
  2019-12-25  3:07 [PATCH v2] ppp: Remove redundant BUG_ON() check in ppp_pernet Xu Wang
@ 2019-12-27 12:05 ` Guillaume Nault
  0 siblings, 0 replies; 2+ messages in thread
From: Guillaume Nault @ 2019-12-27 12:05 UTC (permalink / raw)
  To: Xu Wang; +Cc: paulus, davem, linux-ppp, netdev, linux-kernel

On Wed, Dec 25, 2019 at 03:07:04AM +0000, Xu Wang wrote:
> Passing NULL to ppp_pernet causes a crash via BUG_ON.
> Dereferencing net in net_generic() also has the same effect.
> This patch removes the redundant BUG_ON check on the same parameter.
> 
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
> ---
>  drivers/net/ppp/ppp_generic.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c
> index 3bf8a8b..22cc2cb 100644
> --- a/drivers/net/ppp/ppp_generic.c
> +++ b/drivers/net/ppp/ppp_generic.c
> @@ -296,8 +296,6 @@ static struct class *ppp_class;
>  /* per net-namespace data */
>  static inline struct ppp_net *ppp_pernet(struct net *net)
>  {
> -	BUG_ON(!net);
> -
>  	return net_generic(net, ppp_net_id);
>  }
Acked-by: Guillaume Nault <gnault@redhat.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-12-27 12:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-25  3:07 [PATCH v2] ppp: Remove redundant BUG_ON() check in ppp_pernet Xu Wang
2019-12-27 12:05 ` Guillaume Nault

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).