From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85369C433EF for ; Tue, 12 Jul 2022 17:34:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230044AbiGLReM (ORCPT ); Tue, 12 Jul 2022 13:34:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229976AbiGLReL (ORCPT ); Tue, 12 Jul 2022 13:34:11 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 72FDEC3AFB for ; Tue, 12 Jul 2022 10:34:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657647249; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YnYHNlXG4sAUmEFeyzh6YNeY0EHRa/NJXlU0ExFTwhw=; b=LeN0LOk5xO5EDmwLsi6D9VbtzoDO3q9V2wmGRURYa6gOh9RJzebyyU/Q6a6q86lchgVnCP 9z5EJ3RGUMBMw2Y8Nh3CTLlccE9crpTAFJs43TBQB1mSVzrgKli4V1djYJQ2N7a9Qtv+mL vf4bmcVuG+xGl0RzioxHv9jNAx8St7U= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-192-2QPQt0w_OPCmZOWhmDac5g-1; Tue, 12 Jul 2022 13:34:08 -0400 X-MC-Unique: 2QPQt0w_OPCmZOWhmDac5g-1 Received: by mail-wr1-f71.google.com with SMTP id o1-20020adfba01000000b0021b90bd28d2so1601491wrg.14 for ; Tue, 12 Jul 2022 10:34:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=YnYHNlXG4sAUmEFeyzh6YNeY0EHRa/NJXlU0ExFTwhw=; b=VVka8Qk+OxuR8OuzMefFFmU/ATXGGRWRp+9YYQvsA4uhkoDVwUDqhw0UtVLmNLWtjK 0wLJOMmxO22udS+BnOKJMNPKBG9WC47VOuXcZauWvzvBUa1ov8lNLExeygVIj9d7qBt6 XLA5y8ZS9R42aU5RAL8EwPBJ2387GOWpviXUQnz7PDN3GqbaYGunWK6FATEKly0iVweR 3AkS38zv7nTZx7EZnt8FokyCKFBQ4AmXtZKY/PoUSfzXd4OIwKmTcIH5w0Wbn6bq9sGg STjd+hQB4hv9npEGw1M9T0Gp8USI4AKpc5p3cK12Zc6gyLs/18g+9tmDtgWxS+rghwEg eRxA== X-Gm-Message-State: AJIora+pxhyu1sAHSFjps47D9HHD8V8x9T5ble4lZFwowM5OrgHpItRM kuZnvuZboNnjmDTQxmJ1QI1ExyorG3pboQuw6eERmjfOKvjadseHwkFRnB4jIGKJdWu3aJvkSWT EJd+QwZo9o8LmAZp4fqG5 X-Received: by 2002:a5d:64e2:0:b0:21d:38e8:2497 with SMTP id g2-20020a5d64e2000000b0021d38e82497mr21630556wri.142.1657647246900; Tue, 12 Jul 2022 10:34:06 -0700 (PDT) X-Google-Smtp-Source: AGRyM1s+PP4fF7oA8OdWVvLKhyeV68On2eq47evFDSzPrbco4GFV9G3YPeiUG9k5/I7KupkTLDI7PA== X-Received: by 2002:a5d:64e2:0:b0:21d:38e8:2497 with SMTP id g2-20020a5d64e2000000b0021d38e82497mr21630530wri.142.1657647246710; Tue, 12 Jul 2022 10:34:06 -0700 (PDT) Received: from localhost.localdomain ([185.233.130.50]) by smtp.gmail.com with ESMTPSA id j16-20020adfff90000000b0021d76a1b0e3sm8759337wrr.6.2022.07.12.10.34.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jul 2022 10:34:05 -0700 (PDT) Date: Tue, 12 Jul 2022 19:34:03 +0200 From: Guillaume Nault To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: James Carlson , Chris Fowler , Jakub Kicinski , Paul Mackerras , "David S. Miller" , "linux-ppp@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ppp: Add rtnl attribute IFLA_PPP_UNIT_ID for specifying ppp unit id Message-ID: <20220712173403.GC3794@localhost.localdomain> References: <20210811180401.owgmie36ydx62iep@pali> <20210812092847.GB3525@pc-23.home> <20210812134845.npj3m3vzkrmhx6uy@pali> <20210812182645.GA10725@pc-23.home> <20210812190440.fknfthdk3mazm6px@pali> <20210816161114.GA3611@pc-32.home> <20210816162355.7ssd53lrpclfvuiz@pali> <20210817160525.GA20616@pc-32.home> <20210817162155.idyfy53qbxcsf2ga@pali> <20220709120906.ymkhn5diywadgrka@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220709120906.ymkhn5diywadgrka@pali> Precedence: bulk List-ID: X-Mailing-List: linux-ppp@vger.kernel.org On Sat, Jul 09, 2022 at 02:09:06PM +0200, Pali Rohár wrote: > On Tuesday 17 August 2021 18:21:55 Pali Rohár wrote: > > On Tuesday 17 August 2021 18:05:25 Guillaume Nault wrote: > > > On Mon, Aug 16, 2021 at 06:23:55PM +0200, Pali Rohár wrote: > > > > On Monday 16 August 2021 18:11:14 Guillaume Nault wrote: > > > > > Do you have plans for adding netlink support to pppd? If so, is the > > > > > project ready to accept such code? > > > > > > > > Yes, I have already some WIP code and I'm planning to send a pull > > > > request to pppd on github for it. I guess that it could be accepted, > > > > > > I guess you can easily use the netlink api for cases where the "unit" > > > option isn't specified and fall back to the ioctl api when it is. If > > > all goes well, then we can extend the netlink api to accept a unit id. > > > > > > But what about the lack of netlink feedback about the created > > > interface? Are you restricted to use netlink only when the "ifname" > > > option is provided? > > > > Exactly, this is how I wrote my WIP code... > > Sorry for a long delay (I forgot about it). Now I created pull request > for pppd https://github.com/ppp-project/ppp/pull/354 which adds support > for creating ppp interface via rtnetlink. rtnetlink is used only when > ppp unit id was not provided and interface name was provided. Interesting work. Thanks for working on it! > > > > specially if there still would be backward compatibility via ioctl for > > > > kernels which do not support rtnl API. > > > > > > Indeed, I'd expect keeping compatiblitity with old kernels that only > > > have the ioctl api to be a must (but I have no experience contributing > > > to the pppd project). > > > > > > > One of the argument which can be > > > > used why rtnl API is better, is fixing issue: atomic creating of > > > > interface with specific name. > > > > > > Yes, that looks useful. > > > >