From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Date: Mon, 26 Jun 2017 13:33:50 +0000 Subject: Re: [PATCH net-next v2 4/5] net: add netlink_ext_ack argument to rtnl_link_ops.slave_changelink Message-Id: <27b8d607-7442-0a42-1389-9548840445dc@gmail.com> List-Id: References: <498ff06f59d5ce13b2ad3e1c1902c3d348ca3c00.1498425679.git.mschiffer@universe-factory.net> <15d2138d-5026-a35b-8a3c-2a88d05df688@universe-factory.net> In-Reply-To: <15d2138d-5026-a35b-8a3c-2a88d05df688@universe-factory.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Matthias Schiffer , dledford@redhat.com, sean.hefty@intel.com, hal.rosenstock@gmail.com, j.vosburgh@gmail.com, vfalico@gmail.com, andy@greyhouse.net, wg@grandegger.com, mkl@pengutronix.de, pablo@netfilter.org, laforge@gnumonks.org, paulus@samba.org, jiri@resnulli.us, dsa@cumulusnetworks.com, shm@cumulusnetworks.com, davem@davemloft.net, stephen@networkplumber.org, arvid.brodin@alten.se, alex.aring@gmail.com, stefan@osg.samsung.com, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, steffen.klassert@secunet.com, herbert@gondor.apana.org.au, johannes@sipsolutions.net Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-can@vger.kernel.org, linux-ppp@vger.kernel.org, linux-wpan@vger.kernel.org On 6/26/17 2:43 AM, Matthias Schiffer wrote: > On 06/26/2017 06:08 AM, David Ahern wrote: >> On 6/25/17 10:04 PM, David Ahern wrote: >>> On 6/25/17 3:56 PM, Matthias Schiffer wrote: >>>> Add support for extended error reporting. >>>> >>>> Signed-off-by: Matthias Schiffer >>>> --- >>> >>> >>> Acked-by: David Ahern >>> >> >> Actually, you are missing the chagne to br_port_slave_changelink. >> > > I'm confused. I am changing br_port_slave_changelink? All my patches are > compile-tested. > You are changing the signature of slave_changelink, no? net/bridge/br_netlink.c: .slave_changelink = br_port_slave_changelink,