From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Fri, 12 Dec 2014 15:30:49 +0000 Subject: Re: [PATCH v2 0/6] net-PPP: Deletion of a few unnecessary checks Message-Id: <548B0A29.8050503@users.sourceforge.net> List-Id: References: <5480DA32.8000201@users.sourceforge.net> <20141209.145447.2234157264287438778.davem@davemloft.net> <548A92E2.8090304@users.sourceforge.net> <20141212.092950.1840808214143867233.davem@davemloft.net> In-Reply-To: <20141212.092950.1840808214143867233.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Miller Cc: Sergei Shtylyov , Paul Mackerras , linux-ppp@vger.kernel.org, netdev@vger.kernel.org, Eric Dumazet , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Julia Lawall > I gave you very concrete feedback, I said exactly that I don't want > error pointers left in data structure members. I find that your critique affects the proposed update steps four to six, doesn't it? Are the other steps acceptable in principle? > I cannot describe my requirements any more precisely than that. I hope that a bit more constructive suggestions will be contributed by involved software developers around the affected source code. Now it seems that a small code clean-up becomes a more challenging development task. How do you prefer to redesign corresponding data structures eventually? Regards, Markus