From: Michael O'Connor <mike@jazmin.com.au>
To: linux-ppp@vger.kernel.org
Subject: Re: Add support for IPv6 RADIUS attributes
Date: Sun, 10 Jan 2016 23:13:29 +0000 [thread overview]
Message-ID: <5B1BC493-0974-433F-AEB1-65D4DFC5DE2C@jazmin.com.au> (raw)
In-Reply-To: <20160108142012.GL19014@drscott.swordarmor.fr>
Hi
I think it should validate against the dictionary then only use the parameters it needs.
This seems to be the standard I've see in other software.
Mike
> On 11 Jan 2016, at 9:22 AM, Charlie Brady <charlieb-linux-ppp@budge.apana.org.au> wrote:
>
>
>
>> On Sun, 10 Jan 2016, Michael Richardson wrote:
>>
>> I also have patches to the radius module to use the latest (and maintained)
>> radcli client library at: https://github.com/nmav/radcli
>>
>> What is your application? As I read your patches, they just make ppp ignore
>> the attributes. Do you intend to do more with the data?
>
> On the face of it, the reason for Alarig's patch is to prevent pppd
> calling 'error()' in response to unknown attributes. As I've already
> pointed out, there is a much simpler patch to achieve that end.
>
> The radius plugin of pppd shouldn't be trying to validate radius config
> files; it should just read the data it needs from the file. If it finds
> other stuff, it can just ignore it.
>
>>
>> I have patches on both radcli and pppd sides, which haven't all settled yet,
>> so I haven't pushed them anywhere yet.
>>
>> I'm not sure what the ultimate point of your patches are though.
>> Non-LL IPv6 addresses are not assigned through IP6CP, but rather through RA
>> and/or DHCPv6. I have a daemon, called rfc6204d, which does this at scale,
>> but it is not yet sufficiently field tested to release.
>>
>> --
>> ] Never tell me the odds! | ipv6 mesh networks [
>> ] Michael Richardson, Sandelman Software Works | network architect [
>> ] mcr@sandelman.ca http://www.sandelman.ca/ | ruby on rails [
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-01-10 23:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 14:20 Add support for IPv6 RADIUS attributes Alarig Le Lay
2016-01-09 0:49 ` Charlie Brady
2016-01-10 19:03 ` Michael Richardson
2016-01-10 22:52 ` Charlie Brady
2016-01-10 22:58 ` Charlie Brady
2016-01-10 23:13 ` Michael O'Connor [this message]
2016-01-11 9:51 ` Alarig Le Lay
2016-03-08 20:19 ` Benjamin Cama
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B1BC493-0974-433F-AEB1-65D4DFC5DE2C@jazmin.com.au \
--to=mike@jazmin.com.au \
--cc=linux-ppp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).