archive mirror
 help / color / mirror / Atom feed
Subject: [BUG] net/ppp: A use after free in ppp_unregister_channe
Date: Thu, 11 Mar 2021 12:34:44 +0000	[thread overview]
Message-ID: <> (raw)

File: drivers/net/ppp/ppp_generic.c

In ppp_unregister_channel, pch could be freed in ppp_unbridge_channels()
but after that pch is still in use. Inside the function ppp_unbridge_channels,
if "pchbb = pch" is true and then pch will be freed.

I checked the commit history and found that this problem is introduced from
4cf476ced45d7 ("ppp: add PPPIOCBRIDGECHAN and PPPIOCUNBRIDGECHAN ioctls").

I have no idea about how to generate a suitable patch, sorry.

             reply	other threads:[~2021-03-11 12:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-11 12:34 lyl2019 [this message]
2021-03-12 10:12 ` [BUG] net/ppp: A use after free in ppp_unregister_channe Tom Parkin
2021-03-12 14:47   ` lyl2019
2021-03-15  9:57     ` Tom Parkin
2021-03-15 12:18     ` Guillaume Nault
2021-03-15 16:58       ` Tom Parkin
2021-03-15 12:04   ` Guillaume Nault
2021-03-15 11:50 ` Guillaume Nault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).