From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Carlson Date: Fri, 04 Oct 2019 12:52:12 +0000 Subject: Re: [PATCH 4/9] pppd: include time.h before using time_t Message-Id: <6fb1fd97-7e97-8088-ef46-2d4003dbd4e6@workingcode.com> List-Id: References: <1569482466-9551-5-git-send-email-dev.kurt@vandijck-laurijssen.be> In-Reply-To: <1569482466-9551-5-git-send-email-dev.kurt@vandijck-laurijssen.be> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-ppp@vger.kernel.org On 10/04/19 06:49, Kurt Van Dijck wrote: >> IMHO time_t is defined in sys/types.h > > http://www.open-std.org/JTC1/SC22/WG14/www/docs/n1256.pdf > chapter 7.23.1.3 > I believe that covers userland environments, not the kernel. At least on Solaris (and its derivatives, such as Illumos), the symbols available in the kernel are defined in sys/ (or net/, netinet/, or similar for network bits). The top-level header files are for userland libraries. Userland libraries are not accessible within the kernel. In this case, the common net/ppp_defs.h file is used by both user-level code (pppd itself) and by several kernel modules. There may be systems on which including within a kernel module is harmless (I suspect Linux is one), but I have a hard time believing that it's correct to do so. Do you know of a system where either (a) does not exist or (b) it exists but does not define 'time_t'? I haven't been able to find a system that matches either case. I tried several flavors of Linux, AIX, Solaris, HP/UX, and IBM USS on z/OS. -- James Carlson 42.703N 71.076W