linux-ppp.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Allen Pais <apais@linux.microsoft.com>
To: Saeed Mahameed <saeedm@nvidia.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"allen.lkml@gmail.com" <allen.lkml@gmail.com>
Cc: "m.grzeschik@pengutronix.de" <m.grzeschik@pengutronix.de>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"woojung.huh@microchip.com" <woojung.huh@microchip.com>,
	"petkan@nucleusys.com" <petkan@nucleusys.com>,
	"oliver@neukum.org" <oliver@neukum.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
	"paulus@samba.org" <paulus@samba.org>,
	"linux-ppp@vger.kernel.org" <linux-ppp@vger.kernel.org>
Subject: Re: [RESEND net-next v2 00/12]drivers: net: convert tasklets to use new tasklet_setup() API
Date: Tue, 15 Sep 2020 04:56:57 +0000	[thread overview]
Message-ID: <9d9029bd-720d-dc2a-8cbf-8d084fb7e1db@linux.microsoft.com> (raw)
In-Reply-To: <52bb16899e14923b7df195d6c9e68dad6a7a404b.camel@nvidia.com>


Saeed,
>>>> ommit 12cc923f1ccc ("tasklet: Introduce new initialization API")'
>>>> introduced a new tasklet initialization API. This series converts
>>>> all the net/* drivers to use the new tasklet_setup() API
>        ^^^
> this is not all drivers ..

Right, my bad, I should not have said net/*.


> see below
> 
>>>> This series is based on v5.9-rc5
>>>>
>>>> Allen Pais (12):
>>>>     net: mvpp2: Prepare to use the new tasklet API
>>>>     net: arcnet: convert tasklets to use new tasklet_setup() API
>>>>     net: caif: convert tasklets to use new tasklet_setup() API
>>>>     net: ifb: convert tasklets to use new tasklet_setup() API
>>>>     net: ppp: convert tasklets to use new tasklet_setup() API
>>>>     net: cdc_ncm: convert tasklets to use new tasklet_setup() API
>>>>     net: hso: convert tasklets to use new tasklet_setup() API
>>>>     net: lan78xx: convert tasklets to use new tasklet_setup() API
>>>>     net: pegasus: convert tasklets to use new tasklet_setup() API
>>>>     net: r8152: convert tasklets to use new tasklet_setup() API
>>>>     net: rtl8150: convert tasklets to use new tasklet_setup() API
>>>>     net: usbnet: convert tasklets to use new tasklet_setup() API
>>>>
>>>>
>>>
>>> You are only converting drivers which are passing the taskelt
>>> struct as
>>> data ptr, most of other drivers are passing the container of the
>>> tasklet as data, why not convert them as well, and let them use
>>> container_of to find their data ? it is really straight forward and
>>> will help convert most of net driver if not all.
>>>
>>
>> from_tasklet uses container_of internally. use of container_of is
>> avoided cause it end being really long.
> 
> I understand that, what I meant, you didn't really convert all drivers,
> as you claim in the cover letter, all you did is converting __some__
> drivers which are passing the tasklet ptr as data ptr. all other
> drivers that use tasklet_init differently are not converted, and it
> should be relatively easy as i explained above.
> 
> The list of drivers using tasklet_init is longer than what you touched
> in your series:
> 
>   drivers/net/arcnet/arcnet.c                     |  7 +++----
>   drivers/net/caif/caif_virtio.c                  |  8 +++-----
>   drivers/net/ethernet/marvell/mvpp2/mvpp2.h      |  1 +
>   drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c |  1 +
>   drivers/net/ifb.c                               |  7 +++----
>   drivers/net/ppp/ppp_async.c                     |  8 ++++----
>   drivers/net/ppp/ppp_synctty.c                   |  8 ++++----
>   drivers/net/usb/cdc_ncm.c                       |  8 ++++----
>   drivers/net/usb/hso.c                           | 10 +++++-----
>   drivers/net/usb/lan78xx.c                       |  6 +++---
>   drivers/net/usb/pegasus.c                       |  6 +++---
>   drivers/net/usb/r8152.c                         |  8 +++-----
>   drivers/net/usb/rtl8150.c                       |  6 +++---
>   drivers/net/usb/usbnet.c                        |  3 +--
>   14 files changed, 41 insertions(+), 46 deletions(-)
> 
> The full file/driver list :

Yes, drivers/net/ethernet/* drivers/net/wireless/* were submitted as a 
separate series. The rest of them were part of the series above.

I should break it down so that it's easier to bisect.

Thanks.


> 
> $ git grep -l tasklet_init drivers/net/
> drivers/net/arcnet/arcnet.c
> drivers/net/caif/caif_virtio.c
> drivers/net/ethernet/alteon/acenic.c
> drivers/net/ethernet/amd/xgbe/xgbe-drv.c
> drivers/net/ethernet/amd/xgbe/xgbe-i2c.c
> drivers/net/ethernet/amd/xgbe/xgbe-mdio.c
> drivers/net/ethernet/broadcom/cnic.c
> drivers/net/ethernet/cadence/macb_main.c
> drivers/net/ethernet/cavium/liquidio/lio_main.c
> drivers/net/ethernet/cavium/octeon/octeon_mgmt.c
> drivers/net/ethernet/cavium/thunder/nicvf_main.c
> drivers/net/ethernet/chelsio/cxgb/sge.c
> drivers/net/ethernet/chelsio/cxgb3/sge.c
> drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_mqprio.c
> drivers/net/ethernet/chelsio/cxgb4/sge.c
> drivers/net/ethernet/dlink/sundance.c
> drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c
> drivers/net/ethernet/ibm/ehea/ehea_main.c
> drivers/net/ethernet/ibm/ibmvnic.c
> drivers/net/ethernet/jme.c
> drivers/net/ethernet/marvell/skge.c
> drivers/net/ethernet/mellanox/mlx4/eq.c
> drivers/net/ethernet/mellanox/mlx5/core/eq.c
> drivers/net/ethernet/mellanox/mlx5/core/fpga/conn.c
> drivers/net/ethernet/mellanox/mlxsw/pci.c
> drivers/net/ethernet/micrel/ks8842.c
> drivers/net/ethernet/micrel/ksz884x.c
> drivers/net/ethernet/natsemi/ns83820.c
> drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> drivers/net/ethernet/ni/nixge.c
> drivers/net/ethernet/qlogic/qed/qed_int.c
> drivers/net/ethernet/silan/sc92031.c
> drivers/net/ethernet/smsc/smc91x.c
> drivers/net/ifb.c
> drivers/net/ppp/ppp_async.c
> drivers/net/ppp/ppp_synctty.c
> drivers/net/usb/cdc_ncm.c
> drivers/net/usb/hso.c
> drivers/net/usb/lan78xx.c
> drivers/net/usb/pegasus.c
> drivers/net/usb/r8152.c
> drivers/net/usb/rtl8150.c
> drivers/net/wireless/ath/ath11k/pci.c
> drivers/net/wireless/mediatek/mt76/mac80211.c
> drivers/net/wireless/mediatek/mt76/mt7603/init.c
> drivers/net/wireless/mediatek/mt76/mt7615/mmio.c
> drivers/net/wireless/mediatek/mt76/mt76x02_dfs.c
> drivers/net/wireless/mediatek/mt76/mt76x02_mmio.c
> drivers/net/wireless/mediatek/mt76/usb.c
> drivers/net/wireless/mediatek/mt7601u/dma.c
> 

      reply	other threads:[~2020-09-15  4:56 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-14  7:43 Allen Pais
2020-09-14  7:43 ` [RESEND net-next v2 01/12] net: mvpp2: Prepare to use the new tasklet API Allen Pais
2020-09-15  1:02   ` Jakub Kicinski
2020-09-14  7:43 ` [RESEND net-next v2 02/12] net: arcnet: convert tasklets to use new tasklet_setup() API Allen Pais
2020-09-14  7:43 ` [RESEND net-next v2 03/12] net: caif: " Allen Pais
2020-09-14  7:43 ` [RESEND net-next v2 04/12] net: ifb: " Allen Pais
2020-09-14  7:43 ` [RESEND net-next v2 05/12] net: ppp: " Allen Pais
2020-09-14  7:43 ` [RESEND net-next v2 06/12] net: cdc_ncm: " Allen Pais
2020-09-14  7:43 ` [RESEND net-next v2 07/12] net: hso: " Allen Pais
2020-09-14  7:43 ` [RESEND net-next v2 08/12] net: lan78xx: " Allen Pais
2020-09-14  7:43 ` [RESEND net-next v2 09/12] net: pegasus: " Allen Pais
2020-09-14  7:43 ` [RESEND net-next v2 10/12] net: r8152: " Allen Pais
2020-09-14  7:43 ` [RESEND net-next v2 11/12] net: rtl8150: " Allen Pais
2020-09-14  7:43 ` [RESEND net-next v2 12/12] net: usbnet: " Allen Pais
2020-09-14  8:02   ` Oliver Neukum
2020-09-14 20:24 ` [RESEND net-next v2 00/12]drivers: net: " David Miller
2020-09-15  4:20   ` Allen Pais
2020-09-14 21:16 ` Saeed Mahameed
2020-09-15  4:24   ` Allen Pais
2020-09-15  4:41     ` Saeed Mahameed
2020-09-15  4:56       ` Allen Pais [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d9029bd-720d-dc2a-8cbf-8d084fb7e1db@linux.microsoft.com \
    --to=apais@linux.microsoft.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=allen.lkml@gmail.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-ppp@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=m.grzeschik@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=oliver@neukum.org \
    --cc=paulus@samba.org \
    --cc=petkan@nucleusys.com \
    --cc=saeedm@nvidia.com \
    --cc=woojung.huh@microchip.com \
    --subject='Re: [RESEND net-next v2 00/12]drivers: net: convert tasklets to use new tasklet_setup() API' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).