From: Arnd Bergmann <arnd@arndb.de>
To: g.nault@alphalink.fr
Cc: Paul Mackerras <paulus@samba.org>,
linux-ppp@vger.kernel.org, Networking <netdev@vger.kernel.org>,
mitch@sfgoth.com, mostrows@earthlink.net, jchapman@katalix.com,
xeb@mail.ru, David Miller <davem@davemloft.net>,
Al Viro <viro@zeniv.linux.org.uk>,
y2038 Mailman List <y2038@lists.linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Karsten Keil <isdn@linux-pingi.de>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>
Subject: Re: [PATCH net-next 5/5] ppp: handle PPPIOCGIDLE for 64-bit time_t
Date: Thu, 30 Aug 2018 11:47:37 +0000 [thread overview]
Message-ID: <CAK8P3a0B0u7dRajmTKZwXnuxjAiARJJTQguB1RUsEASDbq7TkA@mail.gmail.com> (raw)
In-Reply-To: <20180830110601.GA19534@alphalink.fr>
On Thu, Aug 30, 2018 at 1:06 PM Guillaume Nault <g.nault@alphalink.fr> wrote:
> On Wed, Aug 29, 2018 at 04:03:30PM +0200, Arnd Bergmann wrote:
> > @@ -743,10 +744,17 @@ static long ppp_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
> > err = 0;
> > break;
> >
> > - case PPPIOCGIDLE:
> > - idle.xmit_idle = (jiffies - ppp->last_xmit) / HZ;
> > - idle.recv_idle = (jiffies - ppp->last_recv) / HZ;
> > - if (copy_to_user(argp, &idle, sizeof(idle)))
> > + case PPPIOCGIDLE32:
> > + idle32.xmit_idle = (jiffies - ppp->last_xmit) / HZ;
> > + idle32.recv_idle = (jiffies - ppp->last_recv) / HZ;
> > + if (copy_to_user(argp, &idle32, sizeof(idle32)))
> >
> Missing 'break;'
>
> > + err = 0;
> > + break;
> > +
> > + case PPPIOCGIDLE64:
> > + idle64.xmit_idle = (jiffies - ppp->last_xmit) / HZ;
> > + idle64.recv_idle = (jiffies - ppp->last_recv) / HZ;
> > + if (copy_to_user(argp, &idle32, sizeof(idle32)))
> >
> I guess you meant 'idle64' instead of 'idle32'.
Good catch, fixing up both now.
Thanks for the review!
Arnd
next prev parent reply other threads:[~2018-08-30 11:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 14:03 [PATCH net-next 1/5] pppoe: fix PPPOEIOCSFWD compat handling Arnd Bergmann
2018-08-29 14:03 ` [PATCH net-next 2/5] ppp: move simple ioctl compat handling out of fs_compat_ioctl.c Arnd Bergmann
2018-08-29 14:03 ` [PATCH net-next 3/5] ppp: move PPPIOCSCOMPRESS32 to ppp-generic.c Arnd Bergmann
2018-08-30 11:04 ` Guillaume Nault
2018-08-29 14:03 ` [PATCH net-next 4/5] ppp: move PPPIOCSPASS32/PPPIOCSACTIVE32 to ppp_generic.c Arnd Bergmann
2018-08-30 11:05 ` Guillaume Nault
2018-08-29 14:03 ` [PATCH net-next 5/5] ppp: handle PPPIOCGIDLE for 64-bit time_t Arnd Bergmann
2018-08-30 11:06 ` Guillaume Nault
2018-08-30 11:47 ` Arnd Bergmann [this message]
2018-08-30 11:04 ` [PATCH net-next 1/5] pppoe: fix PPPOEIOCSFWD compat handling Guillaume Nault
2018-08-30 11:54 ` Arnd Bergmann
2018-08-30 13:09 ` Guillaume Nault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a0B0u7dRajmTKZwXnuxjAiARJJTQguB1RUsEASDbq7TkA@mail.gmail.com \
--to=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=g.nault@alphalink.fr \
--cc=isdn@linux-pingi.de \
--cc=jchapman@katalix.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=mitch@sfgoth.com \
--cc=mostrows@earthlink.net \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=viro@zeniv.linux.org.uk \
--cc=xeb@mail.ru \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).