archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <>
To: Kees Cook <>
Cc: Paul Mackerras <>,
	"David S. Miller" <>,
	Herbert Xu <>,
	Eric Biggers <>,
	"Gustavo A. R. Silva" <>,, Networking <>,
	Linux Kernel Mailing List <>
Subject: Re: [PATCH] ppp: mppe: Remove VLA usage
Date: Mon, 16 Jul 2018 11:01:34 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20180716040516.GA32783@beast>

On Mon, Jul 16, 2018 at 6:05 AM, Kees Cook <> wrote:
> In the quest to remove all stack VLA usage from the kernel[1], this
> removes the discouraged use of AHASH_REQUEST_ON_STACK (and associated
> VLA) by switching to shash directly and keeping the associated descriptor
> allocated with the regular state on the heap.
> [1]
> Signed-off-by: Kees Cook <>

I had concerns at first that this approach might make it slower, but
upon reading through implementation of the shash_ahash_ implementation,
I concluded that it can only be better than before, improving both
performance and stack usage.

Acked-by: Arnd Bergmann <>

  reply	other threads:[~2018-07-16 11:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-16  4:05 Kees Cook
2018-07-16 11:01 ` Arnd Bergmann [this message]
2018-08-02 23:27   ` Kees Cook
2018-08-03  3:13     ` Paul Mackerras
2018-07-16 17:36 ` Eric Biggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] ppp: mppe: Remove VLA usage' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).