From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?David_Bala=C5=BEic?= Date: Wed, 06 May 2020 15:39:20 +0000 Subject: Re: PPPoE Modem hangup after random time - how to debug? Message-Id: List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: linux-ppp@vger.kernel.org On Wed, 6 May 2020 at 16:26, Guillaume Nault wrote: > > On Wed, May 06, 2020 at 11:52:48AM +0200, David Balažic wrote: > > On Mon, 4 May 2020 at 20:12, Guillaume Nault wrote: > > > > > > On Mon, May 04, 2020 at 06:36:48PM +0200, David Balažic wrote: > > > > On Mon, 4 May 2020 at 15:01, Guillaume Nault wrote: > > > > > You can use "%pM" for printing MAC addresses. Also, it'd be interesting > > > > > to have information about promisc mode: > > > > > "dev %s, flags: %#x, promiscuity %u", > > > > > dev->name, dev->flags, dev->promiscuity, > > > > > > > > > > > I'll report later values printed when a stray PADT appears. > > > > > > > Okay, but please keep printing the destination MAC address of the > > > packet. I was providing the flags/promiscuity string just to get extra > > > information, not to replace your original log. > > > > This was logged now: > > > > (all at May 6 05:34:50 2020 UTC) > > pppoe_disc_rcv PADT received, sid=1, SRC: a4:7b:2c:9e:c7:44, DST: > > 44:4e:6d:fd:c7:39 > > pppoe_disc_rcv PADT received, own hw addr: c4:XX:XX:XX:XX:ed > > dev eth1.3902, flags: 0x1003, promiscuity 0 > > pppoe_disc_rcv PADT received, not four our address, ignoring > > > > (the last line is from my fix, the connection is now not dropped when > > the PADT is not for us; works fine, my connection stays up and > > working) > > > Looks like a more fundamental issue. This frame shouldn't have been > accepted in the first place. Can you also print the packet class > ("... pkt_type %u", ..., skb->pkt_type)? After fixing it, the priority of this issue really dropped on my task list. Maybe someone has a similar hardware and can test? It is an Atheros AR7161 SoC. (full HW info on the openwrt.org pages, look for Netgear WNDR3700v2)