From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D468C2C6BB for ; Mon, 19 Feb 2024 11:46:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708343175; cv=none; b=Zyqmf66SEN93rbGGAucPzqdcgl826DiJn3Tgz5Kan9C16bsqhrp8WKcTcBB9d5RC8hnibjtOXqYtnOQbm93nbwzfax/SX7+zDlJuvcUJgfPgkTimFOKOmO/bk5uEmeiST5BP8BMvnnj0IVb07d9JE2sp52K6TI7G55fvVALgQ7I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708343175; c=relaxed/simple; bh=4ZD/Ak4Shixqt+hRFej2u9n/4j5VFvBfGQlSNWdsOZ8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NVFvBKc+SYdYP4Ob7lli9l+5uP6Kez6IaBvnHdWJKuRlBgDyUnu76ykJHE5yFo0cQ5cIRCXOzqPIigwWw7Q6qhCwEY97lN8Y1SC2mMYAsJeTWOpn1MNqLlygeHFljbOwXlNDMj1eGVNRpAVhGY4TBk+KQl/U8NkG1btfLtX/KTs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=QnDjsIP5; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QnDjsIP5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708343172; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4ZD/Ak4Shixqt+hRFej2u9n/4j5VFvBfGQlSNWdsOZ8=; b=QnDjsIP5/Nx0J4Ft7kaySQAC2ZhAezEqVRib/Qi4bG4q3HNSCOOlfXvvcyzF04LF6cLOMn awxyFoovIgrAO6wBPaHbtGd1AlktIZu3YXvKtnbZuSztUONRPrZZfeIVN90Kiim+7nD/rY 8LlMSdMAX/HpHJzsmzbK6kECnfDyg/I= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-42-f-RFMcTuMUaABt_Pi7dH9A-1; Mon, 19 Feb 2024 06:46:11 -0500 X-MC-Unique: f-RFMcTuMUaABt_Pi7dH9A-1 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-42e054eef08so17635461cf.2 for ; Mon, 19 Feb 2024 03:46:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708343171; x=1708947971; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4ZD/Ak4Shixqt+hRFej2u9n/4j5VFvBfGQlSNWdsOZ8=; b=JJPzykrVSrzLumJelkgQrNJINxrmW4bvbINbZtPOgDptyFOKG/er0dhctSGzBFg/uX onKkbinT587HGdW0AKfLYT4SB/vCQylvqY7dC51dLNLTy0sCD1R8OwDQFAaZJNAawVt7 DHQGXVGrfXSMB/bvQ/K1u1ST5TQ8mAtQkPJayJSIx1Mo69d1640Fy/s9KbFoqDKInF8v 0lpnhzpNwa9NnK9f9EjXrXTb9DxEqE7+wVOPD0wKJntlh+9D6FzESIvyPEDT2VO73Cg8 Ay+c7ZPoOxQmk0CkwMhMhCxPpQ/XeYAqUZmAFiHFY3kWMq5+F/6kmQAaaULbmwfS4TVT qbEg== X-Forwarded-Encrypted: i=1; AJvYcCWTiTafm1407140Ur3kF9YT5L9EYvr+7vIgQmSvF9EqlI4lVGj3AtrGo33/zU22Qit56CrCn7/lXY9TqXgtKwJHMraStL7L0gpl X-Gm-Message-State: AOJu0YwxUezNji/IcqrJPDyx1mcKgRErhFJ4Ex7WSu1ZXp2iCaid32vS htsh9JoVKaBu7nmSAAdT41U7r+EvyRpxw+0dHowqhkCHWWJ/MEf6+ybA4gibQ3xecaD4zZJlriC lyhfLYXbQsnM6YJu4OBQieRBX1Tc2U+9o12BdGnNBKS9+CqmtE0d45SjOCw== X-Received: by 2002:a05:622a:4f:b0:42c:7bfc:8068 with SMTP id y15-20020a05622a004f00b0042c7bfc8068mr18270859qtw.11.1708343171123; Mon, 19 Feb 2024 03:46:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IFiNw4DCsKkz2RLLVtfw6QNV6TRlA/lysd4gQNMYeIoLrM5/4vWlvVZ/26MqBKbSbHaFvNgsA== X-Received: by 2002:a05:622a:4f:b0:42c:7bfc:8068 with SMTP id y15-20020a05622a004f00b0042c7bfc8068mr18270830qtw.11.1708343170853; Mon, 19 Feb 2024 03:46:10 -0800 (PST) Received: from debian (2a01cb058d23d600e55283140c56efd3.ipv6.abo.wanadoo.fr. [2a01:cb05:8d23:d600:e552:8314:c56:efd3]) by smtp.gmail.com with ESMTPSA id t13-20020a05622a180d00b0042d0995a040sm2444657qtc.62.2024.02.19.03.46.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 03:46:10 -0800 (PST) Date: Mon, 19 Feb 2024 12:46:06 +0100 From: Guillaume Nault To: "Ricardo B. Marliere" Cc: Oliver Neukum , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Florian Fainelli , Vladimir Oltean , Roopa Prabhu , Nikolay Aleksandrov , Loic Poulain , Sergey Ryazanov , Johannes Berg , netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, bridge@lists.linux.dev, linux-ppp@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH 08/12] net: l2tp: constify the struct device_type usage Message-ID: References: <20240217-device_cleanup-net-v1-0-1eb31fb689f7@marliere.net> <20240217-device_cleanup-net-v1-8-1eb31fb689f7@marliere.net> Precedence: bulk X-Mailing-List: linux-ppp@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240217-device_cleanup-net-v1-8-1eb31fb689f7@marliere.net> On Sat, Feb 17, 2024 at 05:13:30PM -0300, Ricardo B. Marliere wrote: > Since commit aed65af1cc2f ("drivers: make device_type const"), the driver > core can properly handle constant struct device_type. Move the l2tpeth_type > variable to be a constant structure as well, placing it into read-only > memory which can not be modified at runtime. Reviewed-by: Guillaume Nault