linux-ppp.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthias Schiffer <mschiffer@universe-factory.net>
To: David Ahern <dsahern@gmail.com>,
	dledford@redhat.com, sean.hefty@intel.com,
	hal.rosenstock@gmail.com, j.vosburgh@gmail.com,
	vfalico@gmail.com, andy@greyhouse.net, wg@grandegger.com,
	mkl@pengutronix.de, pablo@netfilter.org, laforge@gnumonks.org,
	paulus@samba.org, jiri@resnulli.us, dsa@cumulusnetworks.com,
	shm@cumulusnetworks.com, davem@davemloft.net,
	stephen@networkplumber.org, arvid.brodin@alten.se,
	alex.aring@gmail.com, stefan@osg.samsung.com,
	kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org,
	kaber@trash.net, steffen.klassert@secunet.com,
	herbert@gondor.apana.org.au, johannes@sipsolutions.net
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, linux-can@vger.kernel.org,
	linux-ppp@vger.kernel.org, linux-wpan@vger.kernel.org
Subject: Re: [PATCH net-next v2 4/5] net: add netlink_ext_ack argument to rtnl_link_ops.slave_changelink
Date: Mon, 26 Jun 2017 13:45:31 +0000	[thread overview]
Message-ID: <bb1892a4-2227-cdc4-e017-f39f133fd20a@universe-factory.net> (raw)
In-Reply-To: <27b8d607-7442-0a42-1389-9548840445dc@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 966 bytes --]

On 06/26/2017 03:33 PM, David Ahern wrote:
> On 6/26/17 2:43 AM, Matthias Schiffer wrote:
>> On 06/26/2017 06:08 AM, David Ahern wrote:
>>> On 6/25/17 10:04 PM, David Ahern wrote:
>>>> On 6/25/17 3:56 PM, Matthias Schiffer wrote:
>>>>> Add support for extended error reporting.
>>>>>
>>>>> Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
>>>>> ---
>>>>
>>>>
>>>> Acked-by: David Ahern <dsahern@gmail.com>
>>>>
>>>
>>> Actually, you are missing the chagne to br_port_slave_changelink.
>>>
>>
>> I'm confused. I am changing br_port_slave_changelink? All my patches are
>> compile-tested.
>>
> 
> You are changing the signature of slave_changelink, no?
> 
> net/bridge/br_netlink.c:
>         .slave_changelink       = br_port_slave_changelink,
> 


Please read my patch again, I *am* changing br_port_slave_changelink to
match the new signature (this is the net/bridge/br_netlink.c change
appearing in the diffstat).


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-06-26 13:45 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-25 21:55 [PATCH net-next v2 0/5] net: add netlink_ext_ack support to rtnl_link_ops Matthias Schiffer
2017-06-25 21:55 ` [PATCH net-next v2 1/5] net: add netlink_ext_ack argument to rtnl_link_ops.newlink Matthias Schiffer
2017-06-26  4:02   ` David Ahern
2017-06-25 21:56 ` [PATCH net-next v2 2/5] net: add netlink_ext_ack argument to rtnl_link_ops.changelink Matthias Schiffer
2017-06-26  4:03   ` David Ahern
2017-06-25 21:56 ` [PATCH net-next v2 3/5] net: add netlink_ext_ack argument to rtnl_link_ops.validate Matthias Schiffer
     [not found]   ` <51f1b1e0b81216ce08a2c846c7eac6fb58e9d667.1498425679.git.mschiffer-Nyw9WiXk/RKXhJHkyCwd5uTW4wlIGRCZ@public.gmane.org>
2017-06-26  4:04     ` David Ahern
2017-06-25 21:56 ` [PATCH net-next v2 4/5] net: add netlink_ext_ack argument to rtnl_link_ops.slave_changelink Matthias Schiffer
2017-06-26  4:04   ` David Ahern
     [not found]     ` <b097a69e-4449-b124-c39e-4dbdbae7c218-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-06-26  4:08       ` David Ahern
2017-06-26  8:43         ` Matthias Schiffer
2017-06-26 13:33           ` David Ahern
2017-06-26 13:45             ` Matthias Schiffer [this message]
2017-06-26 13:47               ` David Ahern
2017-06-25 21:56 ` [PATCH net-next v2 5/5] net: add netlink_ext_ack argument to rtnl_link_ops.slave_validate Matthias Schiffer
2017-06-26  4:05   ` David Ahern
2017-06-26  4:08     ` David Ahern
2017-06-27  3:13 ` [PATCH net-next v2 0/5] net: add netlink_ext_ack support to rtnl_link_ops David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb1892a4-2227-cdc4-e017-f39f133fd20a@universe-factory.net \
    --to=mschiffer@universe-factory.net \
    --cc=alex.aring@gmail.com \
    --cc=andy@greyhouse.net \
    --cc=arvid.brodin@alten.se \
    --cc=davem@davemloft.net \
    --cc=dledford@redhat.com \
    --cc=dsa@cumulusnetworks.com \
    --cc=dsahern@gmail.com \
    --cc=hal.rosenstock@gmail.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=j.vosburgh@gmail.com \
    --cc=jiri@resnulli.us \
    --cc=jmorris@namei.org \
    --cc=johannes@sipsolutions.net \
    --cc=kaber@trash.net \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=laforge@gnumonks.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-ppp@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux-wpan@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=paulus@samba.org \
    --cc=sean.hefty@intel.com \
    --cc=shm@cumulusnetworks.com \
    --cc=stefan@osg.samsung.com \
    --cc=steffen.klassert@secunet.com \
    --cc=stephen@networkplumber.org \
    --cc=vfalico@gmail.com \
    --cc=wg@grandegger.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).