From: James Carlson <carlsonj@workingcode.com>
To: linux-ppp@vger.kernel.org
Subject: Re: [PATCH] time.h: include header before using time_t
Date: Fri, 04 Oct 2019 17:52:11 +0000 [thread overview]
Message-ID: <d5c7a914-6e48-e4a7-3d6b-11807872ea5b@workingcode.com> (raw)
In-Reply-To: <20191004174046.GA868@x1.vandijck-laurijssen.be>
On 10/04/19 13:40, Kurt Van Dijck wrote:
> I think you confirm 4x what I said, but I probably expressed myself
> badly, so "show me code!", I created this patch.
> It (1) works for me and (2) does not mix userspace headers in kernel
> space anywhere.
> Would this work for you?
That seems ok, in as much as it compiles on Solaris. But I'm still a
little confused about your apparent opposition to <sys/time.h> at the
point where time_t is actually used.
<sys/time.h> is part of the UNIX standards. It's documented to define
time_t (among other things). It's on-point for a header file that may
be used in kernel context. What's the concern?
--
James Carlson 42.703N 71.076W <carlsonj@workingcode.com>
next prev parent reply other threads:[~2019-10-04 17:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 17:40 [PATCH] time.h: include header before using time_t Kurt Van Dijck
2019-10-04 17:52 ` James Carlson [this message]
2019-10-04 18:33 ` Kurt Van Dijck
2019-10-04 20:10 ` James Carlson
2019-12-01 11:21 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5c7a914-6e48-e4a7-3d6b-11807872ea5b@workingcode.com \
--to=carlsonj@workingcode.com \
--cc=linux-ppp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).