linux-pwm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/4] soc: amlogic: switch bindings to yaml and adjust some dtbs's
@ 2023-02-01 19:57 Heiner Kallweit
  2023-02-01 19:58 ` [PATCH 1/4] arm: dts: meson: adjust order of some compatibles Heiner Kallweit
                   ` (5 more replies)
  0 siblings, 6 replies; 16+ messages in thread
From: Heiner Kallweit @ 2023-02-01 19:57 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Neil Armstrong, Kevin Hilman,
	Jerome Brunet, Martin Blumenstingl, Marc Zyngier,
	Thomas Gleixner, Uwe Kleine-König, Thierry Reding
  Cc: devicetree, open list:ARM/Amlogic Meson..., linux-arm-kernel, linux-pwm

Switch two Amlogic Meson bindings to yaml. As prerequisite adjust the
order of some compatibles first.

New versions of the bindings have been submitted as individual
patches in between. Put it into a series again.

Heiner Kallweit (4):
  arm: dts: meson: adjust order of some compatibles
  arm64: dts: meson: adjust order of some compatibles
  dt-bindings: pwm: Convert Amlogic Meson PWM binding
  dt-bindings: interrupt-controller: Convert Amlogic Meson GPIO
    interrupt controller binding

 .../amlogic,meson-gpio-intc.txt               | 38 ----------
 .../amlogic,meson-gpio-intc.yaml              | 72 +++++++++++++++++++
 .../devicetree/bindings/pwm/pwm-amlogic.yaml  | 70 ++++++++++++++++++
 .../devicetree/bindings/pwm/pwm-meson.txt     | 29 --------
 arch/arm/boot/dts/meson8b.dtsi                |  4 +-
 arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi   |  4 +-
 arch/arm64/boot/dts/amlogic/meson-gxl.dtsi    |  4 +-
 7 files changed, 148 insertions(+), 73 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt
 create mode 100644 Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml
 create mode 100644 Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
 delete mode 100644 Documentation/devicetree/bindings/pwm/pwm-meson.txt

-- 
2.39.1


^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH 1/4] arm: dts: meson: adjust order of some compatibles
  2023-02-01 19:57 [PATCH 0/4] soc: amlogic: switch bindings to yaml and adjust some dtbs's Heiner Kallweit
@ 2023-02-01 19:58 ` Heiner Kallweit
  2023-02-03  8:05   ` Neil Armstrong
  2023-02-04 23:06   ` Martin Blumenstingl
  2023-02-01 19:59 ` [PATCH 2/4] arm64: " Heiner Kallweit
                   ` (4 subsequent siblings)
  5 siblings, 2 replies; 16+ messages in thread
From: Heiner Kallweit @ 2023-02-01 19:58 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Neil Armstrong, Kevin Hilman,
	Jerome Brunet, Martin Blumenstingl, Marc Zyngier,
	Thomas Gleixner, Uwe Kleine-König, Thierry Reding
  Cc: devicetree, open list:ARM/Amlogic Meson..., linux-arm-kernel, linux-pwm

During review of a new yaml binding, affecting these dts, it turned out
that some compatibles aren't ordered as they should be. Order should be
most specific to least specific.

Suggested-by: Rob Herring <robh+dt@kernel.org>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 arch/arm/boot/dts/meson8b.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi
index d5a3fe21e..5979209fe 100644
--- a/arch/arm/boot/dts/meson8b.dtsi
+++ b/arch/arm/boot/dts/meson8b.dtsi
@@ -580,8 +580,8 @@ &ethmac {
 };
 
 &gpio_intc {
-	compatible = "amlogic,meson-gpio-intc",
-		     "amlogic,meson8b-gpio-intc";
+	compatible = "amlogic,meson8b-gpio-intc",
+		     "amlogic,meson-gpio-intc";
 	status = "okay";
 };
 
-- 
2.39.1



^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH 2/4] arm64: dts: meson: adjust order of some compatibles
  2023-02-01 19:57 [PATCH 0/4] soc: amlogic: switch bindings to yaml and adjust some dtbs's Heiner Kallweit
  2023-02-01 19:58 ` [PATCH 1/4] arm: dts: meson: adjust order of some compatibles Heiner Kallweit
@ 2023-02-01 19:59 ` Heiner Kallweit
  2023-02-03  8:05   ` Neil Armstrong
  2023-02-04 23:07   ` Martin Blumenstingl
  2023-02-01 20:00 ` [PATCH 3/4] dt-bindings: pwm: Convert Amlogic Meson PWM binding Heiner Kallweit
                   ` (3 subsequent siblings)
  5 siblings, 2 replies; 16+ messages in thread
From: Heiner Kallweit @ 2023-02-01 19:59 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Neil Armstrong, Kevin Hilman,
	Jerome Brunet, Martin Blumenstingl, Marc Zyngier,
	Thomas Gleixner, Uwe Kleine-König, Thierry Reding
  Cc: devicetree, open list:ARM/Amlogic Meson..., linux-arm-kernel, linux-pwm

During review of a new yaml binding, affecting these dts, it turned out
that some compatibles aren't ordered as they should be. Order should be
most specific to least specific.

Suggested-by: Rob Herring <robh+dt@kernel.org>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 4 ++--
 arch/arm64/boot/dts/amlogic/meson-gxl.dtsi  | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
index 923d2d8bb..12ef6e81c 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
@@ -300,8 +300,8 @@ &ethmac {
 };
 
 &gpio_intc {
-	compatible = "amlogic,meson-gpio-intc",
-		     "amlogic,meson-gxbb-gpio-intc";
+	compatible = "amlogic,meson-gxbb-gpio-intc",
+		     "amlogic,meson-gpio-intc";
 	status = "okay";
 };
 
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
index 04e9d0f1b..af912f698 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
@@ -312,8 +312,8 @@ &clkc_AO {
 };
 
 &gpio_intc {
-	compatible = "amlogic,meson-gpio-intc",
-		     "amlogic,meson-gxl-gpio-intc";
+	compatible = "amlogic,meson-gxl-gpio-intc",
+		     "amlogic,meson-gpio-intc";
 	status = "okay";
 };
 
-- 
2.39.1



^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH 3/4] dt-bindings: pwm: Convert Amlogic Meson PWM binding
  2023-02-01 19:57 [PATCH 0/4] soc: amlogic: switch bindings to yaml and adjust some dtbs's Heiner Kallweit
  2023-02-01 19:58 ` [PATCH 1/4] arm: dts: meson: adjust order of some compatibles Heiner Kallweit
  2023-02-01 19:59 ` [PATCH 2/4] arm64: " Heiner Kallweit
@ 2023-02-01 20:00 ` Heiner Kallweit
  2023-02-06  8:23   ` Uwe Kleine-König
  2023-02-06  8:54   ` Uwe Kleine-König
  2023-02-01 20:02 ` [PATCH 4/4] dt-bindings: interrupt-controller: Convert Amlogic Meson GPIO interrupt controller binding Heiner Kallweit
                   ` (2 subsequent siblings)
  5 siblings, 2 replies; 16+ messages in thread
From: Heiner Kallweit @ 2023-02-01 20:00 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Neil Armstrong, Kevin Hilman,
	Jerome Brunet, Martin Blumenstingl, Marc Zyngier,
	Thomas Gleixner, Uwe Kleine-König, Thierry Reding
  Cc: devicetree, open list:ARM/Amlogic Meson..., linux-arm-kernel, linux-pwm

Convert Amlogic Meson PWM binding to yaml.

Reviewed-by: Rob Herring <robh+dt@kernel.org>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 .../devicetree/bindings/pwm/pwm-amlogic.yaml  | 70 +++++++++++++++++++
 .../devicetree/bindings/pwm/pwm-meson.txt     | 29 --------
 2 files changed, 70 insertions(+), 29 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
 delete mode 100644 Documentation/devicetree/bindings/pwm/pwm-meson.txt

diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
new file mode 100644
index 000000000..527864a4d
--- /dev/null
+++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
@@ -0,0 +1,70 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pwm/pwm-amlogic.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Amlogic PWM
+
+maintainers:
+  - Heiner Kallweit <hkallweit1@gmail.com>
+
+allOf:
+  - $ref: pwm.yaml#
+
+properties:
+  compatible:
+    oneOf:
+      - enum:
+          - amlogic,meson8b-pwm
+          - amlogic,meson-gxbb-pwm
+          - amlogic,meson-gxbb-ao-pwm
+          - amlogic,meson-axg-ee-pwm
+          - amlogic,meson-axg-ao-pwm
+          - amlogic,meson-g12a-ee-pwm
+          - amlogic,meson-g12a-ao-pwm-ab
+          - amlogic,meson-g12a-ao-pwm-cd
+          - amlogic,meson-s4-pwm
+      - items:
+          - const: amlogic,meson-gx-pwm
+          - const: amlogic,meson-gxbb-pwm
+      - items:
+          - const: amlogic,meson-gx-ao-pwm
+          - const: amlogic,meson-gxbb-ao-pwm
+      - items:
+          - const: amlogic,meson8-pwm
+          - const: amlogic,meson8b-pwm
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    minItems: 1
+    maxItems: 2
+
+  clock-names:
+    oneOf:
+      - items:
+          - enum: [clkin0, clkin1]
+      - items:
+          - const: clkin0
+          - const: clkin1
+
+  "#pwm-cells":
+    const: 3
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    pwm@8550 {
+      compatible = "amlogic,meson-gxbb-pwm";
+      reg = <0x08550 0x10>;
+      clocks = <&xtal>, <&xtal>;
+      clock-names = "clkin0", "clkin1";
+      #pwm-cells = <3>;
+    };
diff --git a/Documentation/devicetree/bindings/pwm/pwm-meson.txt b/Documentation/devicetree/bindings/pwm/pwm-meson.txt
deleted file mode 100644
index bd02b0a14..000000000
--- a/Documentation/devicetree/bindings/pwm/pwm-meson.txt
+++ /dev/null
@@ -1,29 +0,0 @@
-Amlogic Meson PWM Controller
-============================
-
-Required properties:
-- compatible: Shall contain "amlogic,meson8b-pwm"
-                         or "amlogic,meson-gxbb-pwm"
-                         or "amlogic,meson-gxbb-ao-pwm"
-                         or "amlogic,meson-axg-ee-pwm"
-                         or "amlogic,meson-axg-ao-pwm"
-                         or "amlogic,meson-g12a-ee-pwm"
-                         or "amlogic,meson-g12a-ao-pwm-ab"
-                         or "amlogic,meson-g12a-ao-pwm-cd"
-- #pwm-cells: Should be 3. See pwm.yaml in this directory for a description of
-  the cells format.
-
-Optional properties:
-- clocks: Could contain one or two parents clocks phandle for each of the two
-  PWM channels.
-- clock-names: Could contain at least the "clkin0" and/or "clkin1" names.
-
-Example:
-
-	pwm_ab: pwm@8550 {
-		compatible = "amlogic,meson-gxbb-pwm";
-		reg = <0x0 0x08550 0x0 0x10>;
-		#pwm-cells = <3>;
-		clocks = <&xtal>, <&xtal>;
-		clock-names = "clkin0", "clkin1";
-	}
-- 
2.39.1



^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH 4/4] dt-bindings: interrupt-controller: Convert Amlogic Meson GPIO interrupt controller binding
  2023-02-01 19:57 [PATCH 0/4] soc: amlogic: switch bindings to yaml and adjust some dtbs's Heiner Kallweit
                   ` (2 preceding siblings ...)
  2023-02-01 20:00 ` [PATCH 3/4] dt-bindings: pwm: Convert Amlogic Meson PWM binding Heiner Kallweit
@ 2023-02-01 20:02 ` Heiner Kallweit
  2023-02-02 23:54   ` Rob Herring
  2023-03-06  9:19 ` (subset) [PATCH 0/4] soc: amlogic: switch bindings to yaml and adjust some dtbs's Neil Armstrong
  2023-03-06  9:21 ` Neil Armstrong
  5 siblings, 1 reply; 16+ messages in thread
From: Heiner Kallweit @ 2023-02-01 20:02 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Neil Armstrong, Kevin Hilman,
	Jerome Brunet, Martin Blumenstingl, Marc Zyngier,
	Thomas Gleixner, Uwe Kleine-König, Thierry Reding
  Cc: devicetree, open list:ARM/Amlogic Meson..., linux-arm-kernel, linux-pwm

Convert Amlogic Meson GPIO interrupt controller binding to yaml.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
- consider that more than one compatible may be set
- remove bus part from example
- remove minItem/maxItem properties for compatible
- reduce compatible fallback complexity
---
 .../amlogic,meson-gpio-intc.txt               | 38 ----------
 .../amlogic,meson-gpio-intc.yaml              | 72 +++++++++++++++++++
 2 files changed, 72 insertions(+), 38 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt
 create mode 100644 Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml

diff --git a/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt
deleted file mode 100644
index bde63f8f0..000000000
--- a/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt
+++ /dev/null
@@ -1,38 +0,0 @@
-Amlogic meson GPIO interrupt controller
-
-Meson SoCs contains an interrupt controller which is able to watch the SoC
-pads and generate an interrupt on edge or level. The controller is essentially
-a 256 pads to 8 GIC interrupt multiplexer, with a filter block to select edge
-or level and polarity. It does not expose all 256 mux inputs because the
-documentation shows that the upper part is not mapped to any pad. The actual
-number of interrupt exposed depends on the SoC.
-
-Required properties:
-
-- compatible : must have "amlogic,meson8-gpio-intc" and either
-    "amlogic,meson8-gpio-intc" for meson8 SoCs (S802) or
-    "amlogic,meson8b-gpio-intc" for meson8b SoCs (S805) or
-    "amlogic,meson-gxbb-gpio-intc" for GXBB SoCs (S905) or
-    "amlogic,meson-gxl-gpio-intc" for GXL SoCs (S905X, S912)
-    "amlogic,meson-axg-gpio-intc" for AXG SoCs (A113D, A113X)
-    "amlogic,meson-g12a-gpio-intc" for G12A SoCs (S905D2, S905X2, S905Y2)
-    "amlogic,meson-sm1-gpio-intc" for SM1 SoCs (S905D3, S905X3, S905Y3)
-    "amlogic,meson-a1-gpio-intc" for A1 SoCs (A113L)
-    "amlogic,meson-s4-gpio-intc" for S4 SoCs (S802X2, S905Y4, S805X2G, S905W2)
-- reg : Specifies base physical address and size of the registers.
-- interrupt-controller : Identifies the node as an interrupt controller.
-- #interrupt-cells : Specifies the number of cells needed to encode an
-   interrupt source. The value must be 2.
-- meson,channel-interrupts: Array with the 8 upstream hwirq numbers. These
-   are the hwirqs used on the parent interrupt controller.
-
-Example:
-
-gpio_interrupt: interrupt-controller@9880 {
-	compatible = "amlogic,meson-gxbb-gpio-intc",
-		     "amlogic,meson-gpio-intc";
-	reg = <0x0 0x9880 0x0 0x10>;
-	interrupt-controller;
-	#interrupt-cells = <2>;
-	meson,channel-interrupts = <64 65 66 67 68 69 70 71>;
-};
diff --git a/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml
new file mode 100644
index 000000000..fe7ef1916
--- /dev/null
+++ b/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml
@@ -0,0 +1,72 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/interrupt-controller/amlogic,meson-gpio-intc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Amlogic Meson GPIO interrupt controller
+
+maintainers:
+  - Heiner Kallweit <hkallweit1@gmail.com>
+
+description: |
+  Meson SoCs contains an interrupt controller which is able to watch the SoC
+  pads and generate an interrupt on edge or level. The controller is essentially
+  a 256 pads to 8 GIC interrupt multiplexer, with a filter block to select edge
+  or level and polarity. It does not expose all 256 mux inputs because the
+  documentation shows that the upper part is not mapped to any pad. The actual
+  number of interrupt exposed depends on the SoC.
+
+allOf:
+  - $ref: /schemas/interrupt-controller.yaml#
+
+properties:
+  compatible:
+    oneOf:
+      - const: amlogic,meson-gpio-intc
+      - items:
+          - enum:
+              - amlogic,meson8-gpio-intc
+              - amlogic,meson8b-gpio-intc
+              - amlogic,meson-gxbb-gpio-intc
+              - amlogic,meson-gxl-gpio-intc
+              - amlogic,meson-axg-gpio-intc
+              - amlogic,meson-g12a-gpio-intc
+              - amlogic,meson-sm1-gpio-intc
+              - amlogic,meson-a1-gpio-intc
+              - amlogic,meson-s4-gpio-intc
+          - const: amlogic,meson-gpio-intc
+
+  reg:
+    maxItems: 1
+
+  interrupt-controller: true
+
+  "#interrupt-cells":
+    const: 2
+
+  amlogic,channel-interrupts:
+    description: Array with the upstream hwirq numbers
+    minItems: 8
+    maxItems: 12
+    $ref: /schemas/types.yaml#/definitions/uint32-array
+
+required:
+  - compatible
+  - reg
+  - interrupt-controller
+  - "#interrupt-cells"
+  - amlogic,channel-interrupts
+
+additionalProperties: false
+
+examples:
+  - |
+    interrupt-controller@9880 {
+      compatible = "amlogic,meson-gxbb-gpio-intc",
+                   "amlogic,meson-gpio-intc";
+      reg = <0x9880 0x10>;
+      interrupt-controller;
+      #interrupt-cells = <2>;
+      amlogic,channel-interrupts = <64 65 66 67 68 69 70 71>;
+    };
-- 
2.39.1



^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: [PATCH 4/4] dt-bindings: interrupt-controller: Convert Amlogic Meson GPIO interrupt controller binding
  2023-02-01 20:02 ` [PATCH 4/4] dt-bindings: interrupt-controller: Convert Amlogic Meson GPIO interrupt controller binding Heiner Kallweit
@ 2023-02-02 23:54   ` Rob Herring
  0 siblings, 0 replies; 16+ messages in thread
From: Rob Herring @ 2023-02-02 23:54 UTC (permalink / raw)
  To: Heiner Kallweit
  Cc: Uwe Kleine-König, Krzysztof Kozlowski, linux-pwm,
	Thomas Gleixner, open list:ARM/Amlogic Meson...,
	devicetree, Thierry Reding, Kevin Hilman, linux-arm-kernel,
	Jerome Brunet, Martin Blumenstingl, Neil Armstrong, Rob Herring,
	Marc Zyngier


On Wed, 01 Feb 2023 21:02:02 +0100, Heiner Kallweit wrote:
> Convert Amlogic Meson GPIO interrupt controller binding to yaml.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> - consider that more than one compatible may be set
> - remove bus part from example
> - remove minItem/maxItem properties for compatible
> - reduce compatible fallback complexity
> ---
>  .../amlogic,meson-gpio-intc.txt               | 38 ----------
>  .../amlogic,meson-gpio-intc.yaml              | 72 +++++++++++++++++++
>  2 files changed, 72 insertions(+), 38 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt
>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 1/4] arm: dts: meson: adjust order of some compatibles
  2023-02-01 19:58 ` [PATCH 1/4] arm: dts: meson: adjust order of some compatibles Heiner Kallweit
@ 2023-02-03  8:05   ` Neil Armstrong
  2023-02-04 23:06   ` Martin Blumenstingl
  1 sibling, 0 replies; 16+ messages in thread
From: Neil Armstrong @ 2023-02-03  8:05 UTC (permalink / raw)
  To: Heiner Kallweit, Rob Herring, Krzysztof Kozlowski, Kevin Hilman,
	Jerome Brunet, Martin Blumenstingl, Marc Zyngier,
	Thomas Gleixner, Uwe Kleine-König, Thierry Reding
  Cc: devicetree, open list:ARM/Amlogic Meson..., linux-arm-kernel, linux-pwm

On 01/02/2023 20:58, Heiner Kallweit wrote:
> During review of a new yaml binding, affecting these dts, it turned out
> that some compatibles aren't ordered as they should be. Order should be
> most specific to least specific.
> 
> Suggested-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
>   arch/arm/boot/dts/meson8b.dtsi | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi
> index d5a3fe21e..5979209fe 100644
> --- a/arch/arm/boot/dts/meson8b.dtsi
> +++ b/arch/arm/boot/dts/meson8b.dtsi
> @@ -580,8 +580,8 @@ &ethmac {
>   };
>   
>   &gpio_intc {
> -	compatible = "amlogic,meson-gpio-intc",
> -		     "amlogic,meson8b-gpio-intc";
> +	compatible = "amlogic,meson8b-gpio-intc",
> +		     "amlogic,meson-gpio-intc";
>   	status = "okay";
>   };
>   

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 2/4] arm64: dts: meson: adjust order of some compatibles
  2023-02-01 19:59 ` [PATCH 2/4] arm64: " Heiner Kallweit
@ 2023-02-03  8:05   ` Neil Armstrong
  2023-02-04 23:07   ` Martin Blumenstingl
  1 sibling, 0 replies; 16+ messages in thread
From: Neil Armstrong @ 2023-02-03  8:05 UTC (permalink / raw)
  To: Heiner Kallweit, Rob Herring, Krzysztof Kozlowski, Kevin Hilman,
	Jerome Brunet, Martin Blumenstingl, Marc Zyngier,
	Thomas Gleixner, Uwe Kleine-König, Thierry Reding
  Cc: devicetree, open list:ARM/Amlogic Meson..., linux-arm-kernel, linux-pwm

On 01/02/2023 20:59, Heiner Kallweit wrote:
> During review of a new yaml binding, affecting these dts, it turned out
> that some compatibles aren't ordered as they should be. Order should be
> most specific to least specific.
> 
> Suggested-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
>   arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 4 ++--
>   arch/arm64/boot/dts/amlogic/meson-gxl.dtsi  | 4 ++--
>   2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> index 923d2d8bb..12ef6e81c 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> @@ -300,8 +300,8 @@ &ethmac {
>   };
>   
>   &gpio_intc {
> -	compatible = "amlogic,meson-gpio-intc",
> -		     "amlogic,meson-gxbb-gpio-intc";
> +	compatible = "amlogic,meson-gxbb-gpio-intc",
> +		     "amlogic,meson-gpio-intc";
>   	status = "okay";
>   };
>   
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> index 04e9d0f1b..af912f698 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> @@ -312,8 +312,8 @@ &clkc_AO {
>   };
>   
>   &gpio_intc {
> -	compatible = "amlogic,meson-gpio-intc",
> -		     "amlogic,meson-gxl-gpio-intc";
> +	compatible = "amlogic,meson-gxl-gpio-intc",
> +		     "amlogic,meson-gpio-intc";
>   	status = "okay";
>   };
>   

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 1/4] arm: dts: meson: adjust order of some compatibles
  2023-02-01 19:58 ` [PATCH 1/4] arm: dts: meson: adjust order of some compatibles Heiner Kallweit
  2023-02-03  8:05   ` Neil Armstrong
@ 2023-02-04 23:06   ` Martin Blumenstingl
  1 sibling, 0 replies; 16+ messages in thread
From: Martin Blumenstingl @ 2023-02-04 23:06 UTC (permalink / raw)
  To: Heiner Kallweit
  Cc: Rob Herring, Krzysztof Kozlowski, Neil Armstrong, Kevin Hilman,
	Jerome Brunet, Marc Zyngier, Thomas Gleixner,
	Uwe Kleine-König, Thierry Reding, devicetree,
	open list:ARM/Amlogic Meson...,
	linux-arm-kernel, linux-pwm

On Wed, Feb 1, 2023 at 9:02 PM Heiner Kallweit <hkallweit1@gmail.com> wrote:
>
> During review of a new yaml binding, affecting these dts, it turned out
> that some compatibles aren't ordered as they should be. Order should be
> most specific to least specific.
>
> Suggested-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 2/4] arm64: dts: meson: adjust order of some compatibles
  2023-02-01 19:59 ` [PATCH 2/4] arm64: " Heiner Kallweit
  2023-02-03  8:05   ` Neil Armstrong
@ 2023-02-04 23:07   ` Martin Blumenstingl
  1 sibling, 0 replies; 16+ messages in thread
From: Martin Blumenstingl @ 2023-02-04 23:07 UTC (permalink / raw)
  To: Heiner Kallweit
  Cc: Rob Herring, Krzysztof Kozlowski, Neil Armstrong, Kevin Hilman,
	Jerome Brunet, Marc Zyngier, Thomas Gleixner,
	Uwe Kleine-König, Thierry Reding, devicetree,
	open list:ARM/Amlogic Meson...,
	linux-arm-kernel, linux-pwm

On Wed, Feb 1, 2023 at 9:02 PM Heiner Kallweit <hkallweit1@gmail.com> wrote:
>
> During review of a new yaml binding, affecting these dts, it turned out
> that some compatibles aren't ordered as they should be. Order should be
> most specific to least specific.
>
> Suggested-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 3/4] dt-bindings: pwm: Convert Amlogic Meson PWM binding
  2023-02-01 20:00 ` [PATCH 3/4] dt-bindings: pwm: Convert Amlogic Meson PWM binding Heiner Kallweit
@ 2023-02-06  8:23   ` Uwe Kleine-König
  2023-02-06 21:13     ` Heiner Kallweit
  2023-02-07  8:07     ` Neil Armstrong
  2023-02-06  8:54   ` Uwe Kleine-König
  1 sibling, 2 replies; 16+ messages in thread
From: Uwe Kleine-König @ 2023-02-06  8:23 UTC (permalink / raw)
  To: Heiner Kallweit
  Cc: Rob Herring, Krzysztof Kozlowski, Neil Armstrong, Kevin Hilman,
	Jerome Brunet, Martin Blumenstingl, Marc Zyngier,
	Thomas Gleixner, Thierry Reding, devicetree,
	open list:ARM/Amlogic Meson...,
	linux-arm-kernel, linux-pwm

[-- Attachment #1: Type: text/plain, Size: 585 bytes --]

Hello,

On Wed, Feb 01, 2023 at 09:00:21PM +0100, Heiner Kallweit wrote:
> Convert Amlogic Meson PWM binding to yaml.
> 
> Reviewed-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

How is supposed to pick up this patch? Does it go in together with the
other patches in this series via amlogic/arm; or is there an expectation
that it enters via PWM?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 3/4] dt-bindings: pwm: Convert Amlogic Meson PWM binding
  2023-02-01 20:00 ` [PATCH 3/4] dt-bindings: pwm: Convert Amlogic Meson PWM binding Heiner Kallweit
  2023-02-06  8:23   ` Uwe Kleine-König
@ 2023-02-06  8:54   ` Uwe Kleine-König
  1 sibling, 0 replies; 16+ messages in thread
From: Uwe Kleine-König @ 2023-02-06  8:54 UTC (permalink / raw)
  To: Heiner Kallweit
  Cc: Rob Herring, Krzysztof Kozlowski, Neil Armstrong, Kevin Hilman,
	Jerome Brunet, Martin Blumenstingl, Marc Zyngier,
	Thomas Gleixner, Thierry Reding, devicetree,
	open list:ARM/Amlogic Meson...,
	linux-arm-kernel, linux-pwm

[-- Attachment #1: Type: text/plain, Size: 780 bytes --]

Hello,

On Wed, Feb 01, 2023 at 09:00:21PM +0100, Heiner Kallweit wrote:
> Convert Amlogic Meson PWM binding to yaml.
> 
> Reviewed-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
this is effectively v4 of

	https://lore.kernel.org/linux-pwm/c92b9e51-bb69-0712-0b29-3db3c9a29f8b@gmail.com

and the ony change compared to v3 is that you dropped "items:" (and
reindented). I'll mark above v3 as superseeded in our patchwork, please
scream if I got that wrong.

Other than that:

Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 3/4] dt-bindings: pwm: Convert Amlogic Meson PWM binding
  2023-02-06  8:23   ` Uwe Kleine-König
@ 2023-02-06 21:13     ` Heiner Kallweit
  2023-02-07  8:07     ` Neil Armstrong
  1 sibling, 0 replies; 16+ messages in thread
From: Heiner Kallweit @ 2023-02-06 21:13 UTC (permalink / raw)
  To: Uwe Kleine-König, Neil Armstrong
  Cc: Rob Herring, Krzysztof Kozlowski, Kevin Hilman, Jerome Brunet,
	Martin Blumenstingl, Marc Zyngier, Thomas Gleixner,
	Thierry Reding, devicetree, open list:ARM/Amlogic Meson...,
	linux-arm-kernel, linux-pwm

On 06.02.2023 09:23, Uwe Kleine-König wrote:
> Hello,
> 
> On Wed, Feb 01, 2023 at 09:00:21PM +0100, Heiner Kallweit wrote:
>> Convert Amlogic Meson PWM binding to yaml.
>>
>> Reviewed-by: Rob Herring <robh+dt@kernel.org>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> 
> How is supposed to pick up this patch? Does it go in together with the
> other patches in this series via amlogic/arm; or is there an expectation
> that it enters via PWM?
> 
Neil,
are you going to take this via the amlogic tree?

> Best regards
> Uwe
> 
Heiner


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 3/4] dt-bindings: pwm: Convert Amlogic Meson PWM binding
  2023-02-06  8:23   ` Uwe Kleine-König
  2023-02-06 21:13     ` Heiner Kallweit
@ 2023-02-07  8:07     ` Neil Armstrong
  1 sibling, 0 replies; 16+ messages in thread
From: Neil Armstrong @ 2023-02-07  8:07 UTC (permalink / raw)
  To: Uwe Kleine-König, Heiner Kallweit
  Cc: Rob Herring, Krzysztof Kozlowski, Kevin Hilman, Jerome Brunet,
	Martin Blumenstingl, Marc Zyngier, Thomas Gleixner,
	Thierry Reding, devicetree, open list:ARM/Amlogic Meson...,
	linux-arm-kernel, linux-pwm

Hi,

On 06/02/2023 09:23, Uwe Kleine-König wrote:
> Hello,
> 
> On Wed, Feb 01, 2023 at 09:00:21PM +0100, Heiner Kallweit wrote:
>> Convert Amlogic Meson PWM binding to yaml.
>>
>> Reviewed-by: Rob Herring <robh+dt@kernel.org>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> 
> How is supposed to pick up this patch? Does it go in together with the
> other patches in this series via amlogic/arm; or is there an expectation
> that it enters via PWM?

I expect Thierry to pick it, if he can't I can take with his ack.

Neil

> 
> Best regards
> Uwe
> 


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: (subset) [PATCH 0/4] soc: amlogic: switch bindings to yaml and adjust some dtbs's
  2023-02-01 19:57 [PATCH 0/4] soc: amlogic: switch bindings to yaml and adjust some dtbs's Heiner Kallweit
                   ` (3 preceding siblings ...)
  2023-02-01 20:02 ` [PATCH 4/4] dt-bindings: interrupt-controller: Convert Amlogic Meson GPIO interrupt controller binding Heiner Kallweit
@ 2023-03-06  9:19 ` Neil Armstrong
  2023-03-06  9:21 ` Neil Armstrong
  5 siblings, 0 replies; 16+ messages in thread
From: Neil Armstrong @ 2023-03-06  9:19 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Kevin Hilman, Jerome Brunet,
	Martin Blumenstingl, Marc Zyngier, Thomas Gleixner,
	Uwe Kleine-König, Thierry Reding, Heiner Kallweit
  Cc: devicetree, open list:ARM/Amlogic Meson..., linux-arm-kernel, linux-pwm

Hi,

On Wed, 01 Feb 2023 20:57:48 +0100, Heiner Kallweit wrote:
> Switch two Amlogic Meson bindings to yaml. As prerequisite adjust the
> order of some compatibles first.
> 
> New versions of the bindings have been submitted as individual
> patches in between. Put it into a series again.
> 
> Heiner Kallweit (4):
>   arm: dts: meson: adjust order of some compatibles
>   arm64: dts: meson: adjust order of some compatibles
>   dt-bindings: pwm: Convert Amlogic Meson PWM binding
>   dt-bindings: interrupt-controller: Convert Amlogic Meson GPIO
>     interrupt controller binding
> 
> [...]

Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v6.4/arm64-dt)

[2/4] arm64: dts: meson: adjust order of some compatibles
      https://git.kernel.org/amlogic/c/4dcc844c99d3e47820f574911b495b58f7da1d94

These changes has been applied on the intermediate git tree [1].

The v6.4/arm64-dt branch will then be sent via a formal Pull Request to the Linux SoC maintainers
for inclusion in their intermediate git branches in order to be sent to Linus during
the next merge window, or sooner if it's a set of fixes.

In the cases of fixes, those will be merged in the current release candidate
kernel and as soon they appear on the Linux master branch they will be
backported to the previous Stable and Long-Stable kernels [2].

The intermediate git branches are merged daily in the linux-next tree [3],
people are encouraged testing these pre-release kernels and report issues on the
relevant mailing-lists.

If problems are discovered on those changes, please submit a signed-off-by revert
patch followed by a corrective changeset.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git
[2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
[3] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git

-- 
Neil


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: (subset) [PATCH 0/4] soc: amlogic: switch bindings to yaml and adjust some dtbs's
  2023-02-01 19:57 [PATCH 0/4] soc: amlogic: switch bindings to yaml and adjust some dtbs's Heiner Kallweit
                   ` (4 preceding siblings ...)
  2023-03-06  9:19 ` (subset) [PATCH 0/4] soc: amlogic: switch bindings to yaml and adjust some dtbs's Neil Armstrong
@ 2023-03-06  9:21 ` Neil Armstrong
  5 siblings, 0 replies; 16+ messages in thread
From: Neil Armstrong @ 2023-03-06  9:21 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Kevin Hilman, Jerome Brunet,
	Martin Blumenstingl, Marc Zyngier, Thomas Gleixner,
	Uwe Kleine-König, Thierry Reding, Heiner Kallweit
  Cc: devicetree, open list:ARM/Amlogic Meson..., linux-arm-kernel, linux-pwm

Hi,

On Wed, 01 Feb 2023 20:57:48 +0100, Heiner Kallweit wrote:
> Switch two Amlogic Meson bindings to yaml. As prerequisite adjust the
> order of some compatibles first.
> 
> New versions of the bindings have been submitted as individual
> patches in between. Put it into a series again.
> 
> Heiner Kallweit (4):
>   arm: dts: meson: adjust order of some compatibles
>   arm64: dts: meson: adjust order of some compatibles
>   dt-bindings: pwm: Convert Amlogic Meson PWM binding
>   dt-bindings: interrupt-controller: Convert Amlogic Meson GPIO
>     interrupt controller binding
> 
> [...]

Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v6.4/arm-dt)

[1/4] arm: dts: meson: adjust order of some compatibles
      https://git.kernel.org/amlogic/c/0c187cca73291f2c355fae31eed3fc7aa783b2de

These changes has been applied on the intermediate git tree [1].

The v6.4/arm-dt branch will then be sent via a formal Pull Request to the Linux SoC maintainers
for inclusion in their intermediate git branches in order to be sent to Linus during
the next merge window, or sooner if it's a set of fixes.

In the cases of fixes, those will be merged in the current release candidate
kernel and as soon they appear on the Linux master branch they will be
backported to the previous Stable and Long-Stable kernels [2].

The intermediate git branches are merged daily in the linux-next tree [3],
people are encouraged testing these pre-release kernels and report issues on the
relevant mailing-lists.

If problems are discovered on those changes, please submit a signed-off-by revert
patch followed by a corrective changeset.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git
[2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
[3] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git

-- 
Neil


^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2023-03-06  9:21 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-01 19:57 [PATCH 0/4] soc: amlogic: switch bindings to yaml and adjust some dtbs's Heiner Kallweit
2023-02-01 19:58 ` [PATCH 1/4] arm: dts: meson: adjust order of some compatibles Heiner Kallweit
2023-02-03  8:05   ` Neil Armstrong
2023-02-04 23:06   ` Martin Blumenstingl
2023-02-01 19:59 ` [PATCH 2/4] arm64: " Heiner Kallweit
2023-02-03  8:05   ` Neil Armstrong
2023-02-04 23:07   ` Martin Blumenstingl
2023-02-01 20:00 ` [PATCH 3/4] dt-bindings: pwm: Convert Amlogic Meson PWM binding Heiner Kallweit
2023-02-06  8:23   ` Uwe Kleine-König
2023-02-06 21:13     ` Heiner Kallweit
2023-02-07  8:07     ` Neil Armstrong
2023-02-06  8:54   ` Uwe Kleine-König
2023-02-01 20:02 ` [PATCH 4/4] dt-bindings: interrupt-controller: Convert Amlogic Meson GPIO interrupt controller binding Heiner Kallweit
2023-02-02 23:54   ` Rob Herring
2023-03-06  9:19 ` (subset) [PATCH 0/4] soc: amlogic: switch bindings to yaml and adjust some dtbs's Neil Armstrong
2023-03-06  9:21 ` Neil Armstrong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).