From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Lee Jones <lee.jones@linaro.org>
Cc: thierry.reding@gmail.com, linux-pwm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
NeilBrown <neilb@suse.de>, Grant Erickson <marathon96@gmail.com>
Subject: Re: [PATCH 4/4] pwm: omap-dmtimer: Repair pwm_omap_dmtimer_chip's broken kerneldoc header
Date: Mon, 29 Jun 2020 21:39:58 +0200 [thread overview]
Message-ID: <20200629193958.dasxmmkcexfxorfq@pengutronix.de> (raw)
In-Reply-To: <20200629124752.1018358-5-lee.jones@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1588 bytes --]
Hello,
[dropped Joachim Eastwood <manabian@gmail.com> from recipents as his
address bounces]
On Mon, Jun 29, 2020 at 01:47:52PM +0100, Lee Jones wrote:
> Argument descriptions must be prepended with a '@' to be understood
> by the kerneldoc tooling/parsers/validators.
>
> Fixes the following W=1 warning:
>
> drivers/pwm/pwm-omap-dmtimer.c:70: warning: Function parameter or member 'dm_timer_pdev' not described in 'pwm_omap_dmtimer_chip'
>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Joachim Eastwood <manabian@gmail.com>
> Cc: NeilBrown <neilb@suse.de>
> Cc: Grant Erickson <marathon96@gmail.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/pwm/pwm-omap-dmtimer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pwm/pwm-omap-dmtimer.c b/drivers/pwm/pwm-omap-dmtimer.c
> index 0d31833db2e2c..75cea7f2aff5e 100644
> --- a/drivers/pwm/pwm-omap-dmtimer.c
> +++ b/drivers/pwm/pwm-omap-dmtimer.c
> @@ -58,7 +58,7 @@
> * @mutex: Mutex to protect pwm apply state
> * @dm_timer: Pointer to omap dm timer.
> * @pdata: Pointer to omap dm timer ops.
> - * dm_timer_pdev: Pointer to omap dm timer platform device
> + * @dm_timer_pdev: Pointer to omap dm timer platform device
> */
> struct pwm_omap_dmtimer_chip {
> struct pwm_chip chip;
LGTM,
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-06-29 19:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 12:47 [PATCH 0/4] Fix a bunch of W=1 warnings in PWM Lee Jones
2020-06-29 12:47 ` [PATCH 1/4] pwm: bcm-iproc: Remove impossible comparison when validating duty cycle Lee Jones
2020-06-29 16:45 ` Florian Fainelli
2020-06-29 16:54 ` Scott Branden
2020-06-29 19:45 ` Uwe Kleine-König
2020-06-29 12:47 ` [PATCH 2/4] pwm: bcm-kona: " Lee Jones
2020-06-29 16:45 ` Florian Fainelli
2020-06-29 19:41 ` Uwe Kleine-König
2020-06-29 12:47 ` [PATCH 3/4] pwm: mediatek: Provide missing kerneldoc description for 'soc' arg Lee Jones
2020-06-29 19:47 ` Uwe Kleine-König
2020-06-29 12:47 ` [PATCH 4/4] pwm: omap-dmtimer: Repair pwm_omap_dmtimer_chip's broken kerneldoc header Lee Jones
2020-06-29 19:39 ` Uwe Kleine-König [this message]
2020-07-27 7:50 ` [PATCH 0/4] Fix a bunch of W=1 warnings in PWM Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200629193958.dasxmmkcexfxorfq@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=marathon96@gmail.com \
--cc=neilb@suse.de \
--cc=thierry.reding@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).