From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Thompson Subject: Re: [PATCH v4 15/20] backlight: gpio_backlight: simplify update_status() Date: Wed, 8 Jul 2020 12:07:16 +0100 Message-ID: <20200708110716.2ujel24lqjcudu5f@holly.lan> References: <20200703184546.144664-1-sam@ravnborg.org> <20200703184546.144664-16-sam@ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728507AbgGHLHV (ORCPT ); Wed, 8 Jul 2020 07:07:21 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4ACFC08C5DC for ; Wed, 8 Jul 2020 04:07:20 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id j18so2468306wmi.3 for ; Wed, 08 Jul 2020 04:07:20 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20200703184546.144664-16-sam@ravnborg.org> Sender: linux-pwm-owner@vger.kernel.org List-Id: linux-pwm@vger.kernel.org To: Sam Ravnborg Cc: dri-devel@lists.freedesktop.org, Jingoo Han , Lee Jones , Andy Gross , Bartlomiej Zolnierkiewicz , Bjorn Andersson , Daniel Vetter , David Airlie , Emil Velikov , Jonathan Corbet , linux-arm-msm@vger.kernel.org, linux-pwm@vger.kernel.org, Maarten Lankhorst , Maxime Ripard , Michael Hennerich , patches@opensource.cirrus.com, Support Opensource , Thierry Reding , Thomas Zimmermann , Uwe On Fri, Jul 03, 2020 at 08:45:41PM +0200, Sam Ravnborg wrote: > Introduce the use of backlight_get_brightness() to simplify > the update_status() operation. > With the simpler implementation drop the gpio_backlight_get_next_brightness() > helper as it was now a one-liner. > > Signed-off-by: Sam Ravnborg > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han Reviewed-by: Daniel Thompson