From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH v5 12/13] arm64: dts: freescale: sl28: enable LED support Date: Fri, 17 Jul 2020 10:36:10 +0200 Message-ID: <20200717083610.GC1027@bug> References: <20200706175353.16404-1-michael@walle.cc> <20200706175353.16404-13-michael@walle.cc> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20200706175353.16404-13-michael@walle.cc> Sender: linux-gpio-owner@vger.kernel.org To: Michael Walle Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-pwm@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Bartosz Golaszewski , Rob Herring , Jean Delvare , Guenter Roeck , Lee Jones , Thierry Reding , Uwe Kleine-K??nig , Wim Van Sebroeck , Shawn Guo , Li Yang , Thomas Gleixner , Jason Cooper , Marc Zyngier , Mark Brown List-Id: linux-pwm@vger.kernel.org Hi! > Now that we have support for GPIO lines of the SMARC connector, enable > LED support on the KBox A-230-LS. There are two LEDs without fixed > functions, one is yellow and one is green. Unfortunately, it is just one > multi-color LED, thus while it is possible to enable both at the same > time it is hard to tell the difference between "yellow only" and "yellow > and green". > + user_yellow { > + label = "s1914:yellow:user"; > + gpios = <&sl28cpld_gpio0 0 0>; > + }; > + > + user_green { > + label = "s1914:green:user"; > + gpios = <&sl28cpld_gpio1 3 0>; > + }; This is not suitable label for such LEDs... there's zero chance userland will know what to do with these. Do they have some kind of "usual" function? Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html