From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E92B1C433E0 for ; Mon, 11 Jan 2021 09:14:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA46C2068D for ; Mon, 11 Jan 2021 09:14:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728300AbhAKJON (ORCPT ); Mon, 11 Jan 2021 04:14:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728299AbhAKJOM (ORCPT ); Mon, 11 Jan 2021 04:14:12 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 760A5C061794 for ; Mon, 11 Jan 2021 01:13:32 -0800 (PST) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kytGM-00014x-H7; Mon, 11 Jan 2021 10:13:22 +0100 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1kytGC-00032c-GA; Mon, 11 Jan 2021 10:13:12 +0100 Date: Mon, 11 Jan 2021 10:13:10 +0100 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Jonathan =?utf-8?Q?Neusch=C3=A4fer?= Cc: linux-kernel@vger.kernel.org, Alexandre Belloni , Heiko Stuebner , linux-pwm@vger.kernel.org, Linus Walleij , Thierry Reding , Fabio Estevam , linux-rtc@vger.kernel.org, Arnd Bergmann , Mauro Carvalho Chehab , Sam Ravnborg , Daniel Palmer , Andy Shevchenko , Andreas Kemnade , NXP Linux Team , devicetree@vger.kernel.org, Stephan Gerhold , allen , Sascha Hauer , Lubomir Rintel , Rob Herring , Lee Jones , linux-arm-kernel@lists.infradead.org, Alessandro Zummo , Mark Brown , Pengutronix Kernel Team , Heiko Stuebner , Josua Mayer , Shawn Guo , "David S. Miller" Subject: Re: [PATCH v7 4/7] pwm: ntxec: Add driver for PWM function in Netronix EC Message-ID: <20210111091310.ok47s7yvk5ngs4q7@pengutronix.de> References: <20210109180220.121511-1-j.neuschaefer@gmx.net> <20210109180220.121511-5-j.neuschaefer@gmx.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="yaagkpiwccmvofgv" Content-Disposition: inline In-Reply-To: <20210109180220.121511-5-j.neuschaefer@gmx.net> X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-pwm@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org --yaagkpiwccmvofgv Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello, On Sat, Jan 09, 2021 at 07:02:17PM +0100, Jonathan Neusch=E4fer wrote: > The Netronix EC provides a PWM output which is used for the backlight > on some ebook readers. This patches adds a driver for the PWM output. >=20 > The .get_state callback is not implemented, because the PWM state can't > be read back from the hardware. There is only very little I would have done differently (only indention which is too minor to make a fuss), so: Reviewed-by: Uwe Kleine-K=F6nig =20 Thanks for your work Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --yaagkpiwccmvofgv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAl/8FqQACgkQwfwUeK3K 7AkfOgf+Im2rZmWnsNL7mT4lJlbUjot+WGBgUG+cZ7HYEr0wbqbO82FpAgY+K/6D cW6W1txTfWkr/4LbJW0rBQUkXkbeUa9hIpSMoOjpFnhmI/exEixKaY5FRnoueCb6 vKOwoH66j+vYuzTIm1oDLEUHFCNqk34FaHj8g+VpvtDxVwdnQq7DrRkVVmrzYv5I QHdXsj4T4Bi/NKvGhepJI3k8t5tZWPMp81Lw61lqKJe63t2GAC+1TGH6YXxD4B+D pQe0gvV0MTJVRC5JC6umyF3EUPPRMyR6krgEQeE7YSpvredGWssJ24wGxuB+ZAMS XtLVJujpqo9QJtzrId8kXSBRR1L5wg== =H+zc -----END PGP SIGNATURE----- --yaagkpiwccmvofgv--