From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Simon South <simon@simonsouth.net>
Cc: tpiepho@gmail.com, thierry.reding@gmail.com,
robin.murphy@arm.com, lee.jones@linaro.org, heiko@sntech.de,
bbrezillon@kernel.org, david.wu@rock-chips.com,
steven.liu@rock-chips.com, linux-pwm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v4 5/5] pwm: rockchip: Enable clock before calling clk_get_rate()
Date: Tue, 19 Jan 2021 20:22:55 +0100 [thread overview]
Message-ID: <20210119192255.jdhh3l64yp5whzzq@pengutronix.de> (raw)
In-Reply-To: <4924f18fea9b028cab92ad4e79d957f5cb336b9c.1610976129.git.simon@simonsouth.net>
[-- Attachment #1: Type: text/plain, Size: 1138 bytes --]
Hello Simon,
On Tue, Jan 19, 2021 at 11:12:09AM -0500, Simon South wrote:
> The documentation for clk_get_rate() in include/linux/clk.h states the
> function's result is valid only for a clock source that has been
> enabled. However, the Rockchip PWM driver uses this function in two places
> to query the rate of a clock without first ensuring it is enabled.
>
> Fix this by modifying rockchip_pwm_get_state() and rockchip_pwm_apply() so
> they enable a device's PWM clock before querying its rate (in the latter
> case, the querying is actually done in rockchip_pwm_config()) and disable
> the clock again before returning.
>
> Reported-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Simon South <simon@simonsouth.net>
I already reviewed this patch in v3 and gave my
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
You make it a bit easier if you add the received tags for new
iterations.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2021-01-19 19:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 16:12 [PATCH v4 0/5] pwm: rockchip: Eliminate potential race condition when probing Simon South
2021-01-19 16:12 ` [PATCH v4 1/5] pwm: rockchip: Enable APB clock during register access while probing Simon South
2021-01-19 16:12 ` [PATCH v4 2/5] pwm: rockchip: rockchip_pwm_probe(): Remove superfluous clk_unprepare() Simon South
2021-01-19 16:12 ` [PATCH v4 3/5] pwm: rockchip: Replace "bus clk" with "PWM clk" Simon South
2021-01-19 16:12 ` [PATCH v4 4/5] pwm: rockchip: Eliminate potential race condition when probing Simon South
2021-01-19 16:12 ` [PATCH v4 5/5] pwm: rockchip: Enable clock before calling clk_get_rate() Simon South
2021-01-19 19:22 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210119192255.jdhh3l64yp5whzzq@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=bbrezillon@kernel.org \
--cc=david.wu@rock-chips.com \
--cc=heiko@sntech.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robin.murphy@arm.com \
--cc=simon@simonsouth.net \
--cc=steven.liu@rock-chips.com \
--cc=thierry.reding@gmail.com \
--cc=tpiepho@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).