linux-pwm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: "Thierry Reding" <thierry.reding@gmail.com>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	"Ulf Hansson" <ulf.hansson@linaro.org>,
	"Viresh Kumar" <vireshk@kernel.org>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Peter De Schrijver" <pdeschrijver@nvidia.com>,
	"Mikko Perttunen" <mperttunen@nvidia.com>,
	"Peter Chen" <peter.chen@kernel.org>,
	"Mark Brown" <broonie@kernel.org>,
	"Lee Jones" <lee.jones@linaro.org>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Nishanth Menon" <nm@ti.com>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	"Richard Weinberger" <richard@nod.at>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Lucas Stach" <dev@lynxeye.de>, "Stefan Agner" <stefan@agner.ch>,
	"Adrian Hunter" <adrian.hunter@intel.com>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Michael Turquette" <mturquette@baylibre.com>
Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-staging@lists.linux.dev, linux-spi@vger.kernel.org,
	linux-pwm@vger.kernel.org, linux-mtd@lists.infradead.org,
	linux-mmc@vger.kernel.org, linux-media@vger.kernel.org,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-clk@vger.kernel.org
Subject: [PATCH v11 17/34] bus: tegra-gmi: Add runtime PM and OPP support
Date: Sun, 12 Sep 2021 23:08:15 +0300	[thread overview]
Message-ID: <20210912200832.12312-18-digetx@gmail.com> (raw)
In-Reply-To: <20210912200832.12312-1-digetx@gmail.com>

The GMI bus on Tegra belongs to the core power domain and we're going to
enable GENPD support for the core domain. Now GMI must be resumed using
runtime PM API in order to initialize the GMI power state. Add runtime PM
and OPP support to the GMI driver.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/bus/tegra-gmi.c | 52 ++++++++++++++++++++++++++++++++++++-----
 1 file changed, 46 insertions(+), 6 deletions(-)

diff --git a/drivers/bus/tegra-gmi.c b/drivers/bus/tegra-gmi.c
index a6570789f7af..72ef8a8c236b 100644
--- a/drivers/bus/tegra-gmi.c
+++ b/drivers/bus/tegra-gmi.c
@@ -13,8 +13,11 @@
 #include <linux/io.h>
 #include <linux/module.h>
 #include <linux/of_device.h>
+#include <linux/pm_runtime.h>
 #include <linux/reset.h>
 
+#include <soc/tegra/common.h>
+
 #define TEGRA_GMI_CONFIG		0x00
 #define TEGRA_GMI_CONFIG_GO		BIT(31)
 #define TEGRA_GMI_BUS_WIDTH_32BIT	BIT(30)
@@ -54,9 +57,9 @@ static int tegra_gmi_enable(struct tegra_gmi *gmi)
 {
 	int err;
 
-	err = clk_prepare_enable(gmi->clk);
-	if (err < 0) {
-		dev_err(gmi->dev, "failed to enable clock: %d\n", err);
+	err = pm_runtime_resume_and_get(gmi->dev);
+	if (err) {
+		pm_runtime_disable(gmi->dev);
 		return err;
 	}
 
@@ -83,7 +86,8 @@ static void tegra_gmi_disable(struct tegra_gmi *gmi)
 	writel(config, gmi->base + TEGRA_GMI_CONFIG);
 
 	reset_control_assert(gmi->rst);
-	clk_disable_unprepare(gmi->clk);
+
+	pm_runtime_put(gmi->dev);
 }
 
 static int tegra_gmi_parse_dt(struct tegra_gmi *gmi)
@@ -213,6 +217,7 @@ static int tegra_gmi_probe(struct platform_device *pdev)
 	if (!gmi)
 		return -ENOMEM;
 
+	platform_set_drvdata(pdev, gmi);
 	gmi->dev = dev;
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
@@ -232,6 +237,14 @@ static int tegra_gmi_probe(struct platform_device *pdev)
 		return PTR_ERR(gmi->rst);
 	}
 
+	err = devm_pm_runtime_enable(gmi->dev);
+	if (err)
+		return err;
+
+	err = devm_tegra_core_dev_init_opp_table_common(&pdev->dev);
+	if (err)
+		return err;
+
 	err = tegra_gmi_parse_dt(gmi);
 	if (err)
 		return err;
@@ -247,8 +260,6 @@ static int tegra_gmi_probe(struct platform_device *pdev)
 		return err;
 	}
 
-	platform_set_drvdata(pdev, gmi);
-
 	return 0;
 }
 
@@ -262,6 +273,34 @@ static int tegra_gmi_remove(struct platform_device *pdev)
 	return 0;
 }
 
+static int __maybe_unused tegra_gmi_runtime_resume(struct device *dev)
+{
+	struct tegra_gmi *gmi = dev_get_drvdata(dev);
+	int err;
+
+	err = clk_prepare_enable(gmi->clk);
+	if (err < 0) {
+		dev_err(gmi->dev, "failed to enable clock: %d\n", err);
+		return err;
+	}
+
+	return 0;
+}
+
+static int __maybe_unused tegra_gmi_runtime_suspend(struct device *dev)
+{
+	struct tegra_gmi *gmi = dev_get_drvdata(dev);
+
+	clk_disable_unprepare(gmi->clk);
+
+	return 0;
+}
+
+static const struct dev_pm_ops tegra_gmi_pm = {
+	SET_RUNTIME_PM_OPS(tegra_gmi_runtime_suspend, tegra_gmi_runtime_resume,
+			   NULL)
+};
+
 static const struct of_device_id tegra_gmi_id_table[] = {
 	{ .compatible = "nvidia,tegra20-gmi", },
 	{ .compatible = "nvidia,tegra30-gmi", },
@@ -275,6 +314,7 @@ static struct platform_driver tegra_gmi_driver = {
 	.driver = {
 		.name		= "tegra-gmi",
 		.of_match_table	= tegra_gmi_id_table,
+		.pm = &tegra_gmi_pm,
 	},
 };
 module_platform_driver(tegra_gmi_driver);
-- 
2.32.0


  parent reply	other threads:[~2021-09-12 20:11 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-12 20:07 [PATCH v11 00/34] NVIDIA Tegra power management patches for 5.16 Dmitry Osipenko
2021-09-12 20:07 ` [PATCH v11 01/34] opp: Change type of dev_pm_opp_attach_genpd(names) argument Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 02/34] soc/tegra: Add devm_tegra_core_dev_init_opp_table_common() Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 03/34] soc/tegra: pmc: Disable PMC state syncing Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 04/34] soc/tegra: Don't print error message when OPPs not available Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 05/34] dt-bindings: clock: tegra-car: Document new clock sub-nodes Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 06/34] clk: tegra: Support runtime PM and power domain Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 07/34] dt-bindings: host1x: Document OPP and power domain properties Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 08/34] dt-bindings: host1x: Document Memory Client resets of Host1x, GR2D and GR3D Dmitry Osipenko
2021-09-16 19:49   ` Rob Herring
2021-09-12 20:08 ` [PATCH v11 09/34] gpu: host1x: Add runtime PM and OPP support Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 10/34] gpu: host1x: Add host1x_channel_stop() Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 11/34] drm/tegra: dc: Support OPP and SoC core voltage scaling Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 12/34] drm/tegra: hdmi: Add OPP support Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 13/34] drm/tegra: gr2d: Support generic power domain and runtime PM Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 14/34] drm/tegra: gr3d: " Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 15/34] drm/tegra: vic: Support system suspend Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 16/34] usb: chipidea: tegra: Add runtime PM and OPP support Dmitry Osipenko
2021-09-12 20:08 ` Dmitry Osipenko [this message]
2021-09-12 20:08 ` [PATCH v11 18/34] pwm: " Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 19/34] mmc: sdhci-tegra: " Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 20/34] mtd: rawnand: tegra: " Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 21/34] spi: tegra20-slink: Add " Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 22/34] media: dt: bindings: tegra-vde: Convert to schema Dmitry Osipenko
2021-09-13 10:36   ` Hans Verkuil
2021-09-12 20:08 ` [PATCH v11 23/34] media: dt: bindings: tegra-vde: Document OPP and power domain Dmitry Osipenko
2021-09-13 10:36   ` Hans Verkuil
2021-09-12 20:08 ` [PATCH v11 24/34] media: staging: tegra-vde: Support generic " Dmitry Osipenko
2021-09-13 10:37   ` Hans Verkuil
2021-09-12 20:08 ` [PATCH v11 25/34] soc/tegra: fuse: Reset hardware Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 26/34] soc/tegra: fuse: Use resource-managed helpers Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 27/34] soc/tegra: regulators: Prepare for suspend Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 28/34] soc/tegra: pmc: Change name of core power domain Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 29/34] soc/tegra: pmc: Enable core domain support for Tegra20 and Tegra30 Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 30/34] ARM: tegra: Add OPP tables and power domains to Tegra20 device-trees Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 31/34] ARM: tegra: Add OPP tables and power domains to Tegra30 device-trees Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 32/34] ARM: tegra: Add Memory Client resets to Tegra20 GR2D, GR3D and Host1x Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 33/34] ARM: tegra: Add Memory Client resets to Tegra30 " Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 34/34] ARM: tegra20/30: Disable unused host1x hardware Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210912200832.12312-18-digetx@gmail.com \
    --to=digetx@gmail.com \
    --cc=adrian.hunter@intel.com \
    --cc=broonie@kernel.org \
    --cc=dev@lynxeye.de \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jonathanh@nvidia.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=mperttunen@nvidia.com \
    --cc=mturquette@baylibre.com \
    --cc=nm@ti.com \
    --cc=pdeschrijver@nvidia.com \
    --cc=peter.chen@kernel.org \
    --cc=richard@nod.at \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=stefan@agner.ch \
    --cc=thierry.reding@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=ulf.hansson@linaro.org \
    --cc=vigneshr@ti.com \
    --cc=vireshk@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).