From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Thierry Reding <thierry.reding@gmail.com>,
Munehisa Kamata <kamatam@amazon.com>,
Jiancheng Xue <xuejiancheng@hisilicon.com>,
yuanjian <yuanjian12@hisilicon.com>,
Rob Herring <robh@kernel.org>, Benson Leung <bleung@chromium.org>,
Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Chunyan Zhang <zhang.lyra@gmail.com>
Cc: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
Guenter Roeck <groeck@chromium.org>,
chrome-platform@lists.linux.dev, kernel@pengutronix.de
Subject: [PATCH 0/4] pwm: Ensure .polarity is set in .get_state()
Date: Tue, 28 Feb 2023 14:55:04 +0100 [thread overview]
Message-ID: <20230228135508.1798428-1-u.kleine-koenig@pengutronix.de> (raw)
Hello,
in the context of the discussion with Munehisa Kamata about the meson driver
not setting .polarity in .get_state() I checked the other drivers for the same
issue. The identified drivers are fixed here. For three of them
zero-initializing *state would be good enough, still I think setting the
polarity explicitly is a good idea. For the hibvt driver (that supports
both polarities) the change is a real improvement.
Note I didn't touch the meson driver here that requires some non-trivial
updates that I don't want to tackle without hardware to test.
Best regards
Uwe
Uwe Kleine-König (4):
pwm: hibvt: Explicitly set .polarity in .get_state()
pwm: cros-ec: Explicitly set .polarity in .get_state()
pwm: iqs620a: Explicitly set .polarity in .get_state()
pwm: sprd: Explicitly set .polarity in .get_state()
drivers/pwm/pwm-cros-ec.c | 1 +
drivers/pwm/pwm-hibvt.c | 1 +
drivers/pwm/pwm-iqs620a.c | 1 +
drivers/pwm/pwm-sprd.c | 1 +
4 files changed, 4 insertions(+)
base-commit: 7a77daf8223e772a225d6aa6202a5b1ae2392caf
--
2.39.1
next reply other threads:[~2023-02-28 13:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 13:55 Uwe Kleine-König [this message]
2023-02-28 13:55 ` [PATCH 1/4] pwm: hibvt: Explicitly set .polarity in .get_state() Uwe Kleine-König
2023-03-10 18:59 ` Uwe Kleine-König
2023-02-28 13:55 ` [PATCH 2/4] pwm: cros-ec: " Uwe Kleine-König
2023-02-28 16:19 ` Guenter Roeck
2023-03-10 18:50 ` Uwe Kleine-König
2023-02-28 13:55 ` [PATCH 3/4] pwm: iqs620a: " Uwe Kleine-König
2023-03-10 18:48 ` Uwe Kleine-König
2023-03-10 23:29 ` Jeff LaBundy
2023-02-28 13:55 ` [PATCH 4/4] pwm: sprd: " Uwe Kleine-König
2023-03-10 18:43 ` Uwe Kleine-König
2023-05-08 3:45 ` [PATCH 0/4] pwm: Ensure .polarity is set " patchwork-bot+chrome-platform
2023-05-08 3:56 ` patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230228135508.1798428-1-u.kleine-koenig@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=baolin.wang@linux.alibaba.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=kamatam@amazon.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=xuejiancheng@hisilicon.com \
--cc=yuanjian12@hisilicon.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).