From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93C66C7619A for ; Tue, 11 Apr 2023 08:57:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229490AbjDKI5L (ORCPT ); Tue, 11 Apr 2023 04:57:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229473AbjDKI5J (ORCPT ); Tue, 11 Apr 2023 04:57:09 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9AC86E76; Tue, 11 Apr 2023 01:57:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1681203429; x=1712739429; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=WocyDYqP8aO6wX0kDfztKAcX1uvZMqbLfMBeCWVGOzg=; b=pxO4n4d0AynnER1t9TBOCB1EmYFjEnNCHi0i++DqcEnZlGDUQ9/clIQU lCLDVXWMLUkPth2T5RkpmR1Qyf5GBeF1pxHBrkB12B5LYwhSGh3KReRRF LylmvTUugHizVEdsP6QkKw6wS6skHf76Mu4uE+wsLfnp3XxyIIMjaC4Mk cb4pfR8Qx8tj76KYBNzg41qBd+EdCMODSvJ+DQxlPM5bF99QlgOtTyzT+ cJytRejuixwQZeUjTKiP01uhcvSSjdBjTS7TyNWV77H5lxyhRXdbPcNHe uEiqlox2kN3PTXC9OvPI2nftVp/fXw50feDuOM4xb2HrU+Q8YpXFTU/gJ Q==; X-IronPort-AV: E=Sophos;i="5.98,336,1673938800"; d="scan'208";a="209011350" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 11 Apr 2023 01:57:07 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 11 Apr 2023 01:57:05 -0700 Received: from wendy.microchip.com (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2507.21 via Frontend Transport; Tue, 11 Apr 2023 01:57:04 -0700 From: Conor Dooley To: Thierry Reding , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= CC: Daire McNamara , , , , Conor Dooley Subject: [PATCH v16 0/2] Microchip Soft IP corePWM driver Date: Tue, 11 Apr 2023 09:56:33 +0100 Message-ID: <20230411-wizard-cautious-3c048db6b4d2@wendy> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=5172; i=conor.dooley@microchip.com; h=from:subject:message-id; bh=WocyDYqP8aO6wX0kDfztKAcX1uvZMqbLfMBeCWVGOzg=; b=owGbwMvMwCFWscWwfUFT0iXG02pJDCmmCgeP/fyuHSW5bdIe2di4yOXaiQ8Ku+uq9ip2rGBapHTn uZJFRykLgxgHg6yYIkvi7b4WqfV/XHY497yFmcPKBDKEgYtTACby5zjDHx6dVjUWLamWhj9Vz85U9B 3p0j70m33r8Ytqew7P+xEgvpjhf5Ghd9rsZPH7Uz5HCUpyvA9zDouW+luZ7ZdYddnV+rY8FwA= X-Developer-Key: i=conor.dooley@microchip.com; a=openpgp; fpr=F9ECA03CF54F12CD01F1655722E2C55B37CF380C Content-Transfer-Encoding: 8bit Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org Hey all, Uwe & I had a long back and forth about period calculations on v13, my ultimate conclusion being that, after some testing of the "corrected" calculation in hardware, the original calculation was correct. I think we had gotten sucked into discussion the calculation of the period itself, when we were in fact trying to calculate a bound on the period instead. That discussion is here: https://lore.kernel.org/linux-pwm/Y+ow8tfAHo1yv1XL@wendy/ There was, of course, another chat about the niche bits of this calculation on v14 too: https://lore.kernel.org/linux-pwm/20230322105536.kgt3ffowefqlg6eu@pengutronix.de/ Thanks, Conor. Changes since v15: - calculate prescale modulus without using % Changes since v14: - change period_steps calculation logic to correctly handle the cases where tmp % (254 + 1) == 0, by swapping implicit truncation for explicit rounding upwards and subtracting zero - special case periods < 1/clk_rate & add a note in limitations about this, although I think this issue wasn't present prior to v15's changes - check for smaller suitable values of prescale, which picks the "more correct" value in about half of all cases, particularly those where tmp is large. - explain what I mean by the "optimal" values for prescale/period steps re-fix use of defines - add a comment about how sync_upd mode works - make the use of period_steps and prescale consistently refer to the register values rather than, in comments, using these to mean the resulting values after 1 has been added - drop the PREG_TO_VAL() macro, as most of its users are now gone & it only added to the register value versus "real" value problem - report pwmchip_add() failures Changes since v13: - couple bits of cleanup to apply_locked(), suggested by Uwe - move the overhead waiting for a change to be applied, for channels with shadow registers, to subsequent calls to apply(). This has the benefit of only waiting when two calls to apply() are close in time rather than eating the delay in every call. Changes since v11: - swap a "bare" multiply & divide for the corresponding helper to prevent overflow - factor out duplicate clk rate acquisition & period calculation - make the period calculation return void by checking the validity of the clock rate in the caller - drop the binding & dt patch, they're on-track for v6.2 via my tree Changes since v10: - reword some comments - try to assign the period if a disable is requested - drop a cast around a u8 -> u16 conversion - fix a check on period_steps that should be on the hw_ variant - split up the period calculation in get_state() to fix the result on 32 bit - add a rate variable in get_state() to only call get_rate() once - redo the locking as suggested to make it more straightforward. - stop checking for enablement in get_state() that was working around intended behaviour of the sysfs interface Changes since v9: - fixed the missing unlock that Dan reported Changes since v8: - fixed a(nother) raw 64 bit division (& built it for riscv32!) - added a check to make sure we don't try to sleep for 0 us Changes since v7: - rebased on 6.0-rc1 - reworded comments you highlighted in v7 - fixed the overkill sleeping - removed the unused variables in calc_duty - added some extra comments to explain behaviours you questioned in v7 - make the mutexes un-interruptible - fixed added the 1s you suggested for the if(period_locked) logic - added setup of the channel_enabled shadowing - fixed the period reporting for the negedge == posedge case in get_state() I had to add the enabled check, as otherwise it broke setting the period for the first time out of reset. - added a test for invalid PERIOD_STEPS values, in which case we abort if we cannot fix the period Changes from v6: - Dropped an unused variable that I'd missed - Actually check the return values of the mutex lock()s - Re-rebased on -next for the MAINTAINERS patch (again...) Changes from v5: - switched to a mutex b/c we must sleep with the lock taken - simplified the locking in apply() and added locking to get_state() - reworked apply() as requested - removed the loop in the period calculation (thanks Uwe!) - add a copy of the enable registers in the driver to save on reads. - remove the second (useless) write to sync_update - added some missing rounding in get_state() - couple other minor cleanups as requested in: https://lore.kernel.org/linux-riscv/20220709160206.cw5luo7kxdshoiua@pengutronix.de/ Changes from v4: - dropped some accidentally added files Changes before v4: https://lore.kernel.org/linux-pwm/20220721172109.941900-1-mail@conchuod.ie Conor Dooley (2): pwm: add microchip soft ip corePWM driver MAINTAINERS: add pwm to PolarFire SoC entry MAINTAINERS | 1 + drivers/pwm/Kconfig | 10 + drivers/pwm/Makefile | 1 + drivers/pwm/pwm-microchip-core.c | 509 +++++++++++++++++++++++++++++++ 4 files changed, 521 insertions(+) create mode 100644 drivers/pwm/pwm-microchip-core.c -- 2.39.2