From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Lorenz Brun <lorenz@brun.one>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2] pwm: mediatek: support inverted polarity
Date: Fri, 14 Apr 2023 07:39:56 +0200 [thread overview]
Message-ID: <20230414053956.brgzufk4qjsswhqn@pengutronix.de> (raw)
In-Reply-To: <ZC7Xf8Wy1x9gnaAY@orome>
[-- Attachment #1: Type: text/plain, Size: 3581 bytes --]
On Thu, Apr 06, 2023 at 04:30:23PM +0200, Thierry Reding wrote:
> On Thu, Apr 06, 2023 at 03:53:58PM +0200, Uwe Kleine-König wrote:
> > Hello Thierry,
> >
> > On Thu, Apr 06, 2023 at 03:38:48PM +0200, Thierry Reding wrote:
> > > On Thu, Mar 09, 2023 at 02:04:10AM +0100, Lorenz Brun wrote:
> > > > + * appear to have the capability to invert the output.
> > > > + * This means that inverted mode can not be fully supported as the
> > > > + * waveform will always start with the low period and end with the high
> > > > + * period. Thus reject non-normal polarity if the shape of the waveform
> > > > + * matters, i.e. usage_power is not set.
> > > > + */
> > > > + if (state->polarity != PWM_POLARITY_NORMAL && !state->usage_power)
> > > > return -EINVAL;
> > > >
> > > > if (!state->enabled) {
> > > > @@ -213,7 +221,11 @@ static int pwm_mediatek_apply(struct pwm_chip *chip, struct pwm_device *pwm,
> > > > return 0;
> > > > }
> > > >
> > > > - err = pwm_mediatek_config(pwm->chip, pwm, state->duty_cycle, state->period);
> > > > + duty_cycle = state->duty_cycle;
> > > > + if (state->polarity == PWM_POLARITY_INVERSED)
> > > > + duty_cycle = state->period - state->duty_cycle;
> > >
> > > That's not really what state->usage_power was meant to address.
> >
> > I don't understand your concern here. I don't like .usage_power, but
> > AFAICT this is a legitimite use. With .usage_power = true, the lowlevel
> > driver is free to shift the phase_offset and even modify the period size
> > and the goal is just that the average power-output matches.
> >
> > Lorenz's patch does exactly this: It even keeps the period and only
> > shifts the phase (by period - duty_cycle). If you consider this not
> > legitmate, I think we have to improve the docs about .usage_power.
>
> I realize that I'm being nitpicky here. Setting usage_power = true and
> duty = period - duty is a lazy way of achieving what you can easily do
> by adjusting the input duty cycle.
>
> If you all really want this, then it should go into the core, because
> it's something that can be implemented on basically every single PWM
> controller.
You'd need something like:
diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
index e01147f66e15..6bb851c2e55e 100644
--- a/drivers/pwm/core.c
+++ b/drivers/pwm/core.c
@@ -556,6 +556,7 @@ static void pwm_apply_state_debug(struct pwm_device *pwm,
int pwm_apply_state(struct pwm_device *pwm, const struct pwm_state *state)
{
struct pwm_chip *chip;
+ bool retry_inverted = true;
int err;
/*
@@ -580,10 +581,19 @@ int pwm_apply_state(struct pwm_device *pwm, const struct pwm_state *state)
state->usage_power == pwm->state.usage_power)
return 0;
+retry:
err = chip->ops->apply(chip, pwm, state);
trace_pwm_apply(pwm, state, err);
- if (err)
+ if (err) {
+ if (err == -EINVAL && state->usage_power && retry_inverted) {
+ state->duty_cycle = state->period - state->duty_cycle;
+ state->polarity = 1 - state->polarity;
+ retry_inverted = false;
+ goto retry;
+ }
+
return err;
+ }
pwm->state = *state;
(Just to show the idea. It doesn't work like that, because *state is const.)
I don't like that .apply() is called twice and without having thought
much about it, I'd prefer explicit support in the lowlevel drivers over
this approach.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2023-04-14 5:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 1:04 [PATCH v2] pwm: mediatek: support inverted polarity Lorenz Brun
2023-04-06 13:38 ` Thierry Reding
2023-04-06 13:53 ` Uwe Kleine-König
2023-04-06 14:30 ` Thierry Reding
2023-04-14 5:39 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230414053956.brgzufk4qjsswhqn@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=angelogioacchino.delregno@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=lorenz@brun.one \
--cc=matthias.bgg@gmail.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).